From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id yEAZM9675mByGQAAgWs5BA (envelope-from ) for ; Thu, 08 Jul 2021 10:48:30 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iD3ZLt675mClLgAAB5/wlQ (envelope-from ) for ; Thu, 08 Jul 2021 08:48:30 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 34AC8248C2 for ; Thu, 8 Jul 2021 10:48:30 +0200 (CEST) Received: from localhost ([::1]:56632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1m1Pht-0008Tp-9J for larch@yhetil.org; Thu, 08 Jul 2021 04:48:29 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46460) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1PhO-0008Tf-GF for emacs-orgmode@gnu.org; Thu, 08 Jul 2021 04:47:58 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:30843) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1m1PhM-00018S-Cx for emacs-orgmode@gnu.org; Thu, 08 Jul 2021 04:47:58 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 4F303240008; Thu, 8 Jul 2021 08:47:52 +0000 (UTC) From: Nicolas Goaziou To: Mark Barton Subject: Re: Bug: tab key no longer bound to org-cycle in commit 565361eb69 [9.4.6 (9.4.6-10-gee652a-elpaplus @ /Users/bartm002/.emacs.d/elpa/org-plus-contrib-20210705/)] References: <874kd6cnys.fsf@ucl.ac.uk> <87lf6itfg2.fsf@nicolasgoaziou.fr> Date: Thu, 08 Jul 2021 10:47:51 +0200 In-Reply-To: (Mark Barton's message of "Wed, 7 Jul 2021 21:18:27 -0700") Message-ID: <87sg0pp4y0.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=217.70.183.193; envelope-from=mail@nicolasgoaziou.fr; helo=relay1-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Org Mode List Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1625734110; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=f8CX+kKg4qBZUBYX6aGVpJ9causduyUtHfnVTL0qhIY=; b=R6UKMGEquvXxSW8u8UzVfCmvl2FFPi4SHUCoN0aetW15FpaWCmRjaoWiASlETQWVtKqlCp 0dv9V1NRzK7ADDT2qHTby8XgZuDak4Yu0yXKixfOj2TEbpMhV1WhNU7HDjZbKh9PKKD5ns 9q2sHkG1rR4LAr8l3r3A4O6m+wEDDKrmdSuMtDgbsRpyg16e2yMWLavJvOeHzdEYMtbrna otXKsIDhhisvpCxf7w1xyakC+GHSbHxJ248Dra6tJeKaY8+pihm8VLchcpA0uES0Anj2Rb YJaHAGmnQPhsgM4bhhHArJ9xN8QwYf83t+RKZiPsuE85BuO4QLImVHcDVXGkaw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1625734110; a=rsa-sha256; cv=none; b=jGxzO2H2N578SAXjy/moWL75LqKR7SSeHnSeC8WHghwNDlo8IUJW78tZb/uEiaaXlL1A4r TV4O8Mz6uw+sBSpxlMWmCGeHGGNtD28e6FfysXbFYvDiojDCphQXsGrMWmZSK/0Rl7FhlT DfTD2Dwrbpdp5b8MycpgZfI07IT0xIOGAgZAZGf2LRKar2EOs9yPnvg49SnGgYoPSUUvka GXIojQI+/7dw4qxp20cpA1DnyYkJY5nXABXgBqW8gqx+AidWFXzLB/0LQHQ4eVq6bIrqLb MzA5oA7w+YS/f2kz4EE3A4ErUdBKE0hBOoIAQOQDlwZxfJFQ+iqu7SharuYzKQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.41 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: 34AC8248C2 X-Spam-Score: -2.41 X-Migadu-Scanner: scn0.migadu.com X-TUID: s4deCmETF7pj Hello, Mark Barton writes: > So I put back the mapping in org-key.el to map TAB instead of in my= local copy and instead commented out line 185 in outline.el to get TAB to = map to org-cycle. > > =E2=80=94=E2=80=94snippet from outline.el > (defvar outline-mode-cycle-map > (let ((map (make-sparse-keymap))) > (let ((tab-binding `(menu-item > "" outline-cycle > ;; Only takes effect if point is on a heading. > :filter ,(lambda (cmd) > (when (outline-on-heading-p) cmd))))) > (define-key map [tab] tab-binding) > (define-key map (kbd "TAB") tab-binding) > (define-key map (kbd "") #'outline-cycle-buffer)) > map) > "Keymap used by `outline-mode-map' and `outline-minor-mode-cycle'.") > > Does that sound like the right thing to do? If so then I could submit > it to the Emacs dev list. There are multiple solutions to this. But, as I wrote, you ought to answer in the other thread I mentioned, the one that initiated this change, and probably to Emacs Devel. Regards, --=20 Nicolas Goaziou