From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id ZIaQIOvsDmGgHQAAgWs5BA (envelope-from ) for ; Sat, 07 Aug 2021 22:28:27 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id KJysG+vsDmGFRgAA1q6Kng (envelope-from ) for ; Sat, 07 Aug 2021 20:28:27 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id DA1114276 for ; Sat, 7 Aug 2021 22:28:26 +0200 (CEST) Received: from localhost ([::1]:39016 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mCSvh-0002wM-Bd for larch@yhetil.org; Sat, 07 Aug 2021 16:28:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35818) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCSvL-0002w8-RU for emacs-orgmode@gnu.org; Sat, 07 Aug 2021 16:28:03 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:34835) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mCSvH-0003BH-R5 for emacs-orgmode@gnu.org; Sat, 07 Aug 2021 16:28:03 -0400 Received: (Authenticated sender: admin@nicolasgoaziou.fr) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id C5E32E0004; Sat, 7 Aug 2021 20:27:56 +0000 (UTC) From: Nicolas Goaziou To: Maxim Nikulin Subject: Re: citations: rx problems with emacs-26.3 References: Date: Sat, 07 Aug 2021 22:27:55 +0200 In-Reply-To: (Maxim Nikulin's message of "Sun, 11 Jul 2021 17:36:59 +0700") Message-ID: <87sfzlc850.fsf@nicolasgoaziou.fr> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=217.70.183.196; envelope-from=mail@nicolasgoaziou.fr; helo=relay4-d.mail.gandi.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: emacs-orgmode@gnu.org Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: "Emacs-orgmode" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1628368107; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=tpy+2v4L6CL/UCZqrlfbrwBh47WyWqA5txdCqu+kjxA=; b=TtcmysQAVdAE/GPa72DBBOKOaR3/NeYmipGAAOmHDwDOPGtNa+JQiB+Pi5fyioW+FjVjyV a2itovdoCCSG4DEWXlH1QCQ9rKgxli0XWoIXJVtDMFY03o7zfYsd4e2pfKqpV8MRVB1hlm v2mMBpSfwcRYlK+2y6rPKGckNpYvOJsJ6dyX83230zUhqalk9u0EaYqw6Kg6kvKo8Z0czV bpXCV/KLak7aB6xZvbKkNfcFodQI080HkC8pTOlxI4b6Cgq4me14lAcaXmNdl1M5zvXxG3 VBwrRIPf9msB0q2xkd0JloXkez1jqTPcDVRjbbbmeypAKXaCuWSmOivyzlvOjw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1628368107; a=rsa-sha256; cv=none; b=kI1z2EH3fasWPxm2pO1D1P5JeysDESt266b5kFa7FX5YdeVafuDIFNv1Bq74A1y5zZc9LU MJ5mrMyiQhTB50EYEi1HCWwZgzqfK9GLt44blLB4cZK2eyV5O3VGXuxL6m2BtUieDxMauZ ThAMCGDYaD3DWW3f3AlY4U+2lkDcteSrsygGo7kcSm+nwxbnpgDUnGrvmzkakXHfl9yzoi wXjDKGscbL3HVANWCyd3733MpDj2Wj96cD95Eo5TuUZMkqaSdOR8anhuHSOCaIoT77WmH/ CBBej9cHSaEgRuDVeABshZlq9gcqkBPB0lhxFBYpZNcvw5gfoy1LbogRVF3NVg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Spam-Score: -2.42 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of emacs-orgmode-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=emacs-orgmode-bounces@gnu.org X-Migadu-Queue-Id: DA1114276 X-Spam-Score: -2.42 X-Migadu-Scanner: scn0.migadu.com X-TUID: WXos2LvRXtWk Hello, Maxim Nikulin writes: > I think citation support is a great feature. (Sorry, I do not work > with references now, so I can tell nothing concerning implementation > for org.) > > It seems, rx e.g. in emacs-26.3 does not support all features used in > oc.el and oc-csl.el. Loading an org file using git master, I get > a warning > >> Eager macro-expansion failure: (error "rx form =E2=80=98regexp=E2=80=99 = requires args satisfying =E2=80=98stringp=E2=80=99") > > It looks like (rx (regexp ...)) require namely literal, variables are > not supported yet. In additional (rx (literal ...)) is not supported > as well. > >> Eager macro-expansion failure: (error "Unknown rx form =E2=80=98literal= =E2=80=99") > > In a couple of places `rx-to-string' likely could be used instead of > just `rx'. I have no idea yet what could be done with (pcase-let* ((rx=20 > ...))) in `org-cite-adjust-note'. > >> diff --git a/lisp/oc-basic.el b/lisp/oc-basic.el Thanks. Could you send the patch again with a proper commit message, using git format-patch? Regards, --=20 Nicolas Goaziou