From: Philip Kaludercic <philipk@posteo.net>
To: Juri Linkov <juri@linkov.net>
Cc: 50552@debbugs.gnu.org
Subject: bug#50552: 28.0.50; Add context-menu-occur
Date: Wed, 29 Sep 2021 10:00:11 +0000 [thread overview]
Message-ID: <87sfxnu2fo.fsf@posteo.net> (raw)
In-Reply-To: <875yujc2kq.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 29 Sep 2021 10:19:29 +0300")
Juri Linkov <juri@linkov.net> writes:
>>>> I see, but I wonder why dictionary.el directly manipulates
>>>> context-menu-functions with add-hook.
>>>
>>> The reasoning was the following: by default, dictionary.el is not loaded,
>>> so its context menu item is not used. But when the user wants to use
>>> dictionary.el and explicitly loads it, then automatically provide also
>>> its context menu item.
>>
>> On this topic, I am not sure how good it is to do this
>> automatically. One effect seems to be that context-menu-dictionary
>> inserts itself at an unintended place in the menu (in my case as the
>> first item, even though I'd prefer it to be further down). Might it make
>> more sense to autoload context-menu-dictionary and let the user manually
>> add it to context-menu-functions?
>
> Then we need to decide what is the preferred way for the users
> to add the dictionary menu item to the context menu.
>
> 1. One possible way is allow the user to customize context-menu-functions,
> and manually paste context-menu-dictionary to the entry field:
>
> INS DEL Choice: Value Menu Custom function: context-menu-dictionary
Why not use the new custom-add-choice function (or something along these
lines) in dictionary.el?
> 2. To allow using 'add-hook' in the user's init file with e.g.
>
> (add-hook 'context-menu-functions 'context-menu-dictionary 1)
In my case I am setting context-menu-functions manually, without
add-hook. I am not sure if that breaks anything?
> In either case, 'context-menu-dictionary' should be autoloaded
> like you suggested. So now I've changed dictionary.el according to this,
> thanks for the suggestion.
Great, thank you.
--
Philip Kaludercic
next prev parent reply other threads:[~2021-09-29 10:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-12 16:54 bug#50552: 28.0.50; Add context-menu-occur Philip Kaludercic
2021-09-12 17:59 ` Juri Linkov
2021-09-12 19:09 ` Philip Kaludercic
2021-09-13 8:28 ` Juri Linkov
2021-09-14 20:45 ` Philip Kaludercic
2021-09-15 7:14 ` Juri Linkov
2021-09-28 20:00 ` Philip Kaludercic
2021-09-29 7:19 ` Juri Linkov
2021-09-29 10:00 ` Philip Kaludercic [this message]
2021-09-29 17:31 ` Juri Linkov
2021-10-02 19:29 ` Juri Linkov
2021-10-01 16:28 ` Philip Kaludercic
2021-10-02 19:25 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfxnu2fo.fsf@posteo.net \
--to=philipk@posteo.net \
--cc=50552@debbugs.gnu.org \
--cc=juri@linkov.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.