From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.devel Subject: Re: Moving kbd to subr.el Date: Sat, 16 Oct 2021 17:55:37 +0200 Message-ID: <87sfx10xs6.fsf@gnus.org> References: <20211004081724.6281.11798@vcs0.savannah.gnu.org> <87o87ubcnl.fsf@gnus.org> <87h7dm9en7.fsf@gnus.org> <87czoa9e7p.fsf@gnus.org> <878ryxakv9.fsf@gnus.org> <834k9km5no.fsf@gnu.org> <83k0iflsze.fsf@gnu.org> <874k9jzu7a.fsf@gnus.org> <874k9juy0r.fsf@gnus.org> <87mtnbtimj.fsf@gnus.org> <87wnmd13ny.fsf@gnus.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34143"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Emacs developers To: Stefan Kangas Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Oct 16 17:57:03 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbm3S-0008hJ-VG for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Oct 2021 17:57:02 +0200 Original-Received: from localhost ([::1]:50550 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mbm3S-0002rC-1l for ged-emacs-devel@m.gmane-mx.org; Sat, 16 Oct 2021 11:57:02 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:49250) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbm2E-00024v-HX for emacs-devel@gnu.org; Sat, 16 Oct 2021 11:55:47 -0400 Original-Received: from quimby.gnus.org ([2a01:4f9:2b:f0f::2]:50326) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mbm2C-0005sC-7C for emacs-devel@gnu.org; Sat, 16 Oct 2021 11:55:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=Yx0mRTWTuMMg/COtnzcbTMlpiHNCnmCY2vE7UxKlmiE=; b=Cpkllmd5GY9UdEWv1VKuARp7JS 7ddQ+H/ALbM52IuUeC7b4rOYokE0YlyzKUHaMZbGCKVrOvadd0aqcXs43FmGFNrUHf7GiLSbYGdz+ ZDPzoZxPMlcggtzrCwBCGS4pWIaxJsJB24aIKQvFdab/3bBTd/uxNBHHU2pWi3smJzv0=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mbm25-0000fl-Pw; Sat, 16 Oct 2021 17:55:40 +0200 Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEV9fmOGhYlNTUx2 dhCCgRWAfhOvx8b///8EnAsbAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+UKEA81JAWaDvUAAAGsSURB VDjLdZJbkuMgDEUFU9XfwArgUvnvQbCBuLKBxux/KyORdAd73DeOLesg9MBkvDfOeSJ5+pfUICIn f0PfcvNuPM0lbl4Hkf9FJ2CugfPJmUvgUkhnEGRpoPg/sEnhNSDnL4GBDMBegATyFJJbgCN4GyPB 2JDgfZLCBQQbIqyFNYgKjOwJI8BCZRGD3G2SLAEhkXn6nwyEiBiD/Cj++KMToMtSEJPE8Q0wwXwo sO+9NMcE0QqQamf4M0pDnKYjyEHOvFN/vdcKgKo5DBcx+RMxi5G5yHiYPmFj+xLQFELBV/xwmQpY lDtzUYPnq6SixvvG3Iaodx5D/bIK1LDd1N9H51XEKFm8U4t/UJVCtvryt5+wRnwH7vmhCVYJkALv eJTGJ6A9F9Ryk4i2gj9zFBXo7RBEPSNDr8oNC5IGc9aJ4MYV2wr2nFGkhMZ1rYC4yqTKXtB6le0W 0HYBTWZZ8glIx5v0v8lWBzAnqifSdpzB4L4h93KsSme+j54fteQDGC/1VnK/AkNa3d7jojEW0uex vpIvQOu7Alpee4N3Ejl5Hoc+nh9P4/Vz+AcsorMXoWMPvwAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAy MS0xMC0xNlQxNTo1MzozNiswMDowMF377C4AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjEtMTAtMTZU MTU6NTM6MzYrMDA6MDAsplSSAAAAAElFTkSuQmCC X-Now-Playing: Joni Mitchell's _The Hissing Of Summer Lawns_: "The Boho Dance" In-Reply-To: (Stefan Kangas's message of "Sat, 16 Oct 2021 16:33:47 +0200") Received-SPF: pass client-ip=2a01:4f9:2b:f0f::2; envelope-from=larsi@gnus.org; helo=quimby.gnus.org X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:277183 Archived-At: Stefan Kangas writes: > Certainly. Now done in commit e082a16284 and 8ee63604e3. Thanks! > We might as well fix the (<= 0 ch 127) bit, as I didn't do that in my patch. > > (I know there are different styles, but I personally often think it's > nice to put such cleanups in their own commits to facilitate later > bisecting.) Sure. I waffle between the two styles because I don't want to add noise (so fewer commits are better), but at the same time, keeping cleanups separate makes the functional changes easier to comprehend (so more commits are better). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no