From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Lars Ingebrigtsen Newsgroups: gmane.emacs.bugs Subject: bug#51316: 29.0.50; Should we match the final ".git" in bug-reference autosetup? Date: Fri, 22 Oct 2021 16:59:54 +0200 Message-ID: <87sfwtcdg5.fsf@gnus.org> References: <87ilxqbmg7.fsf@miha-pc> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20792"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 51316@debbugs.gnu.org, Tassilo Horn To: miha@kamnitnik.top Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Oct 22 17:05:53 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdw7E-0005Cv-Rx for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Oct 2021 17:05:52 +0200 Original-Received: from localhost ([::1]:33240 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mdw7D-0008HR-OG for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Oct 2021 11:05:51 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:52040) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mdw2Y-0002Jf-M5 for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2021 11:01:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50293) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mdw2Y-00062p-Af for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2021 11:01:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1mdw2Y-0001U7-2o for bug-gnu-emacs@gnu.org; Fri, 22 Oct 2021 11:01:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Oct 2021 15:01:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 51316 X-GNU-PR-Package: emacs Original-Received: via spool by 51316-submit@debbugs.gnu.org id=B51316.16349148105606 (code B ref 51316); Fri, 22 Oct 2021 15:01:02 +0000 Original-Received: (at 51316) by debbugs.gnu.org; 22 Oct 2021 15:00:10 +0000 Original-Received: from localhost ([127.0.0.1]:33602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdw1h-0001SL-Kd for submit@debbugs.gnu.org; Fri, 22 Oct 2021 11:00:10 -0400 Original-Received: from quimby.gnus.org ([95.216.78.240]:45872) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1mdw1c-0001Q5-RL for 51316@debbugs.gnu.org; Fri, 22 Oct 2021 11:00:07 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=tPban6egdJ5mfv5wT8QXA2QwIcgOsjypK3zXWRn//+Y=; b=J5wY8jCsLjlpGdOBrwaW/N9Wll K0ZUB2VbZmVA3FJTbKmvKJVPNSTvtNdBVV7BSZuTx0s7w1v4s+e3J95tP9LzL9c6iKOjhDYxkL0yd +0AXY/fn0U+p0azlRSM8brfHxfZd37OTQl8Iwyv0RHv4Cm5xWNn6pbTZpWbHYurMYHLQ=; Original-Received: from [84.212.220.105] (helo=elva) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mdw1S-000609-LE; Fri, 22 Oct 2021 16:59:57 +0200 X-Now-Playing: Helen Money's _Atomic_: "Redshift" In-Reply-To: <87ilxqbmg7.fsf@miha-pc> (miha@kamnitnik.top's message of "Thu, 21 Oct 2021 14:18:32 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:217888 Archived-At: miha@kamnitnik.top writes: > If function 'bug-reference--build-forge-setup-entry': > >> `(,(concat "[/@]" host-domain "[/:]\\([.A-Za-z0-9_/-]+\\)\\.git") > This should be "(regexp-quote host-domain)". This is now fixed in Emacs 28. > Also, it would be nice if the final "\\.git" wasn't mandatory. I often > git clone a website url as displayed in a web browser > ("https://gitlab.com/rstocker/emacs-bluetooth" for example) without > appending ".git". Git has no problem fetching from such an url (tested > with github, gitlab and gitea), but bug-reference autosetup machinery > fails to detect it as a valid url. > > Unfortunately, we can't simply change the final .git into > "\\(?:\\.git\\)?" because regexp greediness would then swallow it into > the first match group. This would work, though: "[/:]\\([.A-Za-z0-9_/-]+?\\)\\(?:\\.git\\)?\\'" But requires that the string doesn't have anything after the .git, whereas it's currently more sloppy. I'm not sure whether that's by intent or not. (So I'm adding Tassilo to the CCs.) This is a feature request, in any case, so it should go to Emacs 29, I think. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no