From: Lars Ingebrigtsen <larsi@gnus.org>
To: miha@kamnitnik.top
Cc: 51316@debbugs.gnu.org, Tassilo Horn <tsdh@gnu.org>
Subject: bug#51316: 29.0.50; Should we match the final ".git" in bug-reference autosetup?
Date: Fri, 22 Oct 2021 16:59:54 +0200 [thread overview]
Message-ID: <87sfwtcdg5.fsf@gnus.org> (raw)
In-Reply-To: <87ilxqbmg7.fsf@miha-pc> (miha@kamnitnik.top's message of "Thu, 21 Oct 2021 14:18:32 +0200")
miha@kamnitnik.top writes:
> If function 'bug-reference--build-forge-setup-entry':
>
>> `(,(concat "[/@]" host-domain "[/:]\\([.A-Za-z0-9_/-]+\\)\\.git")
> This should be "(regexp-quote host-domain)".
This is now fixed in Emacs 28.
> Also, it would be nice if the final "\\.git" wasn't mandatory. I often
> git clone a website url as displayed in a web browser
> ("https://gitlab.com/rstocker/emacs-bluetooth" for example) without
> appending ".git". Git has no problem fetching from such an url (tested
> with github, gitlab and gitea), but bug-reference autosetup machinery
> fails to detect it as a valid url.
>
> Unfortunately, we can't simply change the final .git into
> "\\(?:\\.git\\)?" because regexp greediness would then swallow it into
> the first match group.
This would work, though:
"[/:]\\([.A-Za-z0-9_/-]+?\\)\\(?:\\.git\\)?\\'"
But requires that the string doesn't have anything after the .git,
whereas it's currently more sloppy. I'm not sure whether that's by
intent or not. (So I'm adding Tassilo to the CCs.)
This is a feature request, in any case, so it should go to Emacs 29, I
think.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-10-22 14:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-21 12:18 bug#51316: 29.0.50; Should we match the final ".git" in bug-reference autosetup? miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-22 14:59 ` Lars Ingebrigtsen [this message]
2021-10-22 20:45 ` Tassilo Horn
2021-10-22 21:42 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-23 9:12 ` Tassilo Horn
2021-10-23 12:58 ` Gregory Heytings
2021-10-24 12:17 ` Lars Ingebrigtsen
2021-10-26 9:01 ` miha--- via Bug reports for GNU Emacs, the Swiss army knife of text editors
2021-10-27 13:02 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfwtcdg5.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=51316@debbugs.gnu.org \
--cc=miha@kamnitnik.top \
--cc=tsdh@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.