From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: master 1914d94 2/2: Change how Dired displays available space Date: Thu, 02 Dec 2021 17:09:36 +0100 Message-ID: <87sfvbm1j3.fsf@gmx.de> References: <20211201222724.19544.19533@vcs0.savannah.gnu.org> <20211201222726.7AFF521362@vcs0.savannah.gnu.org> <87wnknm4zb.fsf@gmx.de> <87v90710bv.fsf@gnus.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10540"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Lars Ingebrigtsen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Dec 02 17:12:00 2021 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1msogh-0002XM-SX for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Dec 2021 17:11:59 +0100 Original-Received: from localhost ([::1]:41448 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1msogg-0006Y6-Dn for ged-emacs-devel@m.gmane-mx.org; Thu, 02 Dec 2021 11:11:58 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:46336) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msoeT-0004Ae-Lx for emacs-devel@gnu.org; Thu, 02 Dec 2021 11:09:41 -0500 Original-Received: from mout.gmx.net ([212.227.17.21]:34741) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1msoeR-0002Ax-Fv for emacs-devel@gnu.org; Thu, 02 Dec 2021 11:09:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1638461377; bh=T/9maWrqiUmwXfk5HAmOCAYhgOUcFkPkSqA/a+qkgs4=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=ghZjHEncIpro3dfEpVl+tykOWx+IzK5vsb35OzlWUafoLSIygbgI5MTX2dTl02K3p lWmymMJv+w9UQ54jQ099+kPFdEiRxL+oXsepWJcdb/otqGTaqc9B0WSWMiQOykzJmD b7g+fVaqHc1fke6w7RqpLUXyW6c7kdY0MxLhNdcU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.157.166]) by mail.gmx.net (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MulmF-1mbpdC21Jr-00rl6a; Thu, 02 Dec 2021 17:09:37 +0100 In-Reply-To: <87v90710bv.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 02 Dec 2021 16:41:08 +0100") X-Provags-ID: V03:K1:vkP9gzim9MHoMmLAen6g/5VF8eqfVE0iExSJDqXt/6+tiZlGXgx arX9gCz0VN1j5j+HEua3W+X85HoWnphvNpDrk/QbK7vqh9jbRk7oJ0kub/1iowG9TcfilMY CVAHWz+sM7bbJ7ZsDol8zgRP86Ta1xPQgSkgz5xsPOaTe+DZ5jCFN/sStra1wcXn2v5nzJM ADr2mfu4D8nSUNEK6VZCw== X-UI-Out-Filterresults: notjunk:1;V03:K0:DuSp+aYF6HE=:d2xqoa7nhzZRyO5cU683CS 9i4/ruiQgVFoHplapulZps0vwMfhE+oyJ7x4WthVqSp53JTw2jAyazKJO6iXXDRFrkTRljioP kVsem79fMIx6aLmVr41TaOM4lps4qJO2q7GiC2KEtKWlxwNvn/t/6CVi7IHu1oMei0Eg6Y+s+ o7lefDy/UOJXmtJAg0BHFLs61FqObffZEmoaGjZwWgBmSWubPYLcu7dIBGK13UIVVIG85Va9v ++ga31oWsUihligsxIH+K+ujYMeGSeRRFaWVmOQflZ7nsQV/eJUiI/uslKKgF7iNpQQuf8ygx R15C8iNr+bqb1oobZo1eIY5r9lCDoPORm4mG6bdJ9aInGrItFn+qLCJJEGf5Nv+0VPjpoBoYn q8nO7HG70rdY5Uwydk5+mlIoGgSJe6h9a4iAghkeZzmGYwoCCKje0tIZf9tfaCZZW4SUHvRhN /YAY1DzoLZeQMU0KBh5ZPE68UuLErRQR5uGPlI/eeLAuATGa/rJNTjUILRuiX96nijuQcdlzV W2sFaNtMS65e9ejWk9YeXrzoIkfTgZ15WZu64R1IJAaeHq0/PgrCZ5vICg+nBAU7EyT0QI3+s 2tvLuSc6HNVBcvdcQKM+SvA+eWGH6hnlGD6ig1YKk5yxSvEAEyhwMTy5K5Hc0y5q8tg61BSEl E+ppSUesU/kdKn2MS8Nz9I7QJvWlYoz6PeleknwyLsWsvftPUmD0uyAoaFQvakdOLUmx/MVWS /psKy7guBgq9UsvlezBcVFauXWB1dLB26ena8tgd08mnzo1pm6Qo+hTPb1VraUckQprjrvdg Received-SPF: pass client-ip=212.227.17.21; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:280763 Archived-At: --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: Hi Lars, >> Hmm. insert-directory can be used w/o being called from dired. And there >> are further implementations of insert-directory, because it uses file >> name handlers. So these functions must be adapted as well. > > My assumption was that (as for the first bit) that not translating the > "total x" thing wouldn't be catastrophic, so that could be adjusted > afterwards. "Afterwards" is in dired-insert-directory? As said, this is not always in play. > As for the other implementations, I assumed that they would just > continue to work as is, and if they do that "total" transformation, it > would be trivial to just remove that bit. > > If this causes major problems, I'm sorry. Don't know whether it causes major problems. I guess the cases in core Emacs can be fixed easily. For possible other implementations in the wild, I don't know. >> Granted, most of them are from Tramp, but there could be also other >> implementations in the wild. >> >> Is there a shiny reason to move this functionality from insert-directory >> to dired-insert-directory? A discussion about, or at least a trigger for >> this change (aka announcement in etc/NEWS), would have been appreciated. > > I implemented this first as a part of insert-directory. But the problem > is that it's dired itself that prepends the /current/path/name at the > top, so the thing had to go to dired. I do not oppose heavily to this change. The advantage is, that the boring "adjust the free disk space" must not be implemented again and again in all insert-directory incarnations. But a coordinated change would have been better ... Well, what about this change in etc/NEWS: --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Transfer-Encoding: quoted-printable diff --git a/etc/NEWS b/etc/NEWS index d783fc019c..304f707f2e 100644 =2D-- a/etc/NEWS +++ b/etc/NEWS @@ -741,6 +741,10 @@ with recent versions of Firefox. ** The function 'image-dired-get-exif-data' is now obsolete. Use 'exif-parse-file' and 'exif-field' instead. +--- +** 'insert-directory' alternatives should not change the free disk space = line. +This change is now applied in 'dired-insert-directory'. + =0C * Lisp Changes in Emacs 29.1 --=-=-= Content-Type: text/plain And I will see what must be done in Tramp and ange-ftp.el Best regards, Michael. --=-=-=--