Re: master 1914d94 2/2: Change how Dired displays available space

[Michael Albinus <michael.albinus@gmx.de>]

[-- Attachment #1: Type: text/plain, Size: 1699 bytes --]

Lars Ingebrigtsen <larsi@gnus.org> writes:

Hi Lars,

>> Hmm. insert-directory can be used w/o being called from dired. And there
>> are further implementations of insert-directory, because it uses file
>> name handlers. So these functions must be adapted as well.
>
> My assumption was that (as for the first bit) that not translating the
> "total x" thing wouldn't be catastrophic, so that could be adjusted
> afterwards.

"Afterwards" is in dired-insert-directory? As said, this is not always
in play.

> As for the other implementations, I assumed that they would just
> continue to work as is, and if they do that "total" transformation, it
> would be trivial to just remove that bit.
>
> If this causes major problems, I'm sorry.

Don't know whether it causes major problems. I guess the cases in core
Emacs can be fixed easily. For possible other implementations in the
wild, I don't know.

>> Granted, most of them are from Tramp, but there could be also other
>> implementations in the wild.
>>
>> Is there a shiny reason to move this functionality from insert-directory
>> to dired-insert-directory? A discussion about, or at least a trigger for
>> this change (aka announcement in etc/NEWS), would have been appreciated.
>
> I implemented this first as a part of insert-directory.  But the problem
> is that it's dired itself that prepends the /current/path/name at the
> top, so the thing had to go to dired.

I do not oppose heavily to this change. The advantage is, that the
boring "adjust the free disk space" must not be implemented again and
again in all insert-directory incarnations. But a coordinated change
would have been better ...

Well, what about this change in etc/NEWS:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 458 bytes --]

diff --git a/etc/NEWS b/etc/NEWS
index d783fc019c..304f707f2e 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -741,6 +741,10 @@ with recent versions of Firefox.
 ** The function 'image-dired-get-exif-data' is now obsolete.
 Use 'exif-parse-file' and 'exif-field' instead.

+---
+** 'insert-directory' alternatives should not change the free disk space line.
+This change is now applied in 'dired-insert-directory'.
+
 \f
 * Lisp Changes in Emacs 29.1


[-- Attachment #3: Type: text/plain, Size: 83 bytes --]


And I will see what must be done in Tramp and ange-ftp.el

Best regards, Michael.