From: Lars Ingebrigtsen <larsi@gnus.org>
To: Philipp Stephani <p.stephani2@gmail.com>
Cc: 52281@debbugs.gnu.org
Subject: bug#52281: 28.0.90; batch-byte-compile breaking up warnings in batch mode
Date: Sat, 04 Dec 2021 20:59:13 +0100 [thread overview]
Message-ID: <87sfv83zvy.fsf@gnus.org> (raw)
In-Reply-To: <wvr4tufogre2.fsf@gmail.com> (Philipp Stephani's message of "Sat, 04 Dec 2021 19:24:21 +0100")
Philipp Stephani <p.stephani2@gmail.com> writes:
> This is inconsistent, and causes parsers (such as Emacs's compilation
> mode) to incorrectly parse these messages. I think messages in batch
> mode should never be broken up.
The following should fix the issue:
diff --git a/lisp/emacs-lisp/warnings.el b/lisp/emacs-lisp/warnings.el
index 36b275e2d3..1d061364a0 100644
--- a/lisp/emacs-lisp/warnings.el
+++ b/lisp/emacs-lisp/warnings.el
@@ -307,7 +307,9 @@ display-warning
'type 'warning-suppress-log-warning
'warning-type type))
(funcall newline)
- (when (and warning-fill-prefix (not (string-search "\n" message)))
+ (when (and warning-fill-prefix
+ (not (string-search "\n" message))
+ (not noninteractive))
(let ((fill-prefix warning-fill-prefix)
(fill-column warning-fill-column))
(fill-region start (point))))
Does anybody have an opinion here?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2021-12-04 19:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-04 18:24 bug#52281: 28.0.90; batch-byte-compile breaking up warnings in batch mode Philipp Stephani
2021-12-04 19:59 ` Lars Ingebrigtsen [this message]
2021-12-06 1:10 ` Stefan Kangas
2021-12-06 1:23 ` Lars Ingebrigtsen
2021-12-06 1:42 ` Stefan Kangas
2021-12-06 9:17 ` Philipp Stephani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfv83zvy.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=52281@debbugs.gnu.org \
--cc=p.stephani2@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.