all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: master c9cb59b 2/2: * etc/TODO: Entry about converting to defvar-keymap.
@ 2021-12-10 15:00 Eli Zaretskii
  2021-12-10 15:37 ` Stefan Kangas
  2021-12-10 15:59 ` dick
  0 siblings, 2 replies; 8+ messages in thread
From: Eli Zaretskii @ 2021-12-10 15:00 UTC (permalink / raw)
  To: Stefan Kangas; +Cc: emacs-devel

> +** Convert defvar foo-mode-map to defvar-keymap
> +Verify the conversion by comparing the value of the keymap before
> +converting it and after (you can see the value in 'C-h v').

Really?  What are the benefits of doing such a conversion?  I see only
a lot of code churn and a risk of breaking things that are perfectly
fine as they are.

And that goes for many of the changes in this direction you made
lately, btw: why are we making all those changes for purely stylistic
reasons?  It was always our policy not to do that except when fixing
real bugs in the same area.

I'd prefer that the energy and the time you have to work on Emacs
would be invested to make more important changes: fixing bugs, adding
new features, etc.  We don't have enough resources to expend them on
changes like these ones.

TIA



^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2021-12-11  6:20 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-10 15:00 master c9cb59b 2/2: * etc/TODO: Entry about converting to defvar-keymap Eli Zaretskii
2021-12-10 15:37 ` Stefan Kangas
2021-12-10 16:51   ` Eli Zaretskii
2021-12-11  3:02     ` Lars Ingebrigtsen
2021-12-11  6:20       ` Stefan Kangas
2021-12-10 15:59 ` dick
2021-12-10 16:44   ` Alan Mackenzie
2021-12-11  0:56   ` Po Lu

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.