From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stephen Berman Newsgroups: gmane.emacs.bugs Subject: bug#52856: 29.0.50; Problematic handling of webkit xwidget bookmarks Date: Wed, 29 Dec 2021 11:50:26 +0100 Message-ID: <87sfubfzwt.fsf@gmx.net> References: <875yr8wn9e.fsf@gmx.net> <87ilv7ub1o.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18375"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 52856@debbugs.gnu.org To: Po Lu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 29 11:51:31 2021 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n2WYN-0004Zu-8R for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Dec 2021 11:51:31 +0100 Original-Received: from localhost ([::1]:60276 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1n2WYK-0004mR-Gi for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 29 Dec 2021 05:51:29 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:47566) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1n2WXu-0004kp-Gi for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2021 05:51:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36558) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1n2WXu-0001rA-7G for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2021 05:51:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1n2WXt-0004IM-Vh for bug-gnu-emacs@gnu.org; Wed, 29 Dec 2021 05:51:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 29 Dec 2021 10:51:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 52856 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 52856-submit@debbugs.gnu.org id=B52856.164077503916477 (code B ref 52856); Wed, 29 Dec 2021 10:51:01 +0000 Original-Received: (at 52856) by debbugs.gnu.org; 29 Dec 2021 10:50:39 +0000 Original-Received: from localhost ([127.0.0.1]:48104 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2WXX-0004Hh-EY for submit@debbugs.gnu.org; Wed, 29 Dec 2021 05:50:39 -0500 Original-Received: from mout.gmx.net ([212.227.15.19]:33789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1n2WXW-0004HU-1t for 52856@debbugs.gnu.org; Wed, 29 Dec 2021 05:50:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1640775029; bh=ZHbbCSsboxZvgh2+uXxyHQJ+iAs6hjaIPDjGCBQhOiA=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=lmbMkHASodQlfsm985FmzuhQDULrejwfspvoDuqTxD7++0bZ92juqVpvS9wFF7Nkl VeXiAaeIFkBB+pPF51kp/P30OMmroxq2unikX98Z1izkuiJnTc3gork7g8zbk4E/eD qkREYiqfO1RRx5WllqJ3ZhDAhUY6wyZWKBbzCrvc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from strobelfs ([89.246.38.30]) by mail.gmx.net (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N49h5-1mKyMG0Vl3-01050N; Wed, 29 Dec 2021 11:50:29 +0100 In-Reply-To: <87ilv7ub1o.fsf@yahoo.com> (Po Lu's message of "Wed, 29 Dec 2021 15:26:11 +0800") X-Provags-ID: V03:K1:UGCtx9aAfwQ9y80kM7/x16fDh/7jrfpNbdUghvxtDXlphxLQRjZ E6tgFsg0QAuxwTQHEW796N8ZVNwE7ulzxklkCQ9UOGvsMzB1jD8QLl42qWf3/YkYjcLgA6p fBwTDQgJQz8hkhRHGB9OVx/TN5vi3DvZfYnKpsA9rrUjZDnKAfl11yq2y2gjbYL9zMMScyX TAYGmz9uEXCp06NiODF/g== X-UI-Out-Filterresults: notjunk:1;V03:K0:9ZoUxhiwewU=:0uVq+G4Zh4p9H5kJRuJdr2 x8rNYjzxJp5xnEnjqbHkpDi/N6Mywwugx0JNDs7qMIYsBnh5RbNGVPc5DCDoR7vvsTiI4qEW2 O+y2bMbLpXU9ZqpqhxbGhPRDEHP1WLtWaKNlB9xTZXFLz7tdTKAeikJ3jSawWpHEEBOm6AmZK EhTe3HV3Is4Kpr1BjsY7Nx1C7AaxIBBPLiez4om+07V2UW+tUOdoxS/iFhkwzUdr+0ygbRL0o vPttIoUZeRaPWp2Nuv6Wio6Tk0TFMGx+Gf3PVjAjt7yCadpd+hdMeuWUJGx/nM+1eGibbB008 En1plBnrqacJ3FXda63/5f+P4DpEpIrKvQesTzFy8GgBfGyAq0QIvT3ZVnJbTI1ONHuMcK2Qz 4F5Un/juKqdntNxpl5MdKHOb9FjmBorvFqUADHjv8cjqGxXMPbPqQzk3grzoRxPDW4splYMeO Sdq7VY2caI1kNL+Y4naMJExHKmagiRZHoWQDyieR9QQxms1eZiJWX/bT5VW3JZ7U2949rIotP MbMc78OYuvSPF73S+Ay1c/C1dzbhOo+xAvuWT9tmU7ioFsSMW2fTO0oCT6pCGsAhK5zmIbnzB 2MkHzAt1vZ0lqWDCIprpnUaCrqZqzGMejKMle+qsqUO9m/puKnRfN+wA3Ez+Aoj6OAeuqDIBG KXuuYhp7n8qiK+9LviQQ/I0JxhR510V3ofdbvcEcKXd0A9EUaPZdBtfw8ImdJlOHwZeKAIoQu 0cHy0oSTjWYgQmZQD5XFaeOJfour2FXu0E2MM8BF7DPgrkAELFS/O0+eOI6Rx6f94m3GxoHo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:223314 Archived-At: On Wed, 29 Dec 2021 15:26:11 +0800 Po Lu wrote: > Stephen Berman writes: > >> If you make a bookmark to a webkit xwidget (i.e. to a URL displayed by >> the xwidget) and then use `bookmark-jump-other-window' or >> `bookmark-jump-other-frame' to jump to the bookmarked URL, the xwidget >> is displayed in both the original window and the other window or other >> frame. > > Does "original window" mean the window that was selected before you ran > `bookmark-jump-other-window' (or frame)? Yes. > If so, you should customize `xwidget-webkit-bookmark-jump-new-session' > to a non-nil value instead. I did, but that just ensures that jumping to the bookmarked xwidget creates a new xwidget session -- it does not prevent the xwidget from being displayed both in the other window/frame and in the originally selected window. My patch ensures that the bookmarked xwidget is displayed only in the other window/frame, which is consistent with the behavior of `bookmark-jump-other-window' and `bookmark-jump-other-frame' with other types of bookmarks (e.g. to PDFs in the pdf-tools package), regardless of whether a new xwidget session is created. However, my bug report was mistaken in reporting that jumping to a bookmarked xwidget before loading xwidget.el raises an error -- with the existing code it succeeds, because there the bookmark uses `xwidget-webkit-browse-url', which is autoloaded. I must have tested that after applying my patch but before adding the autoload cookie (which is needed with my patch). Sorry for the confusion. Steve Berman