all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [PATCH] update ob-scheme to latest changes in geiser package
@ 2021-12-29 18:03 Felipe Lema
  2021-12-30  1:53 ` Felipe Lema
  0 siblings, 1 reply; 11+ messages in thread
From: Felipe Lema @ 2021-12-29 18:03 UTC (permalink / raw)
  To: emacs-orgmode

[-- Attachment #1: Type: text/plain, Size: 548 bytes --]

Sup, y'all

The geiser package had a recent update in which `geiser-eval-region` behaves like an async function and does not return evaluation result. In exchange, the newly introduced `geiser-eval-region/wait` does that now.

I've attached a patch to update ob-scheme.el to reflect these changes. Without them, evaluating scheme dialect code blocks in Org will end up with empty results.

To learn more about the change (and how it impacted other people's flows) see issue thread below

https://gitlab.com/emacs-geiser/geiser/-/issues/30

Felipe


[-- Attachment #2: org-babel-scheme-geiser-eval-region.wait.diff --]
[-- Type: text/x-patch, Size: 820 bytes --]

update to new API call to evaluate region and wait for result

* ob-scheme.el replace `geiser-eval-region` with `geiser-eval-region/wait` as the former changed expected behaviour; the latter returns the result of evaluating.

diff --git a/lisp/org/ob-scheme.el b/lisp/org/ob-scheme.el
index f4836b23fe..89c6abf686 100644
--- a/lisp/org/ob-scheme.el
+++ b/lisp/org/ob-scheme.el
@@ -176,7 +176,7 @@ org-babel-scheme-execute-with-geiser
 	  (setq geiser-impl--implementation nil)
 	  (let ((geiser-debug-jump-to-debug-p nil)
 		(geiser-debug-show-debug-p nil))
-	    (let ((ret (geiser-eval-region (point-min) (point-max))))
+	    (let ((ret (geiser-eval-region/wait (point-min) (point-max))))
 	      (setq result (if output
 			       (or (geiser-eval--retort-output ret)
 				   "Geiser Interpreter produced no output")

^ permalink raw reply related	[flat|nested] 11+ messages in thread
[parent not found: <878rrw0w3x.fsf@terra.tmtvl.info>]

end of thread, other threads:[~2022-05-08 10:03 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-29 18:03 [PATCH] update ob-scheme to latest changes in geiser package Felipe Lema
2021-12-30  1:53 ` Felipe Lema
2021-12-30 15:50   ` Max Nikulin
2021-12-30 19:01   ` Felipe Lema
2021-12-31  4:22     ` Max Nikulin
2022-02-06  9:50       ` Ihor Radchenko
     [not found] <878rrw0w3x.fsf@terra.tmtvl.info>
2022-04-23 13:29 ` Tim Van den Langenbergh
2022-04-26 15:04   ` Felipe Lema
2022-04-27  8:44   ` Ihor Radchenko
2022-05-07 12:04     ` Tim Van den Langenbergh
2022-05-08 10:02       ` Ihor Radchenko

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.