From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 6ed1994d27: Prevent crashes from illegal locale coding systems Date: Thu, 17 Feb 2022 08:45:19 +0800 Message-ID: <87sfsitj6o.fsf@yahoo.com> References: <83czjqrkew.fsf@gnu.org> <87v8xii83e.fsf@yahoo.com> <83r186p1h8.fsf@gnu.org> <878ruehx6n.fsf@yahoo.com> <83h791pmnl.fsf@gnu.org> <87iltheyeu.fsf@yahoo.com> <83wnhwol2o.fsf@gnu.org> <87tud0ybhj.fsf@yahoo.com> <837d9w450e.fsf@gnu.org> <87czjow7x1.fsf@yahoo.com> <8335kk440x.fsf@gnu.org> <87sfsjvdnm.fsf@yahoo.com> <87leybv8mp.fsf@yahoo.com> <87h78zv1hc.fsf@yahoo.com> <83fsoj2e7m.fsf@gnu.org> <87v8xfuh2z.fsf@yahoo.com> <83bkz72dhh.fsf@gnu.org> <87pmnnuflf.fsf@yahoo.com> <837d9v2axs.fsf@gnu.org> <877d9vudxy.fsf@yahoo.com> <834k4y3o0h.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="21555"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Feb 17 01:50:15 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKUzv-0005Te-63 for ged-emacs-devel@m.gmane-mx.org; Thu, 17 Feb 2022 01:50:15 +0100 Original-Received: from localhost ([::1]:37610 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nKUzt-0002mw-QB for ged-emacs-devel@m.gmane-mx.org; Wed, 16 Feb 2022 19:50:13 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33576) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nKUvO-0001Ds-VG for emacs-devel@gnu.org; Wed, 16 Feb 2022 19:45:35 -0500 Original-Received: from sonic302-22.consmr.mail.ne1.yahoo.com ([66.163.186.148]:43472) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nKUvJ-0004KK-8j for emacs-devel@gnu.org; Wed, 16 Feb 2022 19:45:31 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1645058727; bh=Pv0/r9tW+eoTNwWTFfGnYK6TODpvGXoH6kJH7cgrqxU=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=t8/HezEOuoV+AOSqu6IPwRB9AgXFuIZi1uUn2M081h7KIWlA0sEI6qO/06C9eSU5WIyeSWxGtOk76xZ7glGUi0W9e5lOxxnUQTpoCSJZybcmBHX6zHyo4oOc4oX8uldbpzbr431pwJQYkiJ0DnwhTW+xyJoywTsDxUGJjk1l/ZICTfKBs5TlsY71gEYMMulmUuop4g5oz8CCCCDhQIR25xcKoINRCuQTKVqRqxYBAvPDkp8j0wZC+De6217QDxqiM8D/xmgeCo6g+XlY0Sqn8Vgaa47k1UPuwQWMVUMHg9hkZBDynkgqqejopMLTQE5QA5G+eCOz51NuDGeNpn1hyg== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1645058727; bh=8r1pEhG6bIhUiNPsiWPKR79817kNtm4NWZO6KeNR02p=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=bTrDOs5jXvfoMTuPNrfrkhsyZn2u9KW/gUmuwDcd0ZEtnVHuUL7pa9SOLrbxs8jbAMcr7++diE3Tfcwhwyuu1KBYoMQubBsN52dQ7An5oczMQlGCgoOS/GLQ9+XlOMmJBZo5rmr9u94Wy19ELBfN4/PlE6rjKmyTbyCoInAKN/bkMrK9bkJEH2LrYJ2TmVbBLerHM8xKp/U1uBCenLzhqzdmI6uOcduuDw/RKMZH0AjdZl8UShtycLDvBB/zNzMhFl04tSc/dmQDorQOdd4IkV/ubLjRidNbn7Ej68BZxG91ftUGNrZ+5kmjk8io4Ou+i9kkhcXayQgY9MbeNRD4nA== X-YMail-OSG: HPnyuI8VM1k4W_kHJ4qYpTH9u.VGBfZQwK3OayLWGU4mjxqm_l.ovCP5JYRN12d FokpbLTpcGr62iL9baIgKJTalt4Idzg_Yu2XEazmVDAAtYXRpf_dS7ZXhNrBbAT4DQdQXBhUmYZp 1MX0nuLIH9HU3RKRpc.oetXa0.n8NvmwMyxaWNFkzbio2aybt779SmMiwyrF9XJPAaFgw6x5GP5d vShv5KmkCPHnFZszC9AbnZWwraJOiVzQ_vmR3vZPz9JuICFd.k_yfup5us7oM_SfOnGL16AfC0Ad WfsrL7YzSGAB0HGo_3wRw1g9g6qke9YKoqTWidBaaYZPm59ku6odb86nKgyju8r6OcQrwYfTRn2j TSTTZ7wvmLpw7lwWhto1taTAznms36YbyVHsHMg7Iqp3P0wWB6TU7XyyGP9nuBtL2kq7rUHz1Mr0 bWOIg6ssRajkcR7BuOkzVjQeMGrieYQPezbRXwjSgVUhYLoAiDw_eEVh0nZ9LazoiZXNAF22ZB7z 5ssyxRYbJtjOEx_E9n68HXPNDZ9OoqpDZvuXk5TkQk7ofKL9WGOHwW9rIYRi9CO6p6XjU72K2CXx JljtJnXCVnDqfO5vCWcLueFL2Uo.hgAcTuatarnSrEb8QoJX.owG5EoNJrRc0sI6LmS_6iFuFrvr SHyaApNqnsfu8LdnUmeYYuVKYIqbjvzJaeT1mfvEyc418pdB6yECbtpTFT6B8QFmP6ou5DCrXnsV 9ipi6MMoJ3ZGVA1anYYXvGgqd5gauwgnnc6ZJAM1evEHENy73VdBUPIrqR_w6xXGCnPtX.qYYKKK SlziFrxAci3vNrJo.SHQu5LnRbnQFLDSo_m6otNZkD X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic302.consmr.mail.ne1.yahoo.com with HTTP; Thu, 17 Feb 2022 00:45:27 +0000 Original-Received: by kubenode504.mail-prod1.omega.sg3.yahoo.com (VZM Hermes SMTP Server) with ESMTPA ID 728182e415698a10680d035d5335079e; Thu, 17 Feb 2022 00:45:23 +0000 (UTC) In-Reply-To: <834k4y3o0h.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 16 Feb 2022 16:05:34 +0200") X-Mailer: WebService/1.1.19724 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.186.148; envelope-from=luangruo@yahoo.com; helo=sonic302-22.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:286408 Archived-At: Eli Zaretskii writes: > This isn't right, IMO. You should decode using Qraw_text in the > problematic case. Dropping the bytes on the floor is too radical, > certainly for the release branch. How about something like this? diff --git a/src/xterm.c b/src/xterm.c index b55a54b945..53d89240f1 100644 --- a/src/xterm.c +++ b/src/xterm.c @@ -8734,6 +8734,15 @@ handle_one_xevent (struct x_display_info *dpyinfo, { /* Decode the input data. */ +#ifdef HAVE_GLIB + /* If this isn't done in a build with GLib (usually + with GTK), then the resulting signal in + `setup_coding_system' will cause Emacs to + crash. */ + if (NILP (Fcoding_system_p (coding_system))) + coding_system = Qraw_text; +#endif + /* The input should be decoded with `coding_system' which depends on which X*LookupString function we used just above and the locale. */