From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu Newsgroups: gmane.emacs.devel Subject: Re: master 5df658a96a: Fix handling of intspecs as string by rcirc-define-command Date: Tue, 19 Apr 2022 19:27:32 +0800 Message-ID: <87sfq9e2jf.fsf@yahoo.com> References: <165036713452.19237.1130079565723437473@vcs2.savannah.gnu.org> <20220419111854.C50E3C009A8@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="10283"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.91 (gnu/linux) Cc: Philip Kaludercic To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Apr 19 13:28:33 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ngm24-0002QP-Df for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Apr 2022 13:28:32 +0200 Original-Received: from localhost ([::1]:33460 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ngm23-0003bn-DF for ged-emacs-devel@m.gmane-mx.org; Tue, 19 Apr 2022 07:28:31 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36162) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ngm1P-0002ut-E9 for emacs-devel@gnu.org; Tue, 19 Apr 2022 07:27:51 -0400 Original-Received: from sonic306-20.consmr.mail.ne1.yahoo.com ([66.163.189.82]:36432) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ngm1N-0004sB-3A for emacs-devel@gnu.org; Tue, 19 Apr 2022 07:27:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1650367665; bh=69DFi5l5VzGiP+IxZVdBx6egkWHdAHTcg9+yJgIfLIg=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From:Subject:Reply-To; b=WrmsqAP7WkPFh+Y/HtG/uF+5JISN5w7IlRVu+ja0iuY09Hh7A/aKBIBhtDL1WcJ5rUJUgA0c1JFvqeu2COL7VTx4satc7XdKvEggKJ6+nE3nt9a8vZGwTrLWYUW0nKGxpohG402ID7ConwI9uwMBxonslrZIuDOVMNFeM+eNaAodpnYNwatY0Ws1syWtPaYwizd6YYKHdkRYD2Fmyjut7Fq8YgwOAm7+j9kpF45dw6nOutLBWirkSFUzBFj3DqmI4ffJ1SSFJKUVHbhkxK1CpOG7xSqNuCeP+YwGSyFtjXby75dLWu2BD6Sd8OJ05iIawf3zKc+4TUio99Xuxm8/BA== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1650367665; bh=Z+r5W+nhufNgMB3QmOUd10mBJ0lEjQgWv9TxmEkUZYN=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=OFEGuf9oqNglRXb2+01pNwTHcx/KNDWyxK80JNXwrwjyLr0n4QpzoRHSnH1eXMCUuG8MQCdy3/fQm9jddJQOJJ51jSJehkfzIWudJBKGVoygpFJS+ZL4vd2HnYjZkIG4TTR/5gy/pSXkZHhFfKLGtqfOoa9v+JCv+JT6rzzwgAi3TALmK93vl5JQSShkbDJjWPkyj/SQErElUigmOgM+fIzDYcyusKi/MyXIcOpjIPt8ZSUDyB5z7zjwx1t+KYqWdX950jSoUJ+JqngI9twcvQw8pC8NVmLx/C3xCFpQ2dimL8QghHrvcp4kmllqY34hNoA5yki5tYdQWiv7Rvcmmg== X-YMail-OSG: Y7gyYpcVM1kHcSptRRvPLixCQ9RdicCdbzkKqCbQh.nI9Rr9f7y0DmKqpUXY8zx XRBtIvx4fbmKDKwTMODsz27vOZPigmoF5BG2iZgUsEMqzp.JsWZyR5yJSp10hXmKbPs0WWHishX8 mbdNU971LNXCcC6PyYjAzdW.0aUnhVzw05h14y8ERwWKAfynmsLgbK8v0U3Pg1TJFb4FmKye4TMa 3p5ElW9FKe7g72hXpVsFx8i.jsjqloNgij6aqNY3wcCtZ8R5waLTYJ1lodigZmjiwcMAXss.9PUz ic6rgi.qkeKVmxXF2kyLHjzMJNB5P6p9CJ1AwsXQA1M_133B1D3V1AMBCCcKISJ7GRzymFRx5TJd q0PW_UnzEIjb.gsXzrNarkTzxPUPJDewg_Mwp1wULhFyNAd.50WUvG6sIx7iWiAThgtRSf2_5mQF ccyeZ2YpJZwZWvVpEBFBf8aEEWCIIzGlL5ZUV5l1KVUcuIoVAhaWW2drSXTmCCnhts7pKZ61w9.E eSB411LMhgx8yPneHC1GaYJSSTGANvPncKq8TCsYRHkdtefFQjaDaYK4Jq39hT7UAd8Bu51_3oPI YizUO7sh.PKRYzpl1NunRBEkhBfgDH6Ogf9_7d2QQ3KWsPOaP5u7vmWDzXkFxe4vmwgIgMpUCSfz OEMgEPYXQZq8JMxIAoGBMkxDTIySu3L.6JlCjIlKEC6so4ZK_2aZ5_3yNwjFooT6dZyTLBfi0CNf OGItIMVMEGMUcQy2Oh8KDApwAUIEbniLjXzAfD_8gsJ8FdLJi6X.JrP.Wl_pjhGMNRR2lshf1rv8 29ExTJzpVgWAv8cxZs3RwsqdEBEkz8MmIcp8rUN_zu X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic306.consmr.mail.ne1.yahoo.com with HTTP; Tue, 19 Apr 2022 11:27:45 +0000 Original-Received: by hermes--canary-production-sg3-cfddc4f9d-jdsff (VZM Hermes SMTP Server) with ESMTPA ID ac8c3ee430d813b49f0a3d771a906916; Tue, 19 Apr 2022 11:27:39 +0000 (UTC) In-Reply-To: <20220419111854.C50E3C009A8@vcs2.savannah.gnu.org> (Philip Kaludercic's message of "Tue, 19 Apr 2022 07:18:54 -0400 (EDT)") X-Mailer: WebService/1.1.20048 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo Received-SPF: pass client-ip=66.163.189.82; envelope-from=luangruo@yahoo.com; helo=sonic306-20.consmr.mail.ne1.yahoo.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288661 Archived-At: Philip Kaludercic writes: > Fix handling of intspecs as string by rcirc-define-command > > * rcirc.el (rcirc-define-command): Check if an interactive > specification is a string, in which case it was to be wrapped in a > list so that the result of its interpretation is passed as the first > argument of the command resulting from the macro expansion. Shouldn't this commit message be: * lisp/net/rcirc.el (rcirc-define-command): Check if an interactive specification is a string, in which case it was to be wrapped in a list so that the result of its interpretation is passed as the first argument of the command resulting from the macro expansion. instead?