From: Lars Ingebrigtsen <larsi@gnus.org>
To: Toby Cubitt <toby-dated-1593024851.318b83@dr-qubit.org>
Cc: 41793@debbugs.gnu.org
Subject: bug#41793: `comment-only-p' erroneously flags blank lines as comments
Date: Mon, 09 May 2022 13:14:44 +0200 [thread overview]
Message-ID: <87sfpj7yaj.fsf@gnus.org> (raw)
In-Reply-To: <871re54mmc.fsf@gnus.org> (Lars Ingebrigtsen's message of "Thu, 28 Jan 2021 07:11:07 +0100")
Lars Ingebrigtsen <larsi@gnus.org> writes:
>> Gah. That attempt breaks flagging of comments separated by
>> whitespace-only lines. Maybe this?
>
> Do you have an example of when that fails?
The test was
;; foo
;;
;; bar
where comment-only-p would give the wrong results.
Anyway, I think it's ambiguous whether whitespace only should be a
comment or not. The current algo considers this to be one comment:
;; foo
;; bar
And I think that's correct. If we consider whitespace lines to not be
comments, this would change how our comment navigation commands work.
So there's some DWIM in this area, but I think how it currently works is
basically the way we want it to work, so I'm closing this bug report.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
next prev parent reply other threads:[~2022-05-09 11:14 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 17:53 bug#41793: `comment-only-p' erroneously flags blank lines as comments Toby Cubitt
2020-06-10 18:52 ` Toby Cubitt
2021-01-28 6:11 ` Lars Ingebrigtsen
2022-05-09 11:14 ` Lars Ingebrigtsen [this message]
2022-05-09 15:07 ` Drew Adams
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfpj7yaj.fsf@gnus.org \
--to=larsi@gnus.org \
--cc=41793@debbugs.gnu.org \
--cc=toby-dated-1593024851.318b83@dr-qubit.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.