all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* Re: master 2f68673a71: CC Mode: Restore string fence properties at each relevant external entry point
       [not found] ` <20220522170056.5E168C009A8@vcs2.savannah.gnu.org>
@ 2022-05-22 18:17   ` Lars Ingebrigtsen
  2022-05-22 19:26     ` Alan Mackenzie
  2022-05-24 16:41     ` Alan Mackenzie
  0 siblings, 2 replies; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-22 18:17 UTC (permalink / raw)
  To: emacs-devel; +Cc: Alan Mackenzie

Alan Mackenzie <acm@muc.de> writes:

>     CC Mode: Restore string fence properties at each relevant external entry point

I'm not sure whether it's this change or not, but this test broke
tonight:

2 unexpected results:
   FAILED  electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings
   FAILED  electric-pair-whitespace-chomping-2-at-point-4-in-c-mode-in-strings


-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master 2f68673a71: CC Mode: Restore string fence properties at each relevant external entry point
  2022-05-22 18:17   ` master 2f68673a71: CC Mode: Restore string fence properties at each relevant external entry point Lars Ingebrigtsen
@ 2022-05-22 19:26     ` Alan Mackenzie
  2022-05-24 16:41     ` Alan Mackenzie
  1 sibling, 0 replies; 5+ messages in thread
From: Alan Mackenzie @ 2022-05-22 19:26 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: emacs-devel

Hello, Lars.

On Sun, May 22, 2022 at 20:17:18 +0200, Lars Ingebrigtsen wrote:
> Alan Mackenzie <acm@muc.de> writes:

> >     CC Mode: Restore string fence properties at each relevant external entry point

> I'm not sure whether it's this change or not, ....

I'm afraid it is, definitely.

> ...., but this test broke tonight:

> 2 unexpected results:
>    FAILED  electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings
>    FAILED  electric-pair-whitespace-chomping-2-at-point-4-in-c-mode-in-strings

Yes.  The relevant functionality for these electric-pair test must take
place in a region of code WITHOUT these string fence properties applied.
This should be fairly simple to fix, but I probably won't be doing it
this evening.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master 2f68673a71: CC Mode: Restore string fence properties at each relevant external entry point
  2022-05-22 18:17   ` master 2f68673a71: CC Mode: Restore string fence properties at each relevant external entry point Lars Ingebrigtsen
  2022-05-22 19:26     ` Alan Mackenzie
@ 2022-05-24 16:41     ` Alan Mackenzie
  2022-05-24 16:50       ` Lars Ingebrigtsen
  1 sibling, 1 reply; 5+ messages in thread
From: Alan Mackenzie @ 2022-05-24 16:41 UTC (permalink / raw)
  To: Lars Ingebrigtsen; +Cc: emacs-devel

Hello, Lars.

On Sun, May 22, 2022 at 20:17:18 +0200, Lars Ingebrigtsen wrote:
> Alan Mackenzie <acm@muc.de> writes:

> >     CC Mode: Restore string fence properties at each relevant external entry point

> I'm not sure whether it's this change or not, but this test broke
> tonight:

> 2 unexpected results:
>    FAILED  electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings
>    FAILED  electric-pair-whitespace-chomping-2-at-point-4-in-c-mode-in-strings

This should be fixed, now.

> -- 
> (domestic pets only, the antidote for overdose, milk.)
>    bloggy blog: http://lars.ingebrigtsen.no

-- 
Alan Mackenzie (Nuremberg, Germany).



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master 2f68673a71: CC Mode: Restore string fence properties at each relevant external entry point
  2022-05-24 16:41     ` Alan Mackenzie
@ 2022-05-24 16:50       ` Lars Ingebrigtsen
  2022-05-24 16:51         ` Lars Ingebrigtsen
  0 siblings, 1 reply; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-24 16:50 UTC (permalink / raw)
  To: Alan Mackenzie; +Cc: emacs-devel

Alan Mackenzie <acm@muc.de> writes:

>> 2 unexpected results:
>>    FAILED  electric-pair-whitespace-chomping-2-at-point-4-in-c++-mode-in-strings
>>    FAILED  electric-pair-whitespace-chomping-2-at-point-4-in-c-mode-in-strings
>
> This should be fixed, now.

"make check" seems to infloop now?  Hm; I'll try to do a bootstrap...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: master 2f68673a71: CC Mode: Restore string fence properties at each relevant external entry point
  2022-05-24 16:50       ` Lars Ingebrigtsen
@ 2022-05-24 16:51         ` Lars Ingebrigtsen
  0 siblings, 0 replies; 5+ messages in thread
From: Lars Ingebrigtsen @ 2022-05-24 16:51 UTC (permalink / raw)
  To: Alan Mackenzie; +Cc: emacs-devel

Lars Ingebrigtsen <larsi@gnus.org> writes:

> "make check" seems to infloop now?  Hm; I'll try to do a bootstrap...

Sorry; false alarm -- it was just something here that took unexpectedly
long, but it's probably unrelated to these changes.

I can confirm that the test failure here is gone; thanks.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no



^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2022-05-24 16:51 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <165323885598.20616.17995667057596262189@vcs2.savannah.gnu.org>
     [not found] ` <20220522170056.5E168C009A8@vcs2.savannah.gnu.org>
2022-05-22 18:17   ` master 2f68673a71: CC Mode: Restore string fence properties at each relevant external entry point Lars Ingebrigtsen
2022-05-22 19:26     ` Alan Mackenzie
2022-05-24 16:41     ` Alan Mackenzie
2022-05-24 16:50       ` Lars Ingebrigtsen
2022-05-24 16:51         ` Lars Ingebrigtsen

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.