From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "J.P." Newsgroups: gmane.emacs.bugs Subject: bug#56340: Change erc dependencies Date: Mon, 04 Jul 2022 23:39:07 -0700 Message-ID: <87sfng83n8.fsf_-___1125.08073668636$1657003262$gmane$org@neverwas.me> References: <87fsjk6eml.fsf@dick> <87o7y71yr1.fsf@gnus.org> <87czekcuxj.fsf@neverwas.me> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18484"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: Lars Ingebrigtsen , 56340@debbugs.gnu.org, Amin Bandali , emacs-erc@gnu.org To: dick.r.chiang@gmail.com Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Tue Jul 05 08:40:54 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1o8cEw-0004Xy-7R for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jul 2022 08:40:54 +0200 Original-Received: from localhost ([::1]:33226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1o8cEv-0000lm-3x for geb-bug-gnu-emacs@m.gmane-mx.org; Tue, 05 Jul 2022 02:40:53 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:44192) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1o8cE6-0000Uj-Oa for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 02:40:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55245) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1o8cE6-0003nX-G1 for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 02:40:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1o8cE6-0002FW-7w for bug-gnu-emacs@gnu.org; Tue, 05 Jul 2022 02:40:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "J.P." Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 05 Jul 2022 06:40:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 56340 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 56340-submit@debbugs.gnu.org id=B56340.16570031658592 (code B ref 56340); Tue, 05 Jul 2022 06:40:02 +0000 Original-Received: (at 56340) by debbugs.gnu.org; 5 Jul 2022 06:39:25 +0000 Original-Received: from localhost ([127.0.0.1]:49142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8cDU-0002EW-Np for submit@debbugs.gnu.org; Tue, 05 Jul 2022 02:39:25 -0400 Original-Received: from mail-108-mta233.mxroute.com ([136.175.108.233]:43705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1o8cDR-0002EH-Um for 56340@debbugs.gnu.org; Tue, 05 Jul 2022 02:39:23 -0400 Original-Received: from filter006.mxroute.com ([140.82.40.27] filter006.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta233.mxroute.com (ZoneMTA) with ESMTPSA id 181cd15919b000a238.001 for <56340@debbugs.gnu.org> (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Tue, 05 Jul 2022 06:39:11 +0000 X-Zone-Loop: cd3e409febca5205d0718e88e75f4922af865ab11363 X-Originating-IP: [140.82.40.27] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=neverwas.me ; s=x; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID: In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=QGPI5HEvnpr+okVM8kN9ShKL2yaPCfNJfXKktoJ+ZTM=; b=CmlpeNpekAm2q0BZGrw8f2WaxX MQo80GDgu37hc47dPfst4eh3Lp2NsBWl38GVik278n3QouWlQZzAQYI94vGtqxLeK25ZhwRA4D5Aj njnKegzan7e+C9TRGXE8L055PPCwH7paWduTNlcrym9h3OtN2ZMS5Q7mFx4SVfWqPkhgWS450PE8G fsp9EdHgiy8rjw8P2F/v/HOOSp/W1fATGHMpunrzZ0CzjOpM1naivTXOSSChQqT2O7QstV1vEDB8n mmo+xfM9Ma7iwbCNin6fvc1zrtR1TSI7+7JixycJq2lCUvxRMNNxniLR27FuJcn2R47wfd2u7VV0c Y0hwFovA==; In-Reply-To: <87czekcuxj.fsf@neverwas.me> (J. P.'s message of "Mon, 04 Jul 2022 16:36:08 -0700") X-AuthUser: masked@neverwas.me X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:236085 Archived-At: "J.P." writes: >> +(declare-function erc-nickname-in-use "erc") >> (define-erc-response-handler (433) >> - "Login-time \"nick in use\"." nil >> - (erc-nickname-in-use (cadr (erc-response.command-args parsed)) >> - "already in use")) >> + "Login-time \"nick in use\"." nil >> + (erc-nickname-in-use (cadr (erc-response.c= ommand-args parsed)) >> + "already in use")) > > Indentation thing aside, I wasn't aware we were allowed to forgo > including signatures in these `declare-function' forms. But if that's > the deal, I guess it makes for a cleaner, less cluttered look overall. > > [...] > > Which gets me wondering (not for the first time): all these > `defvar's and `declare-function's seem a bit litter-prone, no? Not sure > if any diagnostic tooling already catches extraneous ones orphaned by > refactoring, but I for one could use such a feature. Hmm, now I'm thinking there's likely some benefit to always including a lambda list in these `declare-function's because it seems 1. byte compiling only warns of a mismatch between the call site and the declaration but doesn't actually validate the latter 2. check-declare makes up for that by emitting an "arglist mismatch" when necessary, which diagnostic tools, like flymake, can pick up on Not saying you need to comply, but someone should probably at least append a (t t) to the following declarations because, at present, with your patch applied, running `check-declare-directory' on lisp/erc gives: lisp/erc/erc-networks.el:1099:Warning (check-declare): said =E2=80=98erc--target-channel-local-p=E2=80=99 was defined in lisp/erc= /erc.el: function not found lisp/erc/erc-networks.el:1100:Warning (check-declare): said =E2=80=98erc--target-symbol=E2=80=99 was defined in lisp/erc/erc.el: function not found lisp/erc/erc-networks.el:1101:Warning (check-declare): said =E2=80=98erc--target-string=E2=80=99 was defined in lisp/erc/erc.el: function not found lisp/erc/erc-goodies.el:201:Warning (check-declare): said =E2=80=98erc-input-string=E2=80=99 was defined in lisp/erc/erc.el: fu= nction not found lisp/erc/erc-goodies.el:356:Warning (check-declare): said =E2=80=98erc-lo= g=E2=80=99 was defined in lisp/erc/erc.el: function not found lisp/erc/erc-backend.el:613:Warning (check-declare): said =E2=80=98erc-networks--id-given=E2=80=99 was defined in lisp/erc/erc.= el: function not found lisp/erc/erc-backend.el:647:Warning (check-declare): said =E2=80=98erc-lo= g=E2=80=99 was defined in lisp/erc/erc.el: function not found lisp/erc/erc-backend.el:1705:Warning (check-declare): said =E2=80=98erc-get-channel-user=E2=80=99 was defined in lisp/erc/erc.el: function not found Perhaps the definitions of these irregulars should all eventually be moved to erc-backend.el, as you did with `erc-input'. In the meantime, I'm going to extract the non-forward-declaration hunks from your patch into a standalone commit (attributed to you, unless you object relatively soonish) and install that along with some other, unrelated fixes. That way, we can let the rest steep until others weigh in or at least until there's some clear indication of your willingness to iterate further on this bug thread (apart from related activity on your fork). Thanks.