wrong type argument with latest org and latest emacs

wrong type argument with latest org and latest emacs

[Colin Baxter]

I'm sending this to emacs.orgmode and emacs.devel lists.

With the latest emacs:

(1) emacs -q <RET>
(2) M-x org-version <RET>
    --> Org mode version 9.5.4 (release_9.5.4-3-g6dc785
(4) C-x C-c --> emacs closes with no messages

(5) Repeat (1)
(6) In scratch buffer load latest org-mode by eval
   (add-to-list 'load-path (expand-file-name "/path/to/git/org-mode/lisp"))
(7) M-x org-version <RET>
    --> Org mode version 9.5.4 (release_9.5.4-608-g080462
(8) C-x C-c --> emacs closes with error message
    --> Wrong type argument: stringp, (wrong-type-argument stringp nil)

Debugging further reveals:

Debugger entered--Lisp error: (wrong-type-argument stringp (wrong-type-argument stringp nil))
  format-message((wrong-type-argument stringp nil))
  apply(format-message (wrong-type-argument stringp nil))
  error((wrong-type-argument stringp nil))
  #f(compiled-function (fun) #<bytecode -0x1724f6e>)(org-babel-remove-temporary-stable-directory)
  run-hook-wrapped(#f(compiled-function (fun) #<bytecode -0x1724f6e>) org-babel-remove-temporary-stable-directory)
  run-hook-query-error-with-timeout(kill-emacs-hook)
  kill-emacs(nil nil)
  save-buffers-kill-emacs(nil)
  save-buffers-kill-terminal(nil)
  funcall-interactively(save-buffers-kill-terminal nil)
  call-interactively(save-buffers-kill-terminal nil nil)
  command-execute(save-buffers-kill-terminal)


Best wishes,

Re: wrong type argument with latest org and latest emacs

[Ihor Radchenko]

[-- Attachment #1: Type: text/plain, Size: 837 bytes --]

Colin Baxter <m43cap@yandex.com> writes:

> I'm sending this to emacs.orgmode and emacs.devel lists.
>
> With the latest emacs:
>
>
> Debugger entered--Lisp error: (wrong-type-argument stringp (wrong-type-argument stringp nil))
>   format-message((wrong-type-argument stringp nil))
>   apply(format-message (wrong-type-argument stringp nil))
>   error((wrong-type-argument stringp nil))
>   #f(compiled-function (fun) #<bytecode -0x1724f6e>)(org-babel-remove-temporary-stable-directory)
>   run-hook-wrapped(#f(compiled-function (fun) #<bytecode -0x1724f6e>) org-babel-remove-temporary-stable-directory)

Thanks for reporting!
This likely caused by recent commit of mine on systems with no write
access to remote directory (at least, I am unable to reproduce the steps
on my system).

Can you please try the attached patch?

Best,
Ihor


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-ob-core-Fix-nil-value-of-org-babel-temporary-stable-.patch --]
[-- Type: text/x-patch, Size: 1203 bytes --]

From ddf6278e8fcbaa4939539277b111061b7c00f550 Mon Sep 17 00:00:00 2001
Message-Id: <ddf6278e8fcbaa4939539277b111061b7c00f550.1657026153.git.yantar92@gmail.com>
From: Ihor Radchenko <yantar92@gmail.com>
Date: Tue, 5 Jul 2022 21:00:24 +0800
Subject: [PATCH] ob-core: Fix nil value of
 `org-babel-temporary-stable-directory'

* lisp/ob-core.el: Fallback the value of
`org-babel-temporary-stable-directory' to
`org-babel-temporary-directory' if there are issues with directory
creation.

Fixes https://yhetil.org/emacs-devel/87sfnfhm6v.fsf@yandex.com
---
 lisp/ob-core.el | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/lisp/ob-core.el b/lisp/ob-core.el
index 6c379c121..aaf895d74 100644
--- a/lisp/ob-core.el
+++ b/lisp/ob-core.el
@@ -3167,7 +3167,8 @@   (defvar org-babel-temporary-stable-directory
 	     (expand-file-name
               "babel-stable"
               (temporary-file-directory)))
-          (t nil)))
+          ;; Fallback if things do not work.
+          (t org-babel-temporary-directory)))
     "Directory to hold temporary files created to execute code blocks.
 Used by `org-babel-temp-file'.  This directory will be removed on
 Emacs shutdown."))
-- 
2.35.1

Re: wrong type argument with latest org and latest emacs

[Colin Baxter]

>>>>> Ihor Radchenko <yantar92@gmail.com> writes:

    > Colin Baxter <m43cap@yandex.com> writes:
    >> I'm sending this to emacs.orgmode and emacs.devel lists.
    >> 
    >> With the latest emacs:
    >> 
    >> 
    >> Debugger entered--Lisp error: (wrong-type-argument stringp
    >> (wrong-type-argument stringp nil))
    >> format-message((wrong-type-argument stringp nil))
    >> apply(format-message (wrong-type-argument stringp nil))
    >> error((wrong-type-argument stringp nil)) #f(compiled-function
    >> (fun) #<bytecode
    -0x1724f6e> )(org-babel-remove-temporary-stable-directory)
    >> run-hook-wrapped(#f(compiled-function (fun) #<bytecode
    -0x1724f6e> ) org-babel-remove-temporary-stable-directory)

    > Thanks for reporting!  This likely caused by recent commit of mine
    > on systems with no write access to remote directory (at least, I
    > am unable to reproduce the steps on my system).

    > Can you please try the attached patch?

    > Best, Ihor

    > From ddf6278e8fcbaa4939539277b111061b7c00f550 Mon Sep 17 00:00:00
    > 2001 Message-Id:
    > <ddf6278e8fcbaa4939539277b111061b7c00f550.1657026153.git.yantar92@gmail.com>
    > From: Ihor Radchenko <yantar92@gmail.com> Date: Tue, 5 Jul 2022
    > 21:00:24 +0800 Subject: [PATCH] ob-core: Fix nil value of
    > `org-babel-temporary-stable-directory'

    > * lisp/ob-core.el: Fallback the value of
    > `org-babel-temporary-stable-directory' to
    > `org-babel-temporary-directory' if there are issues with directory
    > creation.

    > Fixes https://yhetil.org/emacs-devel/87sfnfhm6v.fsf@yandex.com ---
    > lisp/ob-core.el | 3 ++- 1 file changed, 2 insertions(+), 1
    > deletion(-)

    > diff --git a/lisp/ob-core.el b/lisp/ob-core.el index
    > 6c379c121..aaf895d74 100644 --- a/lisp/ob-core.el +++
    > b/lisp/ob-core.el @@ -3167,7 +3167,8 @@ (defvar
    > org-babel-temporary-stable-directory (expand-file-name
    > "babel-stable" (temporary-file-directory))) - (t nil))) + ;;
    > Fallback if things do not work.  + (t
    > org-babel-temporary-directory))) "Directory to hold temporary
    > files created to execute code blocks.  Used by
    > `org-babel-temp-file'.  This directory will be removed on Emacs
    > shutdown."))  -- 2.35.1

Ok, that patch seems to solve the issue. I have applied the patch and I
now get now error message when I close down emacs-29.0.50.

Thank you.

Best wishes,

Re: wrong type argument with latest org and latest emacs

[Colin Baxter]

>>>>> Colin Baxter <m43cap@yandex.com> writes:

>>>>> Ihor Radchenko <yantar92@gmail.com> writes:
    >> Colin Baxter <m43cap@yandex.com> writes:
    >>> I'm sending this to emacs.orgmode and emacs.devel lists.
    >>> 
    >>> With the latest emacs:
    >>> 
    >>> 
    >>> Debugger entered--Lisp error: (wrong-type-argument stringp
    >>> (wrong-type-argument stringp nil))
    >>> format-message((wrong-type-argument stringp nil))
    >>> apply(format-message (wrong-type-argument stringp nil))
    >>> error((wrong-type-argument stringp nil)) #f(compiled-function
    >>> (fun) #<bytecode
    -0x1724f6e> )(org-babel-remove-temporary-stable-directory)
    >>> run-hook-wrapped(#f(compiled-function (fun) #<bytecode
    -0x1724f6e> ) org-babel-remove-temporary-stable-directory)

    >> Thanks for reporting!  This likely caused by recent commit of
    >> mine on systems with no write access to remote directory (at
    >> least, I am unable to reproduce the steps on my system).

    >> Can you please try the attached patch?

    >> Best, Ihor

    >> From ddf6278e8fcbaa4939539277b111061b7c00f550 Mon Sep 17 00:00:00
    >> 2001 Message-Id:
    >> <ddf6278e8fcbaa4939539277b111061b7c00f550.1657026153.git.yantar92@gmail.com>
    >> From: Ihor Radchenko <yantar92@gmail.com> Date: Tue, 5 Jul 2022
    >> 21:00:24 +0800 Subject: [PATCH] ob-core: Fix nil value of
    >> `org-babel-temporary-stable-directory'

    >> * lisp/ob-core.el: Fallback the value of
    >> `org-babel-temporary-stable-directory' to
    >> `org-babel-temporary-directory' if there are issues with
    >> directory creation.

    >> Fixes https://yhetil.org/emacs-devel/87sfnfhm6v.fsf@yandex.com
    >> --- lisp/ob-core.el | 3 ++- 1 file changed, 2 insertions(+), 1
    >> deletion(-)

    >> diff --git a/lisp/ob-core.el b/lisp/ob-core.el index
    >> 6c379c121..aaf895d74 100644 --- a/lisp/ob-core.el +++
    >> b/lisp/ob-core.el @@ -3167,7 +3167,8 @@ (defvar
    >> org-babel-temporary-stable-directory (expand-file-name
    >> "babel-stable" (temporary-file-directory))) - (t nil))) + ;;
    >> Fallback if things do not work.  + (t
    >> org-babel-temporary-directory))) "Directory to hold temporary
    >> files created to execute code blocks.  Used by
    >> `org-babel-temp-file'.  This directory will be removed on Emacs
    >> shutdown."))  -- 2.35.1

    > Ok, that patch seems to solve the issue. I have applied the patch
    > and I now get now error message when I close down emacs-29.0.50.

Typo! That's no error, not now error.

Best wishes,

Re: wrong type argument with latest org and [not] latest emacs

[Alain.Cochard]

Colin Baxter writes on Tue  5 Jul 2022 20:24:
 > >>>>> Colin Baxter <m43cap@yandex.com> writes:
 > 
 > >>>>> Ihor Radchenko <yantar92@gmail.com> writes:
 >     >> Colin Baxter <m43cap@yandex.com> writes:
 >     >>> I'm sending this to emacs.orgmode and emacs.devel lists.
 >     >>> 
 >     >>> With the latest emacs:
 >     >>> 
 >     >>> 
 >     >>> Debugger entered--Lisp error: (wrong-type-argument stringp
 >     >>> (wrong-type-argument stringp nil))
 >     >>> format-message((wrong-type-argument stringp nil))
 >     >>> apply(format-message (wrong-type-argument stringp nil))
 >     >>> error((wrong-type-argument stringp nil)) #f(compiled-function
 >     >>> (fun) #<bytecode
 >     -0x1724f6e> )(org-babel-remove-temporary-stable-directory)
 >     >>> run-hook-wrapped(#f(compiled-function (fun) #<bytecode
 >     -0x1724f6e> ) org-babel-remove-temporary-stable-directory)
 > 
 >     >> Thanks for reporting!  This likely caused by recent commit of
 >     >> mine on systems with no write access to remote directory (at
 >     >> least, I am unable to reproduce the steps on my system).
 > 
 >     >> Can you please try the attached patch?
 > 
 >     >> Best, Ihor
 > 
 >     >> From ddf6278e8fcbaa4939539277b111061b7c00f550 Mon Sep 17 00:00:00
 >     >> 2001 Message-Id:
 >     >> <ddf6278e8fcbaa4939539277b111061b7c00f550.1657026153.git.yantar92@gmail.com>
 >     >> From: Ihor Radchenko <yantar92@gmail.com> Date: Tue, 5 Jul 2022
 >     >> 21:00:24 +0800 Subject: [PATCH] ob-core: Fix nil value of
 >     >> `org-babel-temporary-stable-directory'
 > 
 >     >> * lisp/ob-core.el: Fallback the value of
 >     >> `org-babel-temporary-stable-directory' to
 >     >> `org-babel-temporary-directory' if there are issues with
 >     >> directory creation.
 > 
 >     >> Fixes https://yhetil.org/emacs-devel/87sfnfhm6v.fsf@yandex.com
 >     >> --- lisp/ob-core.el | 3 ++- 1 file changed, 2 insertions(+), 1
 >     >> deletion(-)
 > 
 >     >> diff --git a/lisp/ob-core.el b/lisp/ob-core.el index
 >     >> 6c379c121..aaf895d74 100644 --- a/lisp/ob-core.el +++
 >     >> b/lisp/ob-core.el @@ -3167,7 +3167,8 @@ (defvar
 >     >> org-babel-temporary-stable-directory (expand-file-name
 >     >> "babel-stable" (temporary-file-directory))) - (t nil))) + ;;
 >     >> Fallback if things do not work.  + (t
 >     >> org-babel-temporary-directory))) "Directory to hold temporary
 >     >> files created to execute code blocks.  Used by
 >     >> `org-babel-temp-file'.  This directory will be removed on Emacs
 >     >> shutdown."))  -- 2.35.1
 > 
 >     > Ok, that patch seems to solve the issue. I have applied the patch
 >     > and I now get now error message when I close down emacs-29.0.50.
 > 
 > Typo! That's no error, not now error.

So it is not the latest emacs

  GNU Emacs 27.2 (build 1, x86_64-redhat-linux-gnu, GTK+ Version
  3.24.30, cairo version 1.17.4) of 2021-08-07

but it seems related. I have no problem with 

  Org mode version 9.5.4 (9.5.4-ge0b05b @
  /home/cochard/.emacs.d/elpa/org-9.5.4/)

but if I use what I believe to be the latest org from git (pulled a
few minutes ago):

  Org mode version 9.5.4 (release_9.5.4-609-g713598 @
  /home/cochard/Org/Coch-git/org-mode/lisp/)

upon 'C-x C-c', I get

  org-babel-remove-temporary-stable-directory: Wrong type argument:
  stringp, nil

and emacs does not even close.  I cannot kill it either with 'C-c' on
the terminal from which I started emacs.  I have to 'kill -9
<emacs_PID>'


-- 
EOST (École et Observatoire des Sciences de la Terre) 
ITE (Institut Terre & Environnement) | alain.cochard@unistra.fr
5 rue René Descartes   [bureau 106]  | Phone: +33 (0)3 68 85 50 44 
F-67084 Strasbourg Cedex, France     | [ slot available for rent ]

Re: wrong type argument with latest org and [not] latest emacs

[Colin Baxter]

>>>>> Alain Cochard <Alain.Cochard@unistra.fr> writes:

    > Colin Baxter writes on Tue 5 Jul 2022 20:24:
    >> >>>>> Colin Baxter <m43cap@yandex.com> writes:
    >> 
    >> >>>>> Ihor Radchenko <yantar92@gmail.com> writes: >> Colin Baxter
    >> <m43cap@yandex.com> writes: >>> I'm sending this to emacs.orgmode
    >> and emacs.devel lists.
    >> >>> 
    >> >>> With the latest emacs:
    >> >>> 
    >> >>> 
    >> >>> Debugger entered--Lisp error: (wrong-type-argument stringp
    >> >>> (wrong-type-argument stringp nil)) >>>
    >> format-message((wrong-type-argument stringp nil)) >>>
    >> apply(format-message (wrong-type-argument stringp nil)) >>>
    >> error((wrong-type-argument stringp nil)) #f(compiled-function >>>
    >> (fun) #<bytecode
    -0x1724f6e> )(org-babel-remove-temporary-stable-directory)
    >> >>> run-hook-wrapped(#f(compiled-function (fun) #<bytecode
    -0x1724f6e> ) org-babel-remove-temporary-stable-directory)
    >> 
    >> >> Thanks for reporting!  This likely caused by recent commit of
    >> >> mine on systems with no write access to remote directory (at
    >> >> least, I am unable to reproduce the steps on my system).
    >> 
    >> >> Can you please try the attached patch?
    >> 
    >> >> Best, Ihor
    >> 
    >> >> From ddf6278e8fcbaa4939539277b111061b7c00f550 Mon Sep 17
    >> 00:00:00 >> 2001 Message-Id: >>
    >> <ddf6278e8fcbaa4939539277b111061b7c00f550.1657026153.git.yantar92@gmail.com>
    >> >> From: Ihor Radchenko <yantar92@gmail.com> Date: Tue, 5 Jul
    >> 2022 >> 21:00:24 +0800 Subject: [PATCH] ob-core: Fix nil value of
    >> >> `org-babel-temporary-stable-directory'
    >> 
    >> >> * lisp/ob-core.el: Fallback the value of >>
    >> `org-babel-temporary-stable-directory' to >>
    >> `org-babel-temporary-directory' if there are issues with >>
    >> directory creation.
    >> 
    >> >> Fixes https://yhetil.org/emacs-devel/87sfnfhm6v.fsf@yandex.com
    >> >> --- lisp/ob-core.el | 3 ++- 1 file changed, 2 insertions(+), 1
    >> >> deletion(-)
    >> 
    >> >> diff --git a/lisp/ob-core.el b/lisp/ob-core.el index >>
    >> 6c379c121..aaf895d74 100644 --- a/lisp/ob-core.el +++ >>
    >> b/lisp/ob-core.el @@ -3167,7 +3167,8 @@ (defvar >>
    >> org-babel-temporary-stable-directory (expand-file-name >>
    >> "babel-stable" (temporary-file-directory))) - (t nil))) + ;; >>
    >> Fallback if things do not work.  + (t >>
    >> org-babel-temporary-directory))) "Directory to hold temporary >>
    >> files created to execute code blocks.  Used by >>
    >> `org-babel-temp-file'.  This directory will be removed on Emacs
    >> >> shutdown."))  -- 2.35.1
    >> 
    >> > Ok, that patch seems to solve the issue. I have applied the
    >> patch > and I now get now error message when I close down
    >> emacs-29.0.50.
    >> 
    >> Typo! That's no error, not now error.

    > So it is not the latest emacs

    >   GNU Emacs 27.2 (build 1, x86_64-redhat-linux-gnu, GTK+ Version
    > 3.24.30, cairo version 1.17.4) of 2021-08-07

    > but it seems related. I have no problem with

    >   Org mode version 9.5.4 (9.5.4-ge0b05b @
    > /home/cochard/.emacs.d/elpa/org-9.5.4/)

    > but if I use what I believe to be the latest org from git (pulled
    > a few minutes ago):

    >   Org mode version 9.5.4 (release_9.5.4-609-g713598 @
    > /home/cochard/Org/Coch-git/org-mode/lisp/)

    > upon 'C-x C-c', I get

    >   org-babel-remove-temporary-stable-directory: Wrong type
    > argument: stringp, nil

    > and emacs does not even close.  I cannot kill it either with 'C-c'
    > on the terminal from which I started emacs.  I have to 'kill -9
    > <emacs_PID>'


It should work with org-mode release_9.5.4-610-gbdf7af.

Best wishes,

Colin Baxter.

Re: wrong type argument with latest org and [not] latest emacs

[Alain.Cochard]

Colin Baxter writes on Thu  7 Jul 2022 13:22:

 >     > So it is not the latest emacs
 > 
 >     >   GNU Emacs 27.2 (build 1, x86_64-redhat-linux-gnu, GTK+ Version
 >     > 3.24.30, cairo version 1.17.4) of 2021-08-07
 > 
 >     > but it seems related. I have no problem with
 > 
 >     >   Org mode version 9.5.4 (9.5.4-ge0b05b @
 >     > /home/cochard/.emacs.d/elpa/org-9.5.4/)
 > 
 >     > but if I use what I believe to be the latest org from git (pulled
 >     > a few minutes ago):
 > 
 >     >   Org mode version 9.5.4 (release_9.5.4-609-g713598 @
 >     > /home/cochard/Org/Coch-git/org-mode/lisp/)
 > 
 >     > upon 'C-x C-c', I get
 > 
 >     >   org-babel-remove-temporary-stable-directory: Wrong type
 >     > argument: stringp, nil
 > 
 >     > and emacs does not even close.  I cannot kill it either with 'C-c'
 >     > on the terminal from which I started emacs.  I have to 'kill -9
 >     > <emacs_PID>'
 > 
 > 
 > It should work with org-mode release_9.5.4-610-gbdf7af.

Yes it does (just tested with 613-gb3b17c ).  Thank you.

-- 
EOST (École et Observatoire des Sciences de la Terre) 
ITE (Institut Terre & Environnement) | alain.cochard@unistra.fr
5 rue René Descartes   [bureau 106]  | Phone: +33 (0)3 68 85 50 44 
F-67084 Strasbourg Cedex, France     | [ slot available for rent ]

Re: wrong type argument with latest org and [not] latest emacs

[Colin Baxter]

Excellent!

Best wishes,

Re: wrong type argument with latest org and latest emacs

[Ihor Radchenko]

Colin Baxter <m43cap@yandex.com> writes:

> Ok, that patch seems to solve the issue. I have applied the patch and I
> now get now error message when I close down emacs-29.0.50.

Thanks for testing!
Fixed on main via e4438fe3c.
I applied a different patch that solves the problem properly.
I have managed to reproduce the error using Emacs 29. The problem was
partially related to `make-directory' return value and partially related
to failed `make-directory' calls.

Best,
Ihor