From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#55039: [PATCH] Use VC-relative file names in ChangeLog entries Date: Thu, 08 Sep 2022 08:45:47 +0000 Message-ID: <87sfl26ypw.fsf@posteo.net> References: <8735i7zvk4.fsf@posteo.net> <83v8v3sq0n.fsf@gnu.org> <87czc8u56q.fsf@gnus.org> <871qsooenn.fsf@posteo.net> <87o7vsfu5p.fsf@posteo.net> <83y1uwijzt.fsf@gnu.org> <87bkrsdzzm.fsf@posteo.net> <83mtbafip7.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28439"; mail-complaints-to="usenet@ciao.gmane.io" Cc: larsi@gnus.org, 55039@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Sep 08 10:47:19 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oWDBu-0007AA-G4 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Sep 2022 10:47:18 +0200 Original-Received: from localhost ([::1]:43428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oWDBt-0000Nz-Jo for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 08 Sep 2022 04:47:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:51766) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oWDBe-0000NL-Kc for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 04:47:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:40280) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oWDBe-0003o7-8o for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 04:47:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oWDBe-0006rX-53 for bug-gnu-emacs@gnu.org; Thu, 08 Sep 2022 04:47:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 08 Sep 2022 08:47:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55039 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo patch Original-Received: via spool by 55039-submit@debbugs.gnu.org id=B55039.166262676826315 (code B ref 55039); Thu, 08 Sep 2022 08:47:02 +0000 Original-Received: (at 55039) by debbugs.gnu.org; 8 Sep 2022 08:46:08 +0000 Original-Received: from localhost ([127.0.0.1]:57212 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWDAl-0006qM-RG for submit@debbugs.gnu.org; Thu, 08 Sep 2022 04:46:08 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]:44871) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oWDAk-0006pe-Lm for 55039@debbugs.gnu.org; Thu, 08 Sep 2022 04:46:07 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id BEDB1240027 for <55039@debbugs.gnu.org>; Thu, 8 Sep 2022 10:45:58 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1662626760; bh=X7PmFRbh37s0haYOuoQGYeBb7TZJZSG+IhULBGZOiFI=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=r3kwn2DKxaQytPTFduZEfGg6aWFLjJY7i8EePqehb6lnqSr6ifekHRfz0425LuWtV 8nPJ5JsQS/wosj0UaH/s1axODoy+ClwHHZiNA44RduUmGC+m4F3W1CotbPoVv4u/pj mu8rCc6yYmzaDJEpVuPOswhDkMdxdgU3PYhLum5CSbcgzdDORUufv4pz6KNg3Joyw7 T2jA1bAxoAMEC5/BIFK9uk5Y8iwHAtOrqu1HStOENqh9TE79pGyyzvd+0KWYLXoomM QYJlHBAnPw8YFdJSOegE3zvk4OmDhmQ9sdgr+h1FYs8g5g6M/I38rGeP3N2E/rXRZK Q1nQAt6Pjwrgg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MNXlT4dM8z9rxL; Thu, 8 Sep 2022 10:45:56 +0200 (CEST) In-Reply-To: <83mtbafip7.fsf@gnu.org> (Eli Zaretskii's message of "Thu, 08 Sep 2022 10:07:00 +0300") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:241847 Archived-At: Eli Zaretskii writes: >> From: Philip Kaludercic >> Cc: larsi@gnus.org, 55039@debbugs.gnu.org >> Date: Tue, 06 Sep 2022 20:11:57 +0000 >> >> >> Also, as the entire point of >> >> the patch was that emacs.git is using relative path names, should a >> >> .dir-locals.el variable be set to ensure this is done? >> > >> > I guess so, yes. But what would happen to people who use Emacs >> > versions before 29? >> >> It should have no effect. > > Unfortunately, this is not true, at least not the way this was > implemented in our .dir-locals.el. Now, whenever I visit _any_ file > in the repository, I get this warning pop up: > > The local variables list in d:/gnu/git/emacs/trunk/ > contains values that may not be safe (*). > > Do you want to apply it? You can type > y -- to apply the local variables list. > n -- to ignore the local variables list. > ! -- to apply the local variables list, and permanently mark these > values (*) as safe (in the future, they will be set automatically.) > i -- to ignore the local variables list, and permanently mark these > values (*) as ignored > > tab-width : 8 > sentence-end-double-space : t > fill-column : 70 > emacs-lisp-docstring-fill-column : 65 > bug-reference-url-format : "https://debbugs.gnu.org/%s" > * diff-add-log-use-relative-names : t > indent-tabs-mode : nil > electric-quote-comment : nil > electric-quote-string : nil > mode : bug-reference-prog > > and I _must_ type a response. If I answer !, Emacs will write to my > init file, which I'm not sure I like; if I type y, I will have to do > that for every file I visit. I see, should I revert the change? > This is the nuisance caused by immediately adding newly introduced > variables into file-local or directory-local settings to our > repository. We should keep this in mind when introducing such stuff. Generally speaking, the ability to set a variable only if the symbol is bound would be useful for features like these.