From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.devel Subject: Re: new package: tramp-docker Date: Tue, 27 Sep 2022 18:54:16 +0200 Message-ID: <87sfkcwyfb.fsf_-_@gmx.de> References: <5674f36a-c276-fd77-b4d2-1525c75a1602@spork.org> <87y1uarnhu.fsf@gmx.de> <63d5f29a-05ed-f8c5-796c-a6eb9e28d575@spork.org> <87tu4yrmwi.fsf@gmx.de> <87mtaqrmio.fsf@gmx.de> <87h70xrrgi.fsf@gmx.de> <44bd6537-316c-acc7-a4d6-6123bc32e2c0@spork.org> <878rm8soce.fsf@gmx.de> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15396"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Brian Cully Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Tue Sep 27 19:36:13 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1odEVB-0003kI-5V for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 19:36:13 +0200 Original-Received: from localhost ([::1]:50470 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1odEV9-00016Q-Nl for ged-emacs-devel@m.gmane-mx.org; Tue, 27 Sep 2022 13:36:11 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:53180) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odDql-0005aj-IF for emacs-devel@gnu.org; Tue, 27 Sep 2022 12:54:27 -0400 Original-Received: from mout.gmx.net ([212.227.17.20]:57235) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1odDqi-00039m-KN for emacs-devel@gnu.org; Tue, 27 Sep 2022 12:54:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1664297660; bh=pDHo/8EyY+FfzG35XPB6TqchKrByCO2pqVExmsZbns8=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=WetODU+nP3DJizf1auumhlgr7ElXynzJN/1Y6SskQHNpNbeKi01jSEG7sS80mdxIG Kv4gBvpkmWQkhm4JSPVtcp6dOY8U5AKSbHbthrum1UVIP7qkTq5ycqNvZMRBSNt1iH U1z/XSpXT94dgw9BoXz37DdNdH3ZKGXTfkAHsn+k= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([217.70.140.159]) by mail.gmx.net (mrgmx104 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MZCfJ-1ohOqj0lJR-00VAqv; Tue, 27 Sep 2022 18:54:20 +0200 In-Reply-To: (Brian Cully's message of "Sat, 24 Sep 2022 13:31:17 -0400") X-Provags-ID: V03:K1:J00rKhh6EdBVZs5U4Bq2NLCNxanPPV4hw6V6Peyw7erILN73wsn 9lnr8ObvDPik174Xct3nRFQ9TDb6T+mbolnYB3R76X5bjnYBEUCsd90xF5VcncOppAmk44x 4FXwDKXt5kKdTVE2l5foEHEIlh4rCutF5jnVS7tV3Q8DvtJL20Lif/6fyzSunzle9s2BBkM gxtS6mxJ480P/iS3c2YLQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:O4WLWs2lqSM=:XgAe5SSRiJAiKq2OMNViYw h0eN7YEvAjrCaqZO1vwLMD0wAB5xs/LBjo3NYgcIBK0MiCkDFtvGWqCCazfWCZQ3y8FrR13XB k+07b/DaAoAA25dxAy7W9Vwt2BeW0qruEqp8KqavOQcMYqY75xMzTC+HxF9SE1BV16BsWvnU4 9npE6q+dWDAKbnDTrTEzUYO9+FqNBRPEJod+Cos50PPJBl6ORyT77EfrE6gY3L9TgccG/GCFv Hqpea+chlM8YMrZUyGw4+s0BnxztqgrHdEVIvsaNrE4BO4T5d2XmbtT3XQ7mQW/ZiSjvhuTd4 Dd+qGDPx7aPKB5FIrMuZi/9SdL6khSmuSUoDZ8kyhMTS5XRVwaRRbOPr1fvJ2oeZcKBJ2dx6r l4sh556iW76opKQYvQi9X7rW2Vy3zP3Bs3+tHG4ZhR87nICTUWnEdRDLw7Nvn2FEnXtpoDsD7 /1ne54wnvy74593FXL/DSM6iw7Twtw5wpQmgZ+5Pt8gKu18Ila/SVASiSwi+XmYjOcv97cKaD ChCeGzSQW857mW5sRNsIUWU3CS69BsqX1Q/M04M6j/+YR9/3l2I9MKmuH0kmiullcon5THlAQ HMwoXOOY4PvCqSJiq2dKlotatqHv9IFgDCvwzykPQubZvnD3i1zxHQxuRKKXmglXK65mEpNJQ PFOYVLYv7w8Ku8jqKijv1KdS577NSSN68hQ7U8kt6lvAh57vILvCF6Z6w3dEvbTW5GATWVdoc WvrsQlDAmqzyDLoEnhGQulzR7wQOS1TqSirVUF2ybTB10MoeRHI3qSZkc35KXiURcpV60zlf Received-SPF: pass client-ip=212.227.17.20; envelope-from=michael.albinus@gmx.de; helo=mout.gmx.net X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_BL=0.001, RCVD_IN_MSPIKE_H2=-0.001, RCVD_IN_MSPIKE_ZBI=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:296359 Archived-At: Brian Cully writes: Hi Brian, >> Are you sure, that /bin/sh will always exist in containers? > > No, I don't think it's possible to know that for sure. But I think > Docker only supports *nix containers, in which case it's a reasonable > assumption. Even Guix has /bin/sh and /usr/bin/env. It's almost true. But on Android, for example, it doesn't exist. There's /system/bin/sh instead. >> And shouldn't >> we rather use tramp-default-remote-shell instead of hard-coding >> "/bin/sh", for the benefit of customization? > > I wasn't aware of `tramp-default-remote-shell' at all, but it seems > like that's what should be used rather than hardcoding the value. I've changed it accordingly. And I've also changed tramp-docker--completion-function in order to make it more robust. I've also tested, whether tramp-direct-async works out-of-the box, it doesn't. I'm pretty sure we could make it running, it just needs some more love. > -bjc Best regards, Michael.