From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Albinus Newsgroups: gmane.emacs.bugs Subject: bug#58265: 29.0.50; [PATCH] $HOME adjustment for 'ert-remote-temporary-file-directory' is wrong Date: Mon, 03 Oct 2022 13:53:12 +0200 Message-ID: <87sfk5nmxj.fsf@gmx.de> References: Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9091"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 58265@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Oct 03 13:54:14 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ofK1W-00025j-MD for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Oct 2022 13:54:14 +0200 Original-Received: from localhost ([::1]:44544 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ofK1V-0006V8-Hb for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 03 Oct 2022 07:54:13 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40258) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ofK1K-0006Qt-H3 for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2022 07:54:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:50061) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ofK1K-0006Zq-7v for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2022 07:54:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ofK1J-0001Dk-Td for bug-gnu-emacs@gnu.org; Mon, 03 Oct 2022 07:54:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Albinus Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 03 Oct 2022 11:54:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58265 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58265-submit@debbugs.gnu.org id=B58265.16647980134654 (code B ref 58265); Mon, 03 Oct 2022 11:54:01 +0000 Original-Received: (at 58265) by debbugs.gnu.org; 3 Oct 2022 11:53:33 +0000 Original-Received: from localhost ([127.0.0.1]:49139 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofK0r-0001D0-5j for submit@debbugs.gnu.org; Mon, 03 Oct 2022 07:53:33 -0400 Original-Received: from mout.gmx.net ([212.227.15.18]:34497) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ofK0f-0001CZ-Kg for 58265@debbugs.gnu.org; Mon, 03 Oct 2022 07:53:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1664797993; bh=rRGxl/GUksLefeeWJtyVQPqVeutzxALwmRU9xVWEhjo=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=jLE0lkdAXkD9m8o2EVABPsrO56goc/rbij/rwSHera8abzg9PSMN5k/B44CCknvj3 +LZ3r67p6aGbt/Qk9iQs9crZNEu9AdW9ydIhEpZC7MfyLaH8+AgBy7c24gcfhB6H/a tVQrjAp62elOsR4QDozQpevj8Ca4JDQQRQtPevV4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Original-Received: from gandalf.gmx.de ([213.220.156.128]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N33Il-1pMJCm06zF-013OsK; Mon, 03 Oct 2022 13:53:13 +0200 In-Reply-To: (Jim Porter's message of "Sun, 2 Oct 2022 18:32:32 -0700") X-Provags-ID: V03:K1:0OsW9cyCmI14yX8qk7ks0ueYb3M4OV0rssourjuQmnlLQooya/p bXi6Q0ksa77eU5FLpok+Py9O9z++Lzff7jIEhICgt68EHoqtAl+mSBbw7Eo4bcWiSzCRVzk K+YCuOYmzOlqTN8i9mu/91u4sbxnDo6n3cuQg+4AQfy7aHijy4i8gxkNx3eFGEpQZw8cffg 0UI5ne+C0AxPEI4uZxa+g== X-UI-Out-Filterresults: notjunk:1;V03:K0:2A8SA/6jkKg=:H/4Ec+P7rqycR9bVDWy7AU Ug//ViBbwMhh42PIW7Y9bXPsoxfDbSr1f7Dl1VoIPh3QXTaM3z/xy3d4TDn6vERAHx0ZNVpSe gAcKTttDRCoF0Z/+AM8S4iNB1QSdxPLJsY7Ot4dQ/QTFqfwqLBq6z5fjXI/oAPXF5A3IpYHje SIcEEITlmUwLHIvOtivra9DKUaMosYPnquNwZXLMAFuXgMPbWZSvrc63xlgFSDJjQPdw4sbjT eWgJYMKtSz+Pi3+GNwp/wZ1BQ5wqMKN3fQOuicg8Fx9QmH2srTcT61Yj1w9rTpuX2LglXQVJ+ Y5Fb1MzeMwBAvjl+7AySP7PAC+mc9IIYCqqmWwnMYe4mMk+/9m2VgXMGxFhngZd40WqNgmccc T9QXcK4XhyLIaQIHWrSk+1fxPXKPMqWOoFSpWwHTy3ww3uxwNQaVjACjUM+uHDw2kx6aIJXR8 5T2N/mUQyqOpyFeq4oORKlntLxX71rC1Vnsl9vN1K3+0cIkAjONXqDzs1GmSGbngIGglooQEw 9bsgQIPLJrgQ9bqTpe+AowZ8FDjqiyHSOJ68duhF1rzUlgo1cw+g/jezX1JFmEQq6b0Nh+G6B NXx0nfvEKYK0Uk9cFlcao2Onx6VufE6l/NI5aKeK2/yMtmBRKYqePLL9PXt39GM1XAhqdMVCO pFkoxrdnlU9Ji+u3aSV+/OwFluffpcERpOOXD1+Xg4GkClikFVAXj+sHPQfqU7FosmrIAT4eR czYOEsY21LRrPxFjoUHV61osMjQualfQlMqmbrF9hPVLPqph0eSCeexAqQE7YoXp88dQ+kHG X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244296 Archived-At: Jim Porter writes: Hi Jim, > Looking at ert-x.el, I think this is because > 'ert-remote-temporary-file-directory' does some fixup on $HOME, but it > was too aggressive. See attached. > > diff --git a/lisp/emacs-lisp/ert-x.el b/lisp/emacs-lisp/ert-x.el > index bfd796586d..a891f068a7 100644 > --- a/lisp/emacs-lisp/ert-x.el > +++ b/lisp/emacs-lisp/ert-x.el > @@ -568,7 +568,7 @@ ert-remote-temporary-file-directory > `("\\`mock\\'" nil ,(system-name))) > ;; Emacs's Makefile sets $HOME to a nonexistent value. Needed > ;; in batch mode only, therefore. > - (unless (and (null noninteractive) (file-directory-p "~/")) > + (when (and noninteractive (not (file-directory-p "~/"))) > (setenv "HOME" temporary-file-directory)) > (format "/mock::%s" temporary-file-directory)))) > "Temporary directory for remote file tests.") IIRC, I've applied the original setting due to problems on hydra or emba (don't remember exactly). Let's see how your patch works there. Best regards, Michael.