From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.bugs Subject: bug#57400: 29.0.50; Support sending patches from VC directly Date: Thu, 06 Oct 2022 14:37:59 +0000 Message-ID: <87sfk1m308.fsf@posteo.net> References: <84v8qgn1z9.fsf@iki.fi> <87h71zo3p8.fsf@posteo.net> <87sfljmgwz.fsf@posteo.net> <87y1twvima.fsf@posteo.net> <84sfk2p846.fsf@iki.fi> <87h70i9ntt.fsf@posteo.net> <87edvl6vbj.fsf@gmail.com> <8735c1nn3y.fsf@posteo.net> <877d1d6rcy.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="27095"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 57400@debbugs.gnu.org, Antoine Kalmbach To: Robert Pluim Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Oct 06 16:41:56 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ogS4R-0006nO-Fl for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Oct 2022 16:41:55 +0200 Original-Received: from localhost ([::1]:44562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ogS4Q-0002Bo-Fe for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 06 Oct 2022 10:41:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:40054) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ogS1e-0000A1-2C for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 10:39:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:34050) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ogS1d-0007ml-OZ for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 10:39:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ogS1d-0007m9-JP for bug-gnu-emacs@gnu.org; Thu, 06 Oct 2022 10:39:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Philip Kaludercic Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 06 Oct 2022 14:39:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 57400 X-GNU-PR-Package: emacs Original-Received: via spool by 57400-submit@debbugs.gnu.org id=B57400.166506709129788 (code B ref 57400); Thu, 06 Oct 2022 14:39:01 +0000 Original-Received: (at 57400) by debbugs.gnu.org; 6 Oct 2022 14:38:11 +0000 Original-Received: from localhost ([127.0.0.1]:33118 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogS0p-0007kN-5O for submit@debbugs.gnu.org; Thu, 06 Oct 2022 10:38:11 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]:44705) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ogS0n-0007jz-E7 for 57400@debbugs.gnu.org; Thu, 06 Oct 2022 10:38:10 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 834DC240101 for <57400@debbugs.gnu.org>; Thu, 6 Oct 2022 16:38:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1665067083; bh=VAwVxmENjP76a/dD2gLQr3Nyb6RDfZGiDW1Ds0cC43w=; h=From:To:Cc:Subject:Autocrypt:Date:From; b=KzcPyycTlKR0xLFKhJdUpjkKW23ECV8B6A2gB+m0gXgaXfJvbOMcda+3CL3sliQmZ hhZnSqVnYOdGTf7FLgfpmrvP43Za7LnFJxmlfnpnTYRlvx0PcsJmFMEOxvy0KpvPOC hTD2CEtqC3mLV0pDQTO/ECMa22oH8iWJlL26z3n4DlO7Uxvy2FIQiBgTYmXR2FEr+e JOi7yCHqULitSeHLMKqvYPh7zMi7HHUw7mNhRhNWSy4qn5U2mI1eANZ+OHnOTkTGS5 zPfZSIpBBVS3EkJNm6EO9HXXE3psOsJCSFoWTOg46HXRWFbI6MNye/pmCKDoH6ZxX7 4h3lJSZiqMrYQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4MjvDl3rRJz6tnC; Thu, 6 Oct 2022 16:37:59 +0200 (CEST) In-Reply-To: <877d1d6rcy.fsf@gmail.com> (Robert Pluim's message of "Thu, 06 Oct 2022 14:58:37 +0200") Autocrypt: addr=philipk@posteo.net; prefer-encrypt=nopreference; keydata= mDMEYHHqUhYJKwYBBAHaRw8BAQdAp3GdmYJ6tm5McweY6dEvIYIiry+Oz9rU4MH6NHWK0Ee0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiQBBMWCAA4FiEEDM2H44ZoPt9Ms0eHtVrAHPRh1FwFAmBx6lICGwMFCwkIBwIGFQoJ CAsCBBYCAwECHgECF4AACgkQtVrAHPRh1FyTkgEAjlbGPxFchvMbxzAES3r8QLuZgCxeAXunM9gh io0ePtUBALVhh9G6wIoZhl0gUCbQpoN/UJHI08Gm1qDob5zDxnIHuDgEYHHqUhIKKwYBBAGXVQEF AQEHQNcRB+MUimTMqoxxMMUERpOR+Q4b1KgncDZkhrO2ql1tAwEIB4h4BBgWCAAgFiEEDM2H44Zo Pt9Ms0eHtVrAHPRh1FwFAmBx6lICGwwACgkQtVrAHPRh1Fw1JwD/Qo7kvtib8jy7puyWrSv0MeTS g8qIxgoRWJE/KKdkCLEA/jb9b9/g8nnX+UcwHf/4VfKsjExlnND3FrBviXUW6NcB X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:244675 Archived-At: Robert Pluim writes: >>>>>> On Thu, 06 Oct 2022 12:38:25 +0000, Philip Kaludercic > said: > Philip> +(defcustom vc-prepare-patches-inline nil > Philip> + "Non-nil means that `vc-prepare-patch' creates a single > Philip> message. > >>=20 > >> "Whether `vc-prepare-patch' attaches all revision in a single mess= age." > >>=20 > >> I=CA=BCm not sure this should have the suffix '-inline', because y= ou can > >> have inline attachments and attached attachments, but it=CA=BCs no= t a big > >> deal. > > Philip> If you have a better name, there is no better time to > Philip> change it than now. > > `vc-prepare-patch-attach'? `vc-prepare-patch-attach-patches'? It=CA=BCs a= ll > a bit of a mouthful to type, and it doesn=CA=BCt feel like much of an > improvement over what you have. Maybe `vc-prepare-patches-separately' and set the value to t by defaut? > >> I also wonder about the default. Creating 100 mail buffers by acci= dent > >> is harder to recover from than a single one with 100 attachments, = but > >> I guess experience will inform us. > > Philip> The only case where this might happen by accident is when som= eone > Philip> invokes `vc-prepare-patch' in a log-edit buffer where all > Philip> (or at least a > Philip> lot) of revisions have been marked. In that case, one could = add a > Philip> "safely check" and make sure that the user actually wants to = proceed. > > That sounds sufficiently hard to achieve by accident that we > should leave it alone for now. Ok. > Philip> +A single message is created by attaching all patches to the = body > Philip> +of a single message. If nil, each patch will be sent out in= a > Philip> +separate message, which will be prepared sequentially." > Philip> + :type 'boolean > Philip> + :safe #'booleanp > Philip> + :version "29.1") > Philip> + > >>=20 > >> (I didn=CA=BCt check, can this do the [PATCH n/m] stuff with the > >> subject that 'git format-patch' can do?) > > Philip> Yes, as the Git backend just copies the subject name that > Philip> git-format-patch generates. > > Perfect > > Philip> As this is just the default value for > Philip> `read-multiple-choice' a list with > Philip> commae should do. That being said, how common is it to have = multiple > Philip> people you consistently want to send a patch to? Usually > Philip> you'd have a > Philip> central mailing list or something like that, I'd assume. > > Right, and it=CA=BCs a string, so it caters for multiple addresses. I am confused, so everything in fine? > >> ? What does `vc-prepare-patches-inline' have to do with the SUBJEC= T? > > Philip> Because the subject for an "inline patch" is extracted > Philip> from the commit > Philip> message. > > Perhaps mention that in the docstring? That should be doable. > Anyway, I think I=CA=BCve picked enough nits for this patch. If there is anything more to nit, please pick. > Robert