From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59833: 29.0.60; json-ts-mode fontifies everything as string Date: Mon, 05 Dec 2022 12:24:05 +0100 Message-ID: <87sfhudrfu.fsf@thornhill.no> References: Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32551"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Randy Taylor , Yuan Fu , jostein@kjonigsen.net To: 59833@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 05 12:25:55 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p29bc-000896-CL for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 05 Dec 2022 12:25:52 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p29bG-000088-Bu; Mon, 05 Dec 2022 06:25:30 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p29ar-0008WC-AD for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 06:25:05 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p29ap-0003bt-S5 for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 06:25:04 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p29ao-0003MV-B8 for bug-gnu-emacs@gnu.org; Mon, 05 Dec 2022 06:25:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Dec 2022 11:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59833 X-GNU-PR-Package: emacs Original-Received: via spool by 59833-submit@debbugs.gnu.org id=B59833.167023945412887 (code B ref 59833); Mon, 05 Dec 2022 11:25:02 +0000 Original-Received: (at 59833) by debbugs.gnu.org; 5 Dec 2022 11:24:14 +0000 Original-Received: from localhost ([127.0.0.1]:35416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p29a1-0003Ln-Lv for submit@debbugs.gnu.org; Mon, 05 Dec 2022 06:24:13 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:33915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p29Zw-0003Lf-Mp for 59833@debbugs.gnu.org; Mon, 05 Dec 2022 06:24:12 -0500 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1670239447; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ilIofjA47gxewr/L81Fl5uMqS3UGBhUS34c6/p/4u58=; b=T0Efrcxe4OR3UIviUtDye8PwLQsRnPnH7/mtYYP3oQxXyTfomUaqSjUl7WqKH4W+V6Jo1k 25jcbX3i06rqszwJi9MoJcpFQuJ4q2ebEk6/55jL0sySGz33WRL82Wn1Fjn0zUNkKZDNhj WmwBRCrXpvNQQGGRdNTW3+peVaXApU97BZ4S4is04aGFnEj10grOt43i+WETFHzgJ/5QBe hoT9wcA+bZgQW/Bo4JYlExWIiYRasKE65eTK9RCjL8+vH9ncIF3XAxeA6sj1ny9y+yXrUk gtiEkR63mpWbsA7oZHe9ZWlnqJ+ck48wyLWn3YZkryYF1zMIIcLbAqAD/vcRTA== In-Reply-To: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250005 Archived-At: Jostein Kj=C3=B8nigsen writes: > Hey everyone. > > When opening a JSON-file in a build from emacs git emacs-29=20 > release-branch, Emacs still defaults to json-mode. > > Fontification in json-mode looks correct and proper. > > When trying to insteas use json-ts-mode, literally everything is=20 > fontified as strings. > > When I change the code to disable the string-fontification rule, this=20 > yields a buffer where everything is fontified using default-face. That=20 > is, no other fontification is taking place. > > Have this mode really been tested? Should it be working? Or is there an=20 > error on my end? > > Could someone else please give json-ts-mode a try? > Yeah, you are correct. It seems we've had a regression in this commit, 0ed313642227afdeccf48057eea458edca9d2962. I believe this is the offending commit - what do you think, Randy? Specifically the lhs should be fontified differently than the rhs, so not everything is a string. Do you want to do that, Randy, or should I? Theo