From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#60565: [PATCH] src/pgtkfns.c (parse_resource_key): Use recursive schema lookup Date: Sat, 07 Jan 2023 19:04:18 +0800 Message-ID: <87sfgmip1p.fsf@yahoo.com> References: <83a62uu2rm.fsf@gnu.org> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16524"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Tad Fisher , 60565@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jan 07 12:07:04 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pE72W-00043n-CN for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 07 Jan 2023 12:07:04 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pE71g-0005pA-3n; Sat, 07 Jan 2023 06:06:12 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pE70Y-0005cA-Hr for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 06:05:08 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pE70Y-0005Fw-88 for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 06:05:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pE70X-0003ti-Nr for bug-gnu-emacs@gnu.org; Sat, 07 Jan 2023 06:05:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 07 Jan 2023 11:05:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60565 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60565-submit@debbugs.gnu.org id=B60565.167308947614944 (code B ref 60565); Sat, 07 Jan 2023 11:05:01 +0000 Original-Received: (at 60565) by debbugs.gnu.org; 7 Jan 2023 11:04:36 +0000 Original-Received: from localhost ([127.0.0.1]:56537 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pE707-0003sx-Qp for submit@debbugs.gnu.org; Sat, 07 Jan 2023 06:04:36 -0500 Original-Received: from sonic304-21.consmr.mail.ne1.yahoo.com ([66.163.191.147]:40078) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pE705-0003sg-8p for 60565@debbugs.gnu.org; Sat, 07 Jan 2023 06:04:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673089466; bh=HMUeqy28eQBj8Xa3tQ7KYI9tw6y3eUW9+ddv/s1i9s8=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=UqB6oX79dAjW9qpY3G7WyjBZTtbuCPlsstrXx5V+Ghruu+6ziUgaTI+9vfTv6WXvqM9MzDuiKgfEbAhFzwGNpqy4GxMeVQC/cX1IlPrqvdy5b90rMfZfS3TleGgkeYGBuzCoLmPgAhhSBi/LtyXl0zrkm/Zz2cWa7KYC5lK4lyoZHta6KBYGUoV0hQxZRwz/lF9gTsyKQamcaNoyjJGJnT9qyqc1G3qU3eewglL4RT1xfNcHTGn/JKYXnMe2xRQiJOnjMwpV9z5I61TuNFQD2KIECM8Pb3FQ11NsgXYKl2Lk2O9m285SFoEG5oUWTTI3H6T3c5f6rY/HXekA0q0JhQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1673089466; bh=fyjUAWLRsX6EUAjEeyZkc+YQgNPA1zezJ5AkzSynALO=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Dq7wmxgHVujoWUCGMq3P2RzxuJzfYo94yM8fYAImgOAXZ7vJzC+HsqMtM1ueXl7s5YtkfFV4bB/UKsiY9+xHpmcCG5o+FSNkiTLNkrSfacKrEfS/+ycde7YVkMcqmkg71lDaZWsYakaHmE6WhEluF4Zx9T66MWzQgJX1iuTcBQikvyALh4Z3SW05rp1tOmL7Hq9y4spgYKKz45T/yRD7/Absu/IQBO1O/IoLiN+/YDLMwE6AexhpVuAGx0uITq6TfOm5tOKaJt651xEM5KXMwrxSrjquicplo5Sc6ZACpSKrVpi+x4YIIl5XIXO07+Afh+K2CbCpV7HEzEhPk06CpQ== X-YMail-OSG: 3PGUKHcVM1lC_6XBtSfOZ5Zb2WtUKwJfe6xb4_z4KUxQr0CRlRox82mwMOfOM8V FKRN7eunNk_rmq5cd85yMpLiwRSSS7Gkt0yiMJFulrbK7lGzw73Pzj6RUDuhy6z4pTCdd5HMpdD. zKkdaQbdR.cnqclSGFs7VlbQwi7nydwC6o7MphKtLdECybUq0Dxrh.yfNtJKgT7E_gx4YwbOWMhW S.4POjCR7TGxfQ5TBLnaUUe9vAFucB0PMKrEYNM6K4QWooAmcpRLjFYeygpR0p13.mt0dUkLPruD oX0Y8MN_5QwMlCaN2A_s1dOmM8j2PZR3Nh8NhAmjRW7LLYqE4tLaqHeA8CGEU.5J.Ypz3kEQiZGK 1u1qmGbdm7Mt9V0GNZNNRg7.pyc_y4rZ5nT8EWlGzVS3aq1iX1SOn840Qmo5rOxAOBqrwbOR0L2q OE75lBgroEd5UdpogU5kFZImmtp73OQl9Y20_sQZ0.RVIEjE4XnEU378y7c.TaUD4A0WG1Jbin8G VfLNrGrsS4Qkx03jz_Pm0tGemUuVubgf9tW5I6KYGiXRQY6bRqirVW8uau078Cbm2UJJhdUvkKEK GddVl3nsdLO5.w2yk.bKyMfMmojv.6rrjQ7yyso3Agsn7H17s_oxU6JwMjGi4lNV0nsIFogjhslc 0MZOq8DN_vggRSwDyxbY5cjrtoINX7XmvPgPEOWWJfTXjaunuZ8mNva6R_fjO4AcdPr665otches ADBY43C9kZ6fnMLsqNJ04y8sL7n9AEBJE4EB0EeZJKGogEk3ucmR.6NsK8shHsqsP4JH.nrNHd4d ITwyKraLe9fHvsXGPsjEWTTOhKrPwSIUnrreMtNvYd X-Sonic-MF: Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Sat, 7 Jan 2023 11:04:26 +0000 Original-Received: by hermes--production-sg3-b666c6484-bdtvh (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID 0a82cf42c3c0f0f20ce9e8c1bc4f0173; Sat, 07 Jan 2023 11:04:23 +0000 (UTC) In-Reply-To: <83a62uu2rm.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 Jan 2023 11:12:29 +0200") X-Mailer: WebService/1.1.20982 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252782 Archived-At: Eli Zaretskii writes: >> From: Tad Fisher >> Date: Thu, 5 Jan 2023 01:58:47 +0000 >> >> >> From 8e2cf80593dd78030929f96f0f1a3e1a325428a4 Mon Sep 17 00:00:00 2001 >> From: Tad Fisher >> Date: Wed, 4 Jan 2023 13:40:17 -0800 >> Subject: [PATCH] ; * src/pgtkfns.c (parse_resource_key): Use recursive schema lookup >> >> XDG_DATA_DIRS may consist of multiple directories, and >> g_settings_schema_source_get_default composes these into a recursive >> schema source. One must pass TRUE to g_settings_schema_source_lookup, >> otherwise only the first directory in XDG_DATA_DIRS is searched. >> >> It follows that in the case that the directory containing the compiled >> GSettings schema for Emacs is not the first in XDG_DATA_DIRS, >> parse_resource_key will not accept any resource key, which causes >> pgtk_get_defaults_value and pgtk_set_defaults_value to fail. >> >> This impacts systems that compose multiple GSettings schema sources >> via XDG_DATA_DIRS, such Flatpak and NixOS. >> >> Supporting GIO documentation for g_settings_schema_source_get_default: >> >> > The returned source may actually consist of multiple schema sources >> > from different directories, depending on which directories were given >> > in `XDG_DATA_DIRS` and `GSETTINGS_SCHEMA_DIR`. For this reason, all >> > lookups performed against the default source should probably be done >> > recursively. > > Thanks. Po Lu, any comments? Fine by me. Please install if the copyright exemption checks out. Thanks, Tad.