all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Ihor Radchenko <yantar92@posteo.net>
To: Robert Pluim <rpluim@gmail.com>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Fix some emacs-30 byte-compile warnings
Date: Fri, 17 Feb 2023 14:08:04 +0000	[thread overview]
Message-ID: <87sff49ygr.fsf@localhost> (raw)
In-Reply-To: <87h6wh17p1.fsf@gmail.com>

Robert Pluim <rpluim@gmail.com> writes:

>     Ihor> 3 unexpected results:
>     Ihor>    FAILED  test-org-table/copy-field
>     Ihor>    FAILED  test-org-table/references/mode-string-N
>     Ihor>    FAILED  test-org-table/references/mode-string-none
>
> Hmm, at least the first one is because the code in the 't' branch of
> 	    (if (and (eq elements "") (not keep-empty))
>
> in org-table-make-reference now runs, and it results in
>
> (eval '(identity))'
>
> Of course fixing that causes other problems <sigh>

Meanwhile, I fixed all the other warnings.
https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=eea8da0315b4d9c43272f4ee87d752e651f1a0c0
Now, only this org-table problem remains.

It is clearly a bug of some kind - the code is not doing what it
intended originally. But we need to understand org-table.el better to
fix this...

-- 
Ihor Radchenko // yantar92,
Org mode contributor,
Learn more about Org mode at <https://orgmode.org/>.
Support Org development at <https://liberapay.com/org-mode>,
or support my work at <https://liberapay.com/yantar92>


  reply	other threads:[~2023-02-17 14:08 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-23 13:57 [PATCH] Fix some emacs-30 byte-compile warnings Robert Pluim
2023-01-23 14:04 ` Ihor Radchenko
2023-01-23 17:28   ` Robert Pluim
2023-02-17 14:08     ` Ihor Radchenko [this message]
2023-02-17 15:33       ` Robert Pluim
2024-05-12 17:42       ` Ihor Radchenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sff49ygr.fsf@localhost \
    --to=yantar92@posteo.net \
    --cc=emacs-orgmode@gnu.org \
    --cc=rpluim@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.