all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: "Matúš Goljer" <matus.goljer@gmail.com>
To: Augusto Stoffel <arstoffel@gmail.com>,
	Philip Kaludercic <philipk@posteo.net>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] seq.el: add seq-last for symmetry with seq-first
Date: Tue, 14 Mar 2023 20:14:03 +0100	[thread overview]
Message-ID: <87sfe7kux0.fsf@gmail.com> (raw)
In-Reply-To: <87r0trb2pz.fsf@gmail.com>

> Maybe it's more useful to allow negative arguments in seq-elt?  Saying
> (seq-elt seq -1) isn't much more effort than (seq-last seq).

I'm personally a bit ambiguous about negative indices.  It's nice for
those one liners when you need them, but they are quite confusing
especially if you switch between languages and they all implement them a
bit differently.

Sometimes having simple semantics of "last item" is better for
understanding the code 6 months down the line or when just skimming
through.

But of course we can have both.  Emacs itself has `car` but `nth 0` also
works.

>>> I think for lists it should behave as `nth` or `elt`, so it gives nil.
>>
>> But why?  Wouldn't that be a leaky abstraction, since the behaviour
>> doesn't consistently abstract over the concrete sequence types?  If code
>> doesn't want to worry about what sequence is being used, then it has to
>> manually check the return value or if a signal was raised, depending on
>> the type of the argument to seq-last (which is to ignore the issue that
>> we cannot distinguish between (seq-first '()) and (seq-first '(nil)),
>> the same also being the case for seq-last).
>
> It would be good to look systematically at what errors seq.el can
> signal.  But it also seems that in practice the main value of seq.el is
> to provide a bunch of handy functions rather than allowing you to work
> with a sequence whose type you don't know.

Yea, this has been my experience as well.  Usually I know what the
sequence is, but seq provides a nice interface to not have to *remember*
how to do what I need.  Just seq-do it and it will work somehow.

-- 
Best regards,
  Matúš Goljer



  reply	other threads:[~2023-03-14 19:14 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-14 12:55 [PATCH] seq.el: add seq-last for symmetry with seq-first Matúš Goljer
2023-03-14 15:26 ` Philip Kaludercic
2023-03-14 15:48   ` Matúš Goljer
2023-03-14 16:14     ` Philip Kaludercic
2023-03-14 18:35       ` Augusto Stoffel
2023-03-14 19:14         ` Matúš Goljer [this message]
2023-03-14 22:04         ` Philip Kaludercic
2023-03-15  7:06           ` Augusto Stoffel
2023-03-15  8:09             ` Philip Kaludercic

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sfe7kux0.fsf@gmail.com \
    --to=matus.goljer@gmail.com \
    --cc=arstoffel@gmail.com \
    --cc=emacs-devel@gnu.org \
    --cc=philipk@posteo.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.