From: Robert Pluim <rpluim@gmail.com>
To: mohkale@kisara.moe
Cc: Eli Zaretskii <eliz@gnu.org>, 62994@debbugs.gnu.org
Subject: bug#62994: [PATCH v2 1/1] Add support for colored and styled underlines on tty frames
Date: Mon, 24 Apr 2023 11:21:43 +0200 [thread overview]
Message-ID: <87sfcpbpp4.fsf@gmail.com> (raw)
In-Reply-To: <20230421192433.579140-2-mohkale@kisara.moe> (mohkale@kisara.moe's message of "Fri, 21 Apr 2023 20:24:33 +0100")
>>>>> On Fri, 21 Apr 2023 20:24:33 +0100, mohkale@kisara.moe said:
Mohsin> From: Mohsin Kaleem <mohkale@kisara.moe>
Mohsin> * src/dispextern.h (face, face_underline_type,
Mohsin> syms_of_xfacse,
This typo tell me youʼre not using 'C-x 4 a' to generate your
ChangeLog entries.
Mohsin> +---
Mohsin> +** Support for 'styled' and 'colored' underline face
Mohsin> attributes on TTY frames
Full stop at the end of the sentence please.
Mohsin> + if (face->underline && MAY_USE_WITH_COLORS_P (tty, NC_UNDERLINE))
Mohsin> + {
Mohsin> + if (face->underline == FACE_UNDER_LINE
Mohsin> + || !tty->TF_set_underline_style)
Mohsin> + OUTPUT1_IF (tty, tty->TS_enter_underline_mode);
Mohsin> + else if (tty->TF_set_underline_style)
Mohsin> + {
Mohsin> + char *p;
Mohsin> + p = tparam(tty->TF_set_underline_style, NULL, 0, face->underline, 0, 0, 0);
Mohsin> + OUTPUT (tty, p);
Mohsin> + xfree (p);
Mohsin> + }
Mohsin> + }
space before '(' please.
Mohsin> else if (EQ (key, QCstyle)
Mohsin> - && !(EQ (val, Qline) || EQ (val, Qwave)))
Mohsin> + && !(EQ (val, Qline)
Mohsin> + || EQ (val, Qdouble)
Mohsin> + || EQ (val, Qwave)
Mohsin> + || EQ (val, Qdotted)
Mohsin> + || EQ (val, Qdashed)))
If this was in lisp Iʼd expect to see `memq', but we work with what we
have :-)
Mohsin> + /* Check supported underline styles. */
Mohsin> + val = attrs[LFACE_UNDERLINE_INDEX];
Mohsin> + if (!UNSPECIFIEDP (val))
Mohsin> + {
Mohsin> + if (EQ (CAR_SAFE (val), QCstyle))
Mohsin> + {
Mohsin> + if (!(EQ (CAR_SAFE (CDR_SAFE (val)), Qline)
Mohsin> + || EQ (CAR_SAFE (CDR_SAFE (val)), Qwave)))
Mohsin> + {
Mohsin> + return false; /* Unsupported underline style */
Mohsin> + }
Mohsin> + }
Mohsin> + }
Mohsin> +
Mohsin> /* Everything checks out, this face is supported. */
Mohsin> return true;
Mohsin> }
Your TAB usage here still looks wrong
Mohsin> @@ -5390,15 +5409,26 @@ tty_supports_face_attributes_p (struct frame *f,
Mohsin> val = attrs[LFACE_UNDERLINE_INDEX];
Mohsin> if (!UNSPECIFIEDP (val))
Mohsin> {
Mohsin> - if (STRINGP (val))
Mohsin> - return false; /* ttys can't use colored underlines */
Mohsin> - else if (EQ (CAR_SAFE (val), QCstyle) && EQ (CAR_SAFE (CDR_SAFE (val)), Qwave))
Mohsin> - return false; /* ttys can't use wave underlines */
Mohsin> - else if (face_attr_equal_p (val, def_attrs[LFACE_UNDERLINE_INDEX]))
Mohsin> - return false; /* same as default */
Mohsin> - else
Mohsin> - test_caps |= TTY_CAP_UNDERLINE;
Mohsin> - }
Mohsin> + if (STRINGP (val))
Mohsin> + test_caps |= TTY_CAP_UNDERLINE_STYLED;
Mohsin> + else if (EQ (CAR_SAFE (val), QCstyle))
Mohsin> + {
Mohsin> + if (!(EQ (CAR_SAFE (CDR_SAFE (val)), Qline)
Mohsin> + || EQ (CAR_SAFE (CDR_SAFE (val)), Qdouble)
Mohsin> + || EQ (CAR_SAFE (CDR_SAFE (val)), Qwave)
Mohsin> + || EQ (CAR_SAFE (CDR_SAFE (val)), Qdotted)
Mohsin> + || EQ (CAR_SAFE (CDR_SAFE (val)), Qdashed)))
Mohsin> + {
Mohsin> + return false; /* Face uses an unsupported underline style. */
Mohsin> + }
Mohsin> +
Mohsin> + test_caps |= TTY_CAP_UNDERLINE_STYLED;
Mohsin> + }
Mohsin> + else if (face_attr_equal_p (val, def_attrs[LFACE_UNDERLINE_INDEX]))
Mohsin> + return false; /* same as default */
Mohsin> + else
Mohsin> + test_caps |= TTY_CAP_UNDERLINE;
Mohsin> + }
And here.
Robert
--
next prev parent reply other threads:[~2023-04-24 9:21 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-21 14:29 bug#62994: Support styled underlines on TTY frames Mohsin Kaleem
2024-02-11 17:15 ` bug#62994: [PATCH v4 0/3] Support styled underlines on tty Emacs frames mohkale
2024-02-11 17:15 ` bug#62994: [PATCH v4 1/3] Add face definitions for more underline styles mohkale
2024-02-11 17:15 ` bug#62994: [PATCH v4 2/3] Add support for styled underlines on tty frames mohkale
2024-02-11 17:15 ` bug#62994: [PATCH v4 3/3] Add support for colored " mohkale
2024-02-11 17:23 ` bug#62994: [PATCH v4 0/3] Support styled underlines on tty Emacs frames Mohsin Kaleem
2024-02-11 17:46 ` Eli Zaretskii
[not found] ` <handler.62994.B.168208734930664.ack@debbugs.gnu.org>
2023-04-21 14:34 ` bug#62994: [PATCH " mohkale
2023-04-21 14:34 ` bug#62994: [PATCH 1/3] Add face definitions for more underline styles mohkale
2023-04-21 15:58 ` Eli Zaretskii
2023-04-21 16:08 ` Mohsin Kaleem
2023-04-21 14:34 ` bug#62994: [PATCH 2/3] Add support for styled underlines on tty frames mohkale
2023-04-21 16:07 ` Eli Zaretskii
[not found] ` <878rel5fqr.fsf@kisara.moe>
2023-04-21 17:49 ` Eli Zaretskii
2023-04-21 18:04 ` Mohsin Kaleem
2023-04-21 18:43 ` Mohsin Kaleem
2023-04-22 7:00 ` Eli Zaretskii
2023-04-22 9:32 ` Mohsin Kaleem
2023-04-22 6:47 ` Eli Zaretskii
2023-04-22 9:57 ` Mohsin Kaleem
2023-04-21 14:34 ` bug#62994: [PATCH 3/3] Add support for colored " mohkale
2023-04-21 16:12 ` Eli Zaretskii
[not found] ` <875y9p5fg0.fsf@kisara.moe>
2023-04-21 17:56 ` Eli Zaretskii
2023-04-21 15:52 ` bug#62994: [PATCH 0/3] Support styled underlines on tty Emacs frames Eli Zaretskii
2023-04-21 16:10 ` Mohsin Kaleem
2023-04-21 19:24 ` bug#62994: [PATCH v2 0/1] " mohkale
2023-04-21 19:24 ` bug#62994: [PATCH v2 1/1] Add support for colored and styled underlines on tty frames mohkale
2023-04-24 9:21 ` Robert Pluim [this message]
2023-04-22 10:21 ` bug#62994: [PATCH v3 0/1] Support styled underlines on tty Emacs frames mohkale
2023-04-22 10:21 ` bug#62994: [PATCH v3 1/1] Add support for colored and styled underlines on tty frames mohkale
2024-02-12 1:28 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-01-28 11:30 ` bug#62994: [PATCH v3 0/1] Support styled underlines on tty Emacs frames Mohsin Kaleem
2024-01-28 12:05 ` Eli Zaretskii
[not found] ` <86fryg62kh.fsf@kisara.moe>
2024-01-29 12:37 ` Eli Zaretskii
2024-02-11 17:40 ` bug#62994: [PATCH v4] Add support for colored and styled underlines on tty frames mohkale
2024-02-11 18:05 ` bug#62994: [PATCH v5] " mohkale
2024-02-11 18:07 ` Mohsin Kaleem
2024-02-12 1:43 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-02-12 13:50 ` Eli Zaretskii
2024-02-12 14:49 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-10 17:20 ` Mohsin Kaleem
2024-03-10 17:15 ` Mohsin Kaleem
2024-03-10 17:45 ` Eli Zaretskii
2024-03-10 18:22 ` Mohsin Kaleem
2024-03-10 18:51 ` Jim Porter
2024-03-10 19:28 ` Eli Zaretskii
2024-03-10 19:47 ` Jim Porter
2024-03-11 2:07 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-03-10 19:27 ` Eli Zaretskii
2024-02-12 12:48 ` Eli Zaretskii
2024-03-10 18:08 ` Mohsin Kaleem
2024-03-14 10:20 ` Eli Zaretskii
2024-02-14 19:40 ` Jim Porter
2024-03-10 18:10 ` Mohsin Kaleem
2024-04-14 13:56 ` bug#62994: [PATCH v6] " mohkale
2024-04-14 14:13 ` Mohsin Kaleem
2024-04-20 8:16 ` Eli Zaretskii
2024-04-21 14:51 ` Mohsin Kaleem
2024-04-21 15:57 ` Eli Zaretskii
2024-04-21 16:09 ` Mohsin Kaleem
2024-04-21 16:11 ` bug#62994: [PATCH v7] " Mohsin Kaleem
2024-04-22 0:44 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-22 6:01 ` Eli Zaretskii
2024-04-22 17:35 ` Jim Porter
2024-04-23 0:53 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-23 6:02 ` Eli Zaretskii
2024-04-23 7:32 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-22 17:52 ` Mohsin Kaleem
2024-04-22 17:53 ` bug#62994: [PATCH v8] " Mohsin Kaleem
2024-04-27 9:11 ` Eli Zaretskii
2024-04-29 1:04 ` Jim Porter
2024-04-29 4:52 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-29 7:25 ` Eli Zaretskii
2024-04-29 11:36 ` Po Lu via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-04-29 7:10 ` Eli Zaretskii
2024-04-30 17:53 ` Mohsin Kaleem
2024-04-30 18:20 ` Eli Zaretskii
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sfcpbpp4.fsf@gmail.com \
--to=rpluim@gmail.com \
--cc=62994@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=mohkale@kisara.moe \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.