From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Michael Heerdegen Newsgroups: gmane.emacs.bugs Subject: bug#14013: 24.3.50; dired-isearch-filenames-regexp is matching text outside filenames Date: Fri, 02 Jun 2023 03:34:37 +0200 Message-ID: <87sfbar6j6.fsf@web.de> References: <87li9hk5e5.fsf@web.de> <87wqt1vd0o.fsf@mail.jurta.org> <87d2ut4mji.fsf@web.de> <87620lvavl.fsf@mail.jurta.org> <87zjxxsd6c.fsf@web.de> <87vc8ke4os.fsf@mail.jurta.org> <86zgmutwx9.fsf@mail.linkov.net> <87o83ab67d.fsf@web.de> <86r185520f.fsf@mail.linkov.net> <87czjn39yf.fsf@web.de> <86y2215rbn.fsf@mail.linkov.net> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36834"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Stefan Monnier , 14013@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jun 02 03:35:30 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q4thQ-0009P0-4k for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 02 Jun 2023 03:35:28 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q4th3-0003vT-3N; Thu, 01 Jun 2023 21:35:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q4th0-0003v9-JE for bug-gnu-emacs@gnu.org; Thu, 01 Jun 2023 21:35:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q4th0-0003bq-4R for bug-gnu-emacs@gnu.org; Thu, 01 Jun 2023 21:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1q4tgz-0004vv-S3 for bug-gnu-emacs@gnu.org; Thu, 01 Jun 2023 21:35:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 02 Jun 2023 01:35:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 14013 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 14013-submit@debbugs.gnu.org id=B14013.168566969218945 (code B ref 14013); Fri, 02 Jun 2023 01:35:01 +0000 Original-Received: (at 14013) by debbugs.gnu.org; 2 Jun 2023 01:34:52 +0000 Original-Received: from localhost ([127.0.0.1]:38683 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4tgq-0004vT-DJ for submit@debbugs.gnu.org; Thu, 01 Jun 2023 21:34:52 -0400 Original-Received: from mout.web.de ([212.227.15.3]:59345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1q4tgl-0004vC-59 for 14013@debbugs.gnu.org; Thu, 01 Jun 2023 21:34:51 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1685669678; x=1686274478; i=michael_heerdegen@web.de; bh=dKKbBgO4IluXoyAxoXIToLYGc6/S6v4tCE1y9yztiPs=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=Qx7FFxpGYj+VywS2ALF8UMVhdZHKo/iCvhQtipRStWy+OGrogi87TMTcitb/03sykWtfiIh rKjbgElqwBqBeiZdEIkhctxFFHGQHGi853ZLZlvEjsvLfiS1fJ+HF1jO02zybigm9YJ6N5buO BUwrRMZlQxyKLPgLcvM0ef7BXEz4nBmBIm/LkHJYRdklVcJdOPN1z5bAb4olbxniciWSF9XMT xJ4y9JY6E9EoTqcYCyTBX6gS3r8gA+GGOfFM32YrrjNmORKOfNASmP5M8AwCvXZxGX2IrVKzP rzVmN/UIICjw/6RxQTcdvNEKc6kL1LrpTy2AMT0Nu3Igy44OMHcg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Original-Received: from drachen.dragon ([178.14.74.62]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1MJWoe-1pl2Ry0dFA-00Js40; Fri, 02 Jun 2023 03:34:38 +0200 In-Reply-To: <86y2215rbn.fsf@mail.linkov.net> (Juri Linkov's message of "Wed, 23 Feb 2022 20:53:48 +0200") X-Provags-ID: V03:K1:mDKb5ckncF0QmkBnw4XeR6E07a/UxdIUyls5wdUEqL/TeaaT40y ZjARmK7UBmPca40Mm5aDg3Ju86jKAQOGT9UFkckTUof2nMPBUuuplr9JV5OTQjmvg2axzJT samQlQDDBODxxd8qlJmyQ/rMqqLXYYhajS6GOscF2Rx4hW+LkUabCrIGojLY31YLpEtPhrt I/dYsNnUxVtbhuVNsGaBA== UI-OutboundReport: notjunk:1;M01:P0:w/HPKs5C6/g=;0NesMPWhUcsBQg57bYemAVSK2xt DUbaFfZTU2jnA5ojzjfoh/tB6yfW7Wd3+IXyKEjmwbMcxjC11yIqL2CHn2Ciy2C7NwXt9FAAO hse9nG1v83nI1aq6/hgxgB2aUdd+ii7Nt1IrJ4PNEdVDmt0Ule9iLnyjynDBR1kAKhKbZ+lKi sGj8cxkTI94Ub5ChH4xJNfbRHU7uWCN3C48uuBXMQD+nW1TRYuEXlB6H8fRKrtHnhfYO7DGVo RTxHPqdImZ8McWWRzcXDxeTNi3PE/SxP1lzhtQNO7sD0HLXM8o5rt5VT4vIbawc4YIkQjpXBz jNqF6yehZaFZVBjsi47nouLyQBUu5pw74/QoxccS8VYnItPScNBBYN3aat4yHTmekAzP5M9Sa s9f+s1sjNZ3dCxRAARgjGaGeXzRYFvUjud6xq/G2o+ncWr6dhjRokq+xOOTb7CvHgvd6XJiTh p684oUvREOXAsdc4zyqqLn3H4lKuRQeWWjBgVAcD63Wzvu9A6oRTLboYlsoEz05rvElf4tITP uw4eS8fDRhL92ToPxJ4cJmsQwNm1fuDNb05goKYVFrnO9m4Ki6pXY65WHDnV0yfuzf9ZoHTiQ Ic3mSaXB7yccrsvaOpv1OHGIPsz3CWC5A/Vxwa9v6YBZizCu9ScC8d1nAUIDiv3nzRbs6KYWW 1K31Z8o0WMZpe8D0ODyPHRZo97P/zr4GlhR3rZW15fse7BIDYRzcQ7FWbGxH0DviOBfs+i0MT 9eMF3jeD5DKxw+PPzFotRK7O80eaG+5SVb1edEqAxlpmmCxkkQTzIJoZgvHTcA8aCRBFsl6a X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:262727 Archived-At: Juri Linkov writes: > - (remove-function (local 'isearch-filter-predicate) > - #'wdired-isearch-filter-read-only) > + (when wdired-search-replace-filenames > + (remove-function (local 'isearch-search-fun-function) > + #'dired-isearch-search-filenames) > + (kill-local-variable 'replace-search-function) > + (kill-local-variable 'replace-re-search-function)) Juri, when a user disables `wdired-search-replace-filenames' while still in wdired-mode, won't we fail to undo these settings when the user then returns to normal dired? - should we not better undo these things unconditionally? Second question: could we advice (local 'replace-search-function) and (local 'replace-re-search-function) instead of replacing the value (it might be nicer to users of other packages)? TIA, Michael.