From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Robert Pluim Newsgroups: gmane.emacs.devel Subject: Re: emacs-29 bdb0bc2b4e4: Fix tex-mode display-buffer issues Date: Mon, 12 Jun 2023 16:01:46 +0200 Message-ID: <87sfawhj91.fsf@gmail.com> References: <168646413703.30014.174311348729871734@vcs2.savannah.gnu.org> <20230611061539.9CBD6C1925C@vcs2.savannah.gnu.org> <87352w6fd8.fsf@gmx.de> <83edmgygew.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15173"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Albinus , emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Jun 12 16:03:19 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1q8i8c-0003mK-Rb for ged-emacs-devel@m.gmane-mx.org; Mon, 12 Jun 2023 16:03:18 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1q8i7M-0005Rk-DY; Mon, 12 Jun 2023 10:02:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1q8i7F-0005RG-5M for emacs-devel@gnu.org; Mon, 12 Jun 2023 10:01:54 -0400 Original-Received: from mail-wr1-x432.google.com ([2a00:1450:4864:20::432]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1q8i7D-0000oV-5n; Mon, 12 Jun 2023 10:01:52 -0400 Original-Received: by mail-wr1-x432.google.com with SMTP id ffacd0b85a97d-30c2bd52f82so4326094f8f.3; Mon, 12 Jun 2023 07:01:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686578508; x=1689170508; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from:from :to:cc:subject:date:message-id:reply-to; bh=JVk+XS7ExnVvOYAGOQ7k9L712HhO/NiVf28ReLWaPfA=; b=hWHpCaSTkvuTAO4iaTxdnNb6wmJ/QPvkjNauUZaTwae5j4D/m61HTg0zOMqP2hvT0x Aawm370J6G1PMFqGVgnpqMSVSwkcPAxSwJdmQqDkaE3B6ia+urqFTlICswTwf0lUwd6q oxc39sWpcQN2OPuTM8BB7CISV07uPJVCthiWxS+S7IDkMjdOsXbHjHpKIfApbQefKDFu ljngur9SUs82qCz9/szyw1hWHkn38HcHXkePsK5qCiYkSeo2NZuCGnSPy+0rz1033bS0 dgeBGjh/SdPJ5IAxEiBVEL7yIVaVhtnsvweQtdT06FDwBe2b9OmTYHROtS28zgplzWt4 q/Qw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686578508; x=1689170508; h=content-transfer-encoding:mime-version:message-id:date :gmane-reply-to-list:references:in-reply-to:subject:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=JVk+XS7ExnVvOYAGOQ7k9L712HhO/NiVf28ReLWaPfA=; b=OtaaFoRLiVh0MaQ2FzYO1fdoraZrxLupiDnnWhHyHd+WVwJOJTzSDs56BSYTq0/CLB iCnkE6YStgK3e+x7WhmLmFudojnbD8XiCMlATD7BWhcBg3QvIZHeXYm2MmzkHWk+CnFI C/Dw2s+WH5EiMLD8PhRtlGM5fIRERRTxFCchiZqxBHcYsY1qubO4zTvh1qEohVP81Qrg PvZMeTM3rNdbX+c/RYnDVb+2dYePNZLqxhxDGntUSCkzDkR6Rv6z7j1isCNz2PhgoN41 5rqBiH6hQ6FZQhh8XHR3tYabf5r5p2+q+X46NISJ6qfzE7J/4UWM9xCRvh76E2OrGXp2 UdKQ== X-Gm-Message-State: AC+VfDxKYuOryGRh8vDAc615ub3LfXwrYcoB6GHRwlYu9WhfWwiULFJC 3IFUdwcBQzTc04/JHDOUVOwQAPr7lJw= X-Google-Smtp-Source: ACHHUZ6PAdJhMVMqniwIbLKTsJtVE9CTRUpbC8P9mCdpxRr2HIL/hd3sbfypEJp8wtqV+mUTa4N0/w== X-Received: by 2002:adf:dd51:0:b0:30f:b694:9b11 with SMTP id u17-20020adfdd51000000b0030fb6949b11mr4508801wrm.14.1686578507603; Mon, 12 Jun 2023 07:01:47 -0700 (PDT) Original-Received: from rltb ([82.66.8.55]) by smtp.gmail.com with ESMTPSA id z6-20020a5d4d06000000b0030fb98484f6sm5608581wrt.114.2023.06.12.07.01.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 12 Jun 2023 07:01:47 -0700 (PDT) In-Reply-To: <83edmgygew.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 12 Jun 2023 16:11:03 +0300") Gmane-Reply-To-List: yes Received-SPF: pass client-ip=2a00:1450:4864:20::432; envelope-from=rpluim@gmail.com; helo=mail-wr1-x432.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:306750 Archived-At: >>>>> On Mon, 12 Jun 2023 16:11:03 +0300, Eli Zaretskii said: >> From: Michael Albinus >> Cc: Eli Zaretskii >> Date: Mon, 12 Jun 2023 14:21:07 +0200 >>=20 >> Eli Zaretskii writes: >>=20 >> Hi Eli, >>=20 >> > branch: emacs-29 >> > commit bdb0bc2b4e44a7d40369e10e3de825d58fe46825 >> > Author: Eli Zaretskii >> > Commit: Eli Zaretskii >> > >> > Fix tex-mode display-buffer issues >> >=20=20=20=20=20 >> > * lisp/window.el (display-tex-shell-buffer-action): New defcus= tom. >>=20 >> This results in a test error: >>=20 >> --8<---------------cut here---------------start------------->8--- >> # make -C test test-custom-opts >> ... >> The following options might have problems: >> variable: display-tex-shell-buffer-action >> value: display-buffer-in-previous-window >> type: (cons :tag "Action" (choice :tag "Action functions" (choice :t= ag "Function" (const :tag "--" ignore) (const display-buffer-reuse-window) = (const display-buffer-pop-up-window) (const display-buffer-same-window) (co= nst display-buffer-pop-up-frame) (const display-buffer-full-frame) (const d= isplay-buffer-in-child-frame) (const display-buffer-below-selected) (const = display-buffer-at-bottom) (const display-buffer-in-previous-window) (const = display-buffer-use-least-recent-window) (const display-buffer-use-some-wind= ow) (const display-buffer-use-some-frame) (function :tag "Other function"))= (repeat :tag "List of functions" (choice :tag "Function" (const :tag "--" = ignore) (const display-buffer-reuse-window) (const display-buffer-pop-up-wi= ndow) (const display-buffer-same-window) (const display-buffer-pop-up-frame= ) (const display-buffer-full-frame) (const display-buffer-in-child-frame) (= const display-buffer-below-selected) (const display-buffer-at-bottom) (cons= t display-buffer-in-previous-window) (const display-buffer-use-least-recent= -window) (const display-buffer-use-some-window) (const display-buffer-use-s= ome-frame) (function :tag "Other function")))) (alist :tag "Action argument= s" :key-type symbol :value-type (sexp :tag "Value"))) >> --8<---------------cut here---------------end--------------->8--- Eli> Sorry, I have no idea what this failure means. In particular, the Eli> value is correct for the defcustom, and works in practice, and also Eli> fits the type of the defcustom (AFAICT). Are you sure? (defconst display-buffer--action-custom-type `(cons :tag "Action" (choice :tag "Action functions" ,display-buffer--action-function-custom-type (repeat :tag "List of functions" ,display-buffer--action-function-custom-type)) (alist :tag "Action arguments" :key-type symbol :value-type (sexp :tag "Value"))) "Custom type for `display-buffer' actions.") (defcustom display-tex-shell-buffer-action 'display-buffer-in-previous-wind= ow "`display-buffer' action for displaying TeX shell buffers." :type display-buffer--action-custom-type Did you mean this instead: (defconst display-buffer--action-function-custom-type '(choice :tag "Function" (const :tag "--" ignore) ; default for insertion (const display-buffer-reuse-window) Robert --=20