From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#65649: [PATCH] package-vc: Continue installing package when documentation build fails Date: Thu, 31 Aug 2023 14:19:11 -0700 Message-ID: <87sf7yoq9p.fsf@breatheoutbreathe.in> References: <87v8cvvi6r.fsf@breatheoutbreathe.in> <87r0njvhyo.fsf@breatheoutbreathe.in> <87msy7vhum.fsf@breatheoutbreathe.in> <87pm33r87q.fsf@posteo.net> Reply-To: Joseph Turner Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23623"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65649@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Aug 31 23:29:05 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qbpDt-0005uU-4h for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 31 Aug 2023 23:29:05 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qbpDj-0002Hb-ME; Thu, 31 Aug 2023 17:28:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qbpDi-0002A4-8V for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 17:28:54 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qbpDi-0007Je-0S for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 17:28:54 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qbpDq-0006yb-CH for bug-gnu-emacs@gnu.org; Thu, 31 Aug 2023 17:29:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Joseph Turner Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 31 Aug 2023 21:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65649 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 65649-submit@debbugs.gnu.org id=B65649.169351733426803 (code B ref 65649); Thu, 31 Aug 2023 21:29:02 +0000 Original-Received: (at 65649) by debbugs.gnu.org; 31 Aug 2023 21:28:54 +0000 Original-Received: from localhost ([127.0.0.1]:59375 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbpDi-0006yF-2m for submit@debbugs.gnu.org; Thu, 31 Aug 2023 17:28:54 -0400 Original-Received: from out-239.mta1.migadu.com ([2001:41d0:203:375::ef]:58116) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qbpDf-0006y5-B2 for 65649@debbugs.gnu.org; Thu, 31 Aug 2023 17:28:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=breatheoutbreathe.in; s=key1; t=1693517320; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Ug0MTXUKtMvPXGjOi1KvJH78/0224Ngm6G8VIknQ//M=; b=jtYbKl/2ZnR6zwNDxa0RJ3p7DpdwhUDpBMOQqQQnQIK4e0WMQr3GWczskqlfZwLM27hd2d pZzj8dr9f+OHcg2n909+w39faAOc8IEiw1QtdUD6Klltkap0HfBp7ck3W0hMC4efcCuHnU +jG4VhPHS/cpquBjd3uVBD4hSKW99ek= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-reply-to: <87pm33r87q.fsf@posteo.net> X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268846 Archived-At: Philip Kaludercic writes: > Btw, watch out when reporting a bug, you shouldn't CC people directly, > but add a X-Debbugs-CC header > (https://debbugs.gnu.org/Reporting.html#xcc), as otherwise I'd be > creating a new bug report when responding to your message. Good to know! Thank you! Is it okay to CC people when responding to a bug report email (e.g. if I CC'd Eli in this email)? > Joseph Turner writes: > >> It would be nice to report more information about the package with failed >> documentation, but AFAICT with-demoted-errors does not allow its FORMAT >> string to be a symbol whose value is a string. > > What are the main errors we are concerned with? I am a bit concerned > that `with-demoted-errors' is a too coarse approach and might be applied > to widely in your current patch. It might be better to use a classical > condition-case and handle the right errors in the right place, or if > practicable try to detect if an error would occur before doing anything. I don't know what kinds of errors to expect, which is why I went with the coarse approach. Under what circumstances would we want to stop package installation entirely when documentation can't be built? > Also, the buffer *package-vc doc* should stay persistent and would > include error messages, that could also be used here. Like this? (with-demoted-errors "package-vc: Could not build documentation. See *package-vc doc* for details" ... )