From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Damien Cassou Newsgroups: gmane.emacs.bugs Subject: bug#65704: 29.1; Most code of `project-ignores' seems to be dead code Date: Sat, 02 Sep 2023 18:03:04 +0200 Message-ID: <87sf7wlg07.fsf@cassou.me> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="8086"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Dmitry Gutov To: 65704@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 18:04:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcT6d-0001uo-TW for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 18:04:15 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcT6M-0004dS-Vf; Sat, 02 Sep 2023 12:03:59 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcT6G-0004d5-Gc for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:03:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcT6G-0008RR-8k for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:03:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcT6P-0003j0-OQ for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:04:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Damien Cassou Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 16:04:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 65704 X-GNU-PR-Package: emacs X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.169367062214291 (code B ref -1); Sat, 02 Sep 2023 16:04:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 2 Sep 2023 16:03:42 +0000 Original-Received: from localhost ([127.0.0.1]:38276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcT66-0003iQ-BK for submit@debbugs.gnu.org; Sat, 02 Sep 2023 12:03:42 -0400 Original-Received: from lists.gnu.org ([2001:470:142::17]:45348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcT60-0003i8-O5 for submit@debbugs.gnu.org; Sat, 02 Sep 2023 12:03:40 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcT5l-0004bL-60 for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:03:21 -0400 Original-Received: from mail.choca.pics ([2001:910:1410:500::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcT5i-0008MK-MZ for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 12:03:20 -0400 Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 23C1D18193F46; Sat, 2 Sep 2023 18:03:07 +0200 (CEST) Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavis, port 10032) with ESMTP id To0o1uB6Jfyy; Sat, 2 Sep 2023 18:03:06 +0200 (CEST) Original-Received: from localhost (localhost.localdomain [IPv6:::1]) by mail.choca.pics (Postfix) with ESMTP id 35B7518193F4A; Sat, 2 Sep 2023 18:03:06 +0200 (CEST) X-Virus-Scanned: amavis at choca.pics Original-Received: from mail.choca.pics ([IPv6:::1]) by localhost (mail.choca.pics [IPv6:::1]) (amavis, port 10026) with ESMTP id BmApQs5vtuOf; Sat, 2 Sep 2023 18:03:05 +0200 (CEST) Original-Received: from localhost (91.60.75.86.rev.sfr.net [86.75.60.91]) by mail.choca.pics (Postfix) with ESMTPSA id AB20018193F46; Sat, 2 Sep 2023 18:03:05 +0200 (CEST) Received-SPF: pass client-ip=2001:910:1410:500::1; envelope-from=damien@cassou.me; helo=mail.choca.pics X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269006 Archived-At: Hi, The function `project-ignores' starts like this: (cl-defmethod project-ignores ((project (head vc)) dir) (let* ((root (nth 2 project)) backend) (append (when (and backend (file-equal-p dir root)) It seems to me that `backend' is always going to be nil at this point and thus the 25-line long `when' block will always return nil without doing anything. Am I missing something? This code seems to have been introduced in commit 785fa801596ad7bb9f838cac865f00de29e253d1 "New user option: project-vc-extra-root-markers". Best -- Damien Cassou "Success is the ability to go from one failure to another without losing enthusiasm." --Winston Churchill