From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Newsgroups: gmane.emacs.bugs Subject: bug#60338: [PATCH] Add option to present server changes as diffs Date: Sat, 02 Sep 2023 10:55:56 +0100 Message-ID: <87sf7w526r.fsf@gmail.com> References: <87ilhy1dub.fsf@posteo.net> <877cs97kgb.fsf@posteo.net> <83jzw8yjv5.fsf@gnu.org> <877cs8g8oy.fsf@posteo.net> <83fs6wyhak.fsf@gnu.org> <87y1koerm6.fsf@posteo.net> <83bkhkyeze.fsf@gnu.org> <87v8fr6o86.fsf@posteo.net> <87zg52e12n.fsf@posteo.net> <871qi9q9uc.fsf@posteo.net> <87a5ww7qa3.fsf@gmail.com> <87jzvsdco1.fsf@posteo.net> <87zg2669kk.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34308"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: dmitry@gutov.dev, Philip Kaludercic , Eli Zaretskii , 60338-done@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 02 11:54:09 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qcNKT-0008fk-HZ for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 02 Sep 2023 11:54:09 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qcNKF-0005kG-Cy; Sat, 02 Sep 2023 05:53:55 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qcNKD-0005jU-7a for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 05:53:53 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qcNKC-0006L0-Vr for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 05:53:52 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qcNKM-0007XF-KK for bug-gnu-emacs@gnu.org; Sat, 02 Sep 2023 05:54:02 -0400 Resent-From: =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 02 Sep 2023 09:54:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 60338 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 60338@debbugs.gnu.org, joaotavora@gmail.com, philipk@posteo.net Original-Received: via spool by 60338-done@debbugs.gnu.org id=D60338.169364841228922 (code D ref 60338); Sat, 02 Sep 2023 09:54:02 +0000 Original-Received: (at 60338-done) by debbugs.gnu.org; 2 Sep 2023 09:53:32 +0000 Original-Received: from localhost ([127.0.0.1]:35252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcNJs-0007WQ-8r for submit@debbugs.gnu.org; Sat, 02 Sep 2023 05:53:32 -0400 Original-Received: from mail-wm1-x336.google.com ([2a00:1450:4864:20::336]:57519) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qcNJq-0007W9-5q for 60338-done@debbugs.gnu.org; Sat, 02 Sep 2023 05:53:31 -0400 Original-Received: by mail-wm1-x336.google.com with SMTP id 5b1f17b1804b1-401b0d97850so28586565e9.2 for <60338-done@debbugs.gnu.org>; Sat, 02 Sep 2023 02:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1693648394; x=1694253194; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=TRASGpAuceNPWOMRaX57MfrgfdYIYwjIn0pwKefhZQw=; b=D0M1yQGBQOXpolGIPvd5y3Mf5F8jtIadgkAwhWUyGJSzTDAju6qqmpLcdkMvh3V/23 l/5YGG5BYAHs/z5AflRiBOFfMVUVxU5mofWRnirqmCLdJPQpiTvgYhG0gFUpocBgriuO HL9rcQGXjwGvf0cL4lB06H+DruWsvPexMKVDQdagFGXx/5YZWd3XkOqhJWrh+lri6hRt w9c7j0Z8r8lcx7zdmC0oWImU0rImug6GeS9LNGVfSwRFm13lWi0sJq0SoQ2mgJ2jfhhU d58lI18jvxHL/h0c8zDxzZ3PIwOGxPlIF6ZjudFdNSc6pb3qhbpDYcZ1VrGwS0CpdqFq Wrkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1693648394; x=1694253194; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=TRASGpAuceNPWOMRaX57MfrgfdYIYwjIn0pwKefhZQw=; b=A9Cvg0/fAFqWw433fy+xd0a4cYHklBSujtKthwP1ZsBJtv6HuxxSIdaAZVFwZ6Xoov tAoVEj7rSTiGu9JQGVe4Pb6/5viCfvi87LgSug/scmjKihVyEIXLTr0xEZV9RYXm+LZd 3S8KrkoTkU/tl591VzxWw5qw6RkVWSS9/fysowdPOxJN28GpiXf+A2HdzKzY/LqK7UfI 27VXOoaqhAfza7afyLdpST3ecYBOxnxQfdT+E7mCTD4zeWtEH7OPoEDOykPBvV2ijvDa 26jOGiJXnFt3Z4FMsJZJuVZOusU3ZbempQ4a/fkh+bWrzLrQd7AJDLl5BoGGT3RGAD1F XG7A== X-Gm-Message-State: AOJu0YyeeEGUkL+Dlek4SnWkupd8v29bI9Gkyk5OZvyvX+XsYiFl1ujT PgjWQPCV2LL7aDPjdy/abgFoyxB344ybsA== X-Google-Smtp-Source: AGHT+IEYyw0qDBvAVzEqaf3JE86San1peoV2+NdSoF0zmwEfcnIzJLwU97hFRONqx5eRD9yXniY5gQ== X-Received: by 2002:a05:600c:2249:b0:3fb:b008:2003 with SMTP id a9-20020a05600c224900b003fbb0082003mr3325230wmm.38.1693648393840; Sat, 02 Sep 2023 02:53:13 -0700 (PDT) Original-Received: from krug (a95-92-228-31.cpe.netcabo.pt. [95.92.228.31]) by smtp.gmail.com with ESMTPSA id 10-20020a05600c234a00b003fc06169ab3sm10539323wmq.20.2023.09.02.02.53.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 02 Sep 2023 02:53:13 -0700 (PDT) In-Reply-To: (Eshel Yaron's message of "Sat, 02 Sep 2023 08:13:04 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:268977 Archived-At: Eshel Yaron writes: > Jo=C3=A3o T=C3=A1vora writes: > >> OK, Eshel >> >> I think I fixed all these issues in the latest >> fdf6c164efd0bb467d0d46460161c146e955a48c which I just >> pushed to master. Please have a look. > > Looks good, and works well too, thank you! I'm glad to hear that. I must say that altough I like the new functionality myself -- both the new user option and the diff view -- the current implementation of the latter leaves much to be desired. I've pushed a further commit to simplify it, but it's complicated and brittle. A little change to diff.el would simplify some of it, but then you can't easily publish those changes to Emacs < 29. Anyway I invite everyone to have a look and try to improve it, perhaps moving it out of Eglot into the shiny new "refactoring interface" if those ever become a thing. In the meantime, I'm going to close this. Thanks everybody. Jo=C3=A3o