From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Newsgroups: gmane.emacs.bugs Subject: bug#66676: 29.1; Should some aspects of shr rendering be configurable Date: Sat, 18 Nov 2023 19:09:57 +0100 Message-ID: <87sf53aq6i.fsf@gmail.com> References: <87v8azxek4.fsf@zohomail.eu> <83o7groufg.fsf@gnu.org> <87r0lnx7kx.fsf@zohomail.eu> <87zg06r7fk.fsf@zohomail.eu> <83lebe547t.fsf@gnu.org> <87wmuxoha2.fsf@gmail.com> <87msvbtd6r.fsf@zohomail.eu> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="16547"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Eli Zaretskii , 66676@debbugs.gnu.org, Lars Ingebrigtsen To: Rahguzar Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 18 19:11:15 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r4Pmk-00045t-OS for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 18 Nov 2023 19:11:14 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r4PmZ-00048t-6H; Sat, 18 Nov 2023 13:11:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r4PmX-00048f-Vg for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2023 13:11:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r4PmX-0001db-NZ for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2023 13:11:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r4PmY-00081s-7P for bug-gnu-emacs@gnu.org; Sat, 18 Nov 2023 13:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: =?UTF-8?Q?K=C3=A9vin?= Le Gouguec Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 18 Nov 2023 18:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66676 X-GNU-PR-Package: emacs Original-Received: via spool by 66676-submit@debbugs.gnu.org id=B66676.170033100830779 (code B ref 66676); Sat, 18 Nov 2023 18:11:02 +0000 Original-Received: (at 66676) by debbugs.gnu.org; 18 Nov 2023 18:10:08 +0000 Original-Received: from localhost ([127.0.0.1]:49460 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4Plf-00080N-Vq for submit@debbugs.gnu.org; Sat, 18 Nov 2023 13:10:08 -0500 Original-Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:45345) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r4Pld-0007zl-Pg for 66676@debbugs.gnu.org; Sat, 18 Nov 2023 13:10:07 -0500 Original-Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-4083dbc43cfso3956745e9.3 for <66676@debbugs.gnu.org>; Sat, 18 Nov 2023 10:10:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1700330999; x=1700935799; darn=debbugs.gnu.org; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7mdzku9Er49auLf0H7dFm490aH1YdPBuKGOU+D/IadE=; b=QLQLusFv0RzS1YUqNnlx6cUEJN4zGQz0/1AJ6WDYGRm/zDDc4FAX8zinbIjd4MFC7L 7aX9lMbsYkiLgmeFQ/fQXnPApB3slZVXID4zI3glSSDbja8SL64boeTRH8JhdVSt7Zbc lrra5NqxUfMMJLGS/TQApr5KvzbBE3BhA6f0XvjB/7g0ggtmtytiTl5sVtgL4nzy9VtT iHd1xPgnhQ1I1JtwEc/bPzkL2vKZmMSY3JU6j8Ecx7R2blzc4eB7lGIMTGoK1LRxf9Fg t1iWfE1lNx3VH004x6guFsNS2YdkxyOfCGFB1B30Vj421tGPZAboBJ8kDVLS3OWkLPoE lqNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1700330999; x=1700935799; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7mdzku9Er49auLf0H7dFm490aH1YdPBuKGOU+D/IadE=; b=NB5fzS7QxfkDreWqhf+QcuNDfXNEI4bi8f/ZfsiZ/ovCmptKbiOP0fXyDuPDTN3c49 2gFNvGzIMvvI0FzyngmaPYWYq6RTach9Ccs8MbHAkFk1nsZAjStXyF3EVsFv7yOUCGA3 r5Lf61ViBVPVdHIEkVHXfGSDIOg8HmcVcBlXYEP/aYCVXIvx8+w3qFM0+85kBrzPvRn3 v/eHOZqRvmryq8ho/w7BYTuTnANiOBlr1BtPvT+wG3mK7N+34GA5mTeeKR4feeCxwCTd aDeqRAlLQz59D6BPzvq1Mqz11+bkhCVHZ6o/hBZXDN7MHdA4ErqTlxYukhLo59ssrtW4 YxSg== X-Gm-Message-State: AOJu0YzYwTXdoCdW8fBd0NoY45v7eHsFu/vDOupOKJzrRbHUwyGXzQNK 9nwX9+jT1lPAnxGr5gKqWiRyWKAvEZJ7tPGF X-Google-Smtp-Source: AGHT+IHoTxNvZ2ZktUzQPWDSAJ1WxCV4WOES6kOkPy/26UMRg348hxGKqTjHoKZdxYDZ+DjeYuz9EA== X-Received: by 2002:a5d:52cb:0:b0:32d:81fe:7104 with SMTP id r11-20020a5d52cb000000b0032d81fe7104mr1910581wrv.63.1700330998427; Sat, 18 Nov 2023 10:09:58 -0800 (PST) Original-Received: from amdahl30 ([2a01:e0a:253:fe0:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id f7-20020a5d6647000000b0032d2f09d991sm5878290wrw.33.2023.11.18.10.09.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 18 Nov 2023 10:09:58 -0800 (PST) In-Reply-To: <87msvbtd6r.fsf@zohomail.eu> (rahguzar@zohomail.eu's message of "Sat, 18 Nov 2023 14:08:01 +0100") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274565 Archived-At: Rahguzar writes: > K=C3=A9vin Le Gouguec writes: > >> Don't know if I have anything insightful to say re. the patches. Idly >> wondering if '(null shr-fill-text) =E2=87=92 (visual-line-mode)' is the = right >> control flow; e.g. maybe >> >> (a) shr-fill-text could be set to 'visual as a more explicit hint for >> major modes, or >> >> (b) major modes should grow new user options: e.g. eww-wrap-method =E2= =88=88 >> {fill, visual}; 'visual would tell modes to set shr-fill-text to nil & >> enable visual-line-mode. >> >> There are already plenty of user knobs at the shr level though, so maybe >> no need to overthink this. > > I don't quite see the need of a user option to turn on a minor mode. It > seems better to take the value of `shr-fill-text` as a hint and turn on > the `visual-line-mode` as I have done. I don't think anyone want to see > html rendered without some kind of reflowing. And if they do, they can > turn off the mode in `eww-after-render-hook`. Otherwise, we can also not > do anything and let the users add `visual-line-mode` to > `eww-after-render-hook`. To me hooks rather than dedicated user options > are the correct way to manage minor modes. Gotcha. Not sure why I have such a knee-jerk response to automating visual-line-mode activation. OT1H part of me likes your idea of not doing anything and letting users add visual-line-mode to eww-after-render-hook: it's explicit, it's less work for folks who would prefer to keep it off; OTOH, can't quite picture anyone actually preferring that. I guess by default, truncate-lines being nil, they would get some sort of "reflowing"=E2=80=A6 Tentative bottomline: it's fine as-is really =F0=9F=91=8D The knobs are all= there; I don't have an alternative that I strongly believe in.