From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto <thievol@posteo.net> Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Mon, 20 Nov 2023 18:51:10 +0000 Message-ID: <87sf50s1gh.fsf@posteo.net> References: <87il7ib6cu.fsf@posteo.net> <87sf67qqmp.fsf@web.de> <875y3386ep.fsf@posteo.net> <87a5sddh14.fsf@web.de> <8734y5vnj7.fsf@posteo.net> <87bkcslr18.fsf@web.de> <87y1fwtyrl.fsf@posteo.net> <87y1fut1wp.fsf@web.de> <87ttqgpjiz.fsf@posteo.net> <87wmvbibpr.fsf@web.de> <877cnb2n63.fsf@posteo.net> <8734xyc8z0.fsf@web.de> <87zg05rewi.fsf@posteo.net> <87ttqcg8gw.fsf@web.de> <87h6mcr8ol.fsf@posteo.net> <87r0l73029.fsf@web.de> <877cmdx8ud.fsf@posteo.net> <jwvjzqcxrnq.fsf-monnier+emacs@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="7504"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Michael Heerdegen <michael_heerdegen@web.de>, stefankangas@gmail.com, 66394@debbugs.gnu.org To: Stefan Monnier <monnier@iro.umontreal.ca> Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Nov 20 19:52:09 2023 Return-path: <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org> Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from <bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org>) id 1r59NR-0001iH-Ak for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 20 Nov 2023 19:52:09 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from <bug-gnu-emacs-bounces@gnu.org>) id 1r59NL-0002Xm-Av; Mon, 20 Nov 2023 13:52:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r59NJ-0002Uj-UB for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 13:52:01 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r59NI-00023s-1u for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 13:52:01 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1r59NK-0002y5-7J for bug-gnu-emacs@gnu.org; Mon, 20 Nov 2023 13:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto <thievol@posteo.net> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces@debbugs.gnu.org> Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 20 Nov 2023 18:52:02 +0000 Resent-Message-ID: <handler.66394.B66394.170050629311287@debbugs.gnu.org> Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.170050629311287 (code B ref 66394); Mon, 20 Nov 2023 18:52:02 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 20 Nov 2023 18:51:33 +0000 Original-Received: from localhost ([127.0.0.1]:54552 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces@debbugs.gnu.org>) id 1r59Mr-0002vy-Ch for submit@debbugs.gnu.org; Mon, 20 Nov 2023 13:51:33 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]:45209) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <thievol@posteo.net>) id 1r59Mp-0002vX-BB for 66394@debbugs.gnu.org; Mon, 20 Nov 2023 13:51:32 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id B5EBD240027 for <66394@debbugs.gnu.org>; Mon, 20 Nov 2023 19:51:22 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1700506282; bh=mluEKp0IyfrvZZ1+4OYVhC/NAbKPe0bPI5q0Bbu8wGA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Autocrypt:OpenPGP: From; b=UPUK2CTIaHgM3qOL/Ka78G6q8JrgvpSVxou5g8BhmAlucwoTTaMXbUv2pX9pCzcM2 cc5vZ0jaN2BNThkXDunwzXUTKqDhTkq7meybm7ITgurhb06iLi7kA1F7hh3Fbsf/A4 1bzdHdcSO262LbWvP3IEB0RTQfPkmYlAXEB5kI3ua+YPaZ/y/QOkSqJ5Z4FDkJ4hnW FsRnlyvsyZtrvoCx6X0MG6Al1Wd9sWB2KKywGsza6YvpZplnE6ASxUTIQ0Rx47V6vK elbmj0mWfGAajj/MDer+gaZP6zRc4OrNqxYcaaJYihLwhbN6Wj20+AFQYtlyI/Mw+H YQdgH0ryRwXHg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SYxRq2wYwz6twH; Mon, 20 Nov 2023 19:51:19 +0100 (CET) In-Reply-To: <jwvjzqcxrnq.fsf-monnier+emacs@gnu.org> (Stefan Monnier's message of "Mon, 20 Nov 2023 12:33:57 -0500 (1 hour, 11 minutes, 21 seconds ago)") Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs.gnu.org> List-Unsubscribe: <https://lists.gnu.org/mailman/options/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=unsubscribe> List-Archive: <https://lists.gnu.org/archive/html/bug-gnu-emacs> List-Post: <mailto:bug-gnu-emacs@gnu.org> List-Help: <mailto:bug-gnu-emacs-request@gnu.org?subject=help> List-Subscribe: <https://lists.gnu.org/mailman/listinfo/bug-gnu-emacs>, <mailto:bug-gnu-emacs-request@gnu.org?subject=subscribe> Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:274683 Archived-At: <http://permalink.gmane.org/gmane.emacs.bugs/274683> --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hello Stefan, Stefan Monnier <monnier@iro.umontreal.ca> writes: >> Ccing also Stefan monnier because for some reasons the patch when >> applied doesn't compile (when compiling Emacs) unless we add on >> top: >> >> (cl--generic-prefill-dispatchers 0 (eql 'x) integer) >> >> following the advice of the compiler, > > Indeed, this is needed because `register.el` is preloaded and method > dispatcher are generated&compiled "on the fly" but we don't want to > preload the compiler, so we want to pre-compile the dispatchers used > by the preloaded code. > >> but I am not sure it is the way to do. > > `cl--generic-prefill-dispatchers` is not guaranteed to be defined when > we load `register.el` (it's only defined if we loaded the non-compiled > version of `cl-generic.el`) so the above call should be in > `cl-generic.el` rather than in `register.el`. > > I'd put it next to the following block: > > (cl--generic-prefill-dispatchers 0 (eql nil)) > (cl--generic-prefill-dispatchers window-system (eql nil)) > (cl--generic-prefill-dispatchers (terminal-parameter nil 'xterm--get-= selection) > (eql nil)) > (cl--generic-prefill-dispatchers (terminal-parameter nil 'xterm--set-= selection) > (eql nil)) > > which is already about dispatchers needed to support other files. I will for now leave the call to `cl--generic-prefill-dispatchers` in the patch as a reminder that it should be added instead in cl-defgeneric once merging. Thanks for your explanation. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmVbqp4THHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvk/CzDACNmJnp2vjZHivfKf7dIjo6SUtSGWZq Vgmwuc5Gb0qqidY4G5YJXwk+UsREzdF9DFhbTzU+0yEcykTyOtCTTbPwxUfsF/hS HF1e4j0A1/dKhv40hrHTYBZSh0OaAhIspekcDP9xdx3aLx3lqzeiCrXBS8zAxtCs SZUEu0htk2eonBwdSc9hCwPEAkmnd/pHuGr+9gk+pcft/4k7gus+NaSSQKG7XV2U DTuii6awpm7/6B/feUR67LVUgYeijbEwwsZ8VxLk7f4NClhpay5RZqXVac111ceU 5P/BUxDq96LsCDt98Rr+Gd/yQ866015Bgg7K9WOaU1evM/IHSx0ZXZH4m60Qyuu0 cx+ivp7/Sr5nbiugLZw0ul/kl47EwOiAsKhzfcptWflvvnnkazgW1zXTzROTinfW CdO0yyPqUKocDRu/N5MvK1bWyZupHVVsOhjn+vVNRYivgXdQfyabKHAmyzC0TUMY z4TUoHfGDP3tjY3kTaKylaaE43Wk/khp48k= =30Hl -----END PGP SIGNATURE----- --=-=-=--