all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: mbork@mbork.pl
To: husain@alshehhi.io
Cc: help-gnu-emacs@gnu.org
Subject: Re: Reviewing git patches with the source file without applying the patch
Date: Tue, 05 Dec 2023 08:31:03 +0100	[thread overview]
Message-ID: <87sf4hyujc.fsf@mbork.pl> (raw)
In-Reply-To: <87a5qpb5y6.fsf@>


On 2023-12-04, at 22:59, husain@alshehhi.io wrote:

> Hello,
>
> I often receive patches (files generated by 'git format-path'
> command). I review these files in diff-mode. This is in most cases is
> enough. But sometimes, I want to see the source code before and after
> the change so that I can see the full context. I am not sure how to do
> this in emacs.
>
> diff-mode provides C-c C-c (which is diff-goto-source). This is great
> improvement, but it shows the source file only, not the changes before
> and after. I have to compute in my head the patch against the source
> file to undrestand the change. Additionally, diff-goto-source requires
> the path to the source file. I wish it would take the dir instead and it
> can compute the source file on its own.
>
> diff-mode also provides C-c C-e (which is diff-ediff-patch). This view
> is what I am looking for: it provides a view when I can see the source
> file before and after the change. However, diff-ediff-patch applies the
> change automatically, which is not what I want to do. Additionally,
> diff-ediff-patch generates .orig files which are also unwant.
>
> Any help is appreciated.

That is a great question, and I don't have a 100% solution, but I would
probably use Magit, which makes it easy to discard the changes after
(temporarily) applying the patch.

Hth,

-- 
Marcin Borkowski
https://mbork.pl



       reply	other threads:[~2023-12-05  7:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <87a5qpb5y6.fsf@>
2023-12-05  7:31 ` mbork [this message]
2023-12-05  4:59 Reviewing git patches with the source file without applying the patch husain
2023-12-08 13:46 ` James Thomas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sf4hyujc.fsf@mbork.pl \
    --to=mbork@mbork.pl \
    --cc=help-gnu-emacs@gnu.org \
    --cc=husain@alshehhi.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.