From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Thierry Volpiatto Newsgroups: gmane.emacs.bugs Subject: bug#67702: 30.0.50; insert-register can no longer be used in minibuffer Date: Fri, 08 Dec 2023 10:16:37 +0000 Message-ID: <87sf4dxam2.fsf@posteo.net> References: <83jzpp19xg.fsf@gnu.org> <87wmtpgooa.fsf@posteo.net> <83bkb117y2.fsf@gnu.org> <837clp167l.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="33544"; mail-complaints-to="usenet@ciao.gmane.io" Cc: kun.liu@gmail.com, Eli Zaretskii , 67702@debbugs.gnu.org To: Eshel Yaron Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 08 11:18:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rBXvl-0008SZ-Rw for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 08 Dec 2023 11:18:02 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rBXvc-0001uW-Tu; Fri, 08 Dec 2023 05:17:52 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rBXvZ-0001u3-9V for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 05:17:49 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rBXvZ-0005aG-15 for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 05:17:49 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rBXvl-0008SL-Lw for bug-gnu-emacs@gnu.org; Fri, 08 Dec 2023 05:18:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Thierry Volpiatto Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Dec 2023 10:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67702 X-GNU-PR-Package: emacs Original-Received: via spool by 67702-submit@debbugs.gnu.org id=B67702.170203062632396 (code B ref 67702); Fri, 08 Dec 2023 10:18:01 +0000 Original-Received: (at 67702) by debbugs.gnu.org; 8 Dec 2023 10:17:06 +0000 Original-Received: from localhost ([127.0.0.1]:43882 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBXur-0008QR-Mv for submit@debbugs.gnu.org; Fri, 08 Dec 2023 05:17:06 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]:55173) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rBXun-0008Pf-JW for 67702@debbugs.gnu.org; Fri, 08 Dec 2023 05:17:05 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 8523A240103 for <67702@debbugs.gnu.org>; Fri, 8 Dec 2023 11:16:42 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1702030602; bh=8gal9Tmt61lm7yAzpJe0RXohthWWwUCpRO8Vnuz02Yg=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Autocrypt:OpenPGP: From; b=rFCBMBpE/M9fgtcmnFmcDy9/RqczHZd/J8rGpTwXQLHDG3tyL2UEeSX1kWev0zvg2 J4RpIsJCUKHz2HH1DkLX0Y8p5HqhIMYxS8hPJ4Cf5v897zOhIMJXuX35ojiD9Fxt5/ b+dzN1mY+wXWsRs7z9QGnK6QYrD9HPIEcm1/nH6WWnomtPVJXzrZJtNjjR4G7CaRN7 OkvUL+b25ZmGMrINDnH9kevzq6Xp0jLh0ej2fwZ+HeTD87rEh0h8tj/+2Asstss6wP Aqw1CMZcfzSbRvncgYB+gHMIX7Fp+ojwhaFxpvQtFnau2Zw05l6wrl2qVklzLTf3hX 1RJULlrNXkyLw== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Smn9h47tBz6txr; Fri, 8 Dec 2023 11:16:40 +0100 (CET) In-Reply-To: (Eshel Yaron's message of "Fri, 08 Dec 2023 09:27:22 +0100 (1 hour, 43 minutes ago)") Autocrypt: addr=thievol@posteo.net; prefer-encrypt=mutual; keydata=xsDNBF8ylcIBDADG+hy+zR6L4/vbdDDZuSaMmSrU3A5QZJpeBCvxTr7MpzzruZbhLPW1K3R6N2MA edi8Y+C8o27FVRIjpdbaKMGu9je7JV/TbUQYo3SOwCK1vM4LUn4V6ZLzSYkuiEt4eyMoiDdyvN0p kcK6P9x9DCetcEVszXzQg+yzCVrQ2hXWDXWT4M18EC3wtO7RHPouMqGiwBFhBAYErCqFWFxQHkfb tG/4yGyJ58rglb65O3qijjMWvYwcWZun9/7qm8Z4/4mHopmo2zgU+OrptnLSZfkZGz3Y7Uf452xQ GVq0Fv75NPvQru7y+DYVhuVXXyAmGxt+vf4rIiixMBbhKEPjcxEPAa2LTzex2IsTZR+QVG9uDnqC WcgaOEQ58fzXNvNhtwwF/Rgio2XWAJVdmFWS59/k9W58CIUSNKBMZh2XeGdEmtHvDtCxW3z6FJha 36RzOM3fMNNiAGdFZJA84gcdloJR+sHCDTTPT3784fjr+V8An7sI581NGFzkRQqPvEQCZbUAEQEA Ac0SdGhpZXZvbEBwb3N0ZW8ubmV0wsEOBBMBCgA4AhsDBQsJCAcCBhUKCQgLAgQWAgMBAh4BAheA FiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmL3HCoACgkQDsVtFB0W75OVEAv/f6XxmtIFz08fUb8h Bp/zJP6IC4/rhhh+0GMRIRzLN8DK0jV8JCzYdFHiRJOy2lNIOpmrrCmjRRxferc2G42+ePFIsslx hU46VSz1Z83NwIG3mpdYNV5WUTUdgzxExHTNTFCd7NKv0nlHKQaA OpenPGP: url=https://posteo.de/keys/thievol@posteo.net.asc; preference=encrypt X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275746 Archived-At: --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Eshel Yaron writes: > Eli Zaretskii writes: > >>> From: Eshel Yaron >>> >>> >> > I guess register-read-with-preview should temporarily bind >>> >> > enable-recursive-minibuffers to a non-nil value? >>> >> >>> >> Yes, do you want me to install this change? >>> > >>> > If you think that's the correct solution, sure. >>> >>> FWIW, I think it's not the right solution. As I wrote in bug#66394, I >>> think it's wrong to involve the minibuffer in reading registers in any >>> way. `enable-recursive-minibuffers` would make this less broken, but >>> only slightly. >> >> I'm not sure I understand: if we put aside the fundamental opposition >> to using read-from-minibuffer, what problems will be left if we >> temporarily enable recursive-minibuffers while prompting for the >> register? > > Concretely this is still worse because starting a recursive minibuffer > hides the previous minibuffer. So you no longer see what you're > operating on. There are other problems that I mentioned in bug#66394, > and there's also the disadvantage that `read-from-minibuffer` switches > windows, which is redundant in this case. > >>> It's up to you maintainers to decide, I think. Following your request, >>> I've proposed a patch that reverts Thierry's changes, and implements the >>> parts I find useful in a clean and backward compatible way. >> >> Thierry said your patch was incomplete. > > Well, I requested some elaboration on that comment. Still waiting. I gave you twice the explanations, now please read the code to understand what's going on, thanks. >> And I wonder why we need to completely revert his changes. My >> suggestion was to allow both, controlled by user option. > > That's basically what my patch does, it even makes Thierry's preferred > behavior (confirmation before overwriting registers) the default, it > just doesn't use the minibuffer for that. No, you didn't understand what the recent changes provide, "confirmation before overwriting registers" is only one of the features provided. Please read the code and try all the features provided, my guess is that you even didn't try it.=20 > AFAIU the goal of Thierry's patch wasn't to use the minibuffer, that's > an implementation detail, one with problematic consequences. There is no consequence apart one, as I already said, the usage of C-d. =2D-=20 Thierry --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQHHBAEBCgAxFiEEI9twfRN7r3nig/xwDsVtFB0W75MFAmVy7QUTHHRoaWV2b2xA cG9zdGVvLm5ldAAKCRAOxW0UHRbvkyooDACutMbl+nQzRHKbAmC1sET6njJt3MhJ CUberTtkQVvNCHZAdh4DxK/QTxLkrvCLvyQ/npUGnj2dbJxMtkGzYjMWqbTEINjD OJ6vpV0BcRJc9tq5Yz/zkQ8Hs/xARv4OaVHm15jd47R9kLEBeAgeLL+4hSfPwIaM H2lZjikGUq8Aa1Qc2SPM1zEaznl7t+DZ8j390RbdIPJjWIMDsNoPJp+ouDY64Hm3 jQsPUX03fbSa8kQcBcTrZ59ws1cQjz3Dwp1KegyycikFjPmb8qdX2Me6ft35Sk95 oscqsVNOM2xJGY5HQAK9IHYO8PYxaEfp5Ee/8s1J47aQIEo5jdGzB2ukBeQq9djr Xgu5YKxhEtkvWzJFUI7d1B8MdADmoBJMXv39teQMWQZUVNAvs/NP7KR5aEZIyfSj IkG1zj2+tArvaz7XQTGkQDudmic7+NMCU0iaxhRL5XXguDacns5/phIu4/yOY6Ol qYXx90Hlo7Ybr05xWdD1E+JoCpf5bGrpViY= =22dH -----END PGP SIGNATURE----- --=-=-=--