From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Visuwesh Newsgroups: gmane.emacs.bugs Subject: bug#67764: 30.0.50; Opening image in eww no longer works Date: Mon, 11 Dec 2023 17:10:01 +0530 Message-ID: <87sf49ge7i.fsf@gmail.com> References: <87msuhfdjr.fsf@pub.pink> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12449"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67764@debbugs.gnu.org To: john muhl Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 11 12:41:16 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rCeey-00035l-JU for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 11 Dec 2023 12:41:16 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rCeeY-0002aU-K7; Mon, 11 Dec 2023 06:40:50 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rCeeW-0002aF-7n for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 06:40:48 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rCeeV-0005lK-V3 for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 06:40:47 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rCeek-0005Ao-J3 for bug-gnu-emacs@gnu.org; Mon, 11 Dec 2023 06:41:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Visuwesh Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 11 Dec 2023 11:41:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67764 X-GNU-PR-Package: emacs Original-Received: via spool by 67764-submit@debbugs.gnu.org id=B67764.170229483019839 (code B ref 67764); Mon, 11 Dec 2023 11:41:02 +0000 Original-Received: (at 67764) by debbugs.gnu.org; 11 Dec 2023 11:40:30 +0000 Original-Received: from localhost ([127.0.0.1]:52712 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCeeD-00059v-P3 for submit@debbugs.gnu.org; Mon, 11 Dec 2023 06:40:30 -0500 Original-Received: from mail-pj1-x1042.google.com ([2607:f8b0:4864:20::1042]:61780) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rCeeA-00059e-K9 for 67764@debbugs.gnu.org; Mon, 11 Dec 2023 06:40:27 -0500 Original-Received: by mail-pj1-x1042.google.com with SMTP id 98e67ed59e1d1-2866af9d73bso3016587a91.3 for <67764@debbugs.gnu.org>; Mon, 11 Dec 2023 03:40:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1702294806; x=1702899606; darn=debbugs.gnu.org; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=xhw9NKq2qVS4/A2mGSQy92O5vQCtdLIyInQJbjcfyAA=; b=OUXwGT0QGCr/GN1msGO8mjprHuHqI+YV7uLLZ7XAUT1cS4co2alRn+c9ocJQEo+XYW qbDwmGwpswprhBhADE9opWPJi8jEHB9XmAX2PACK5JN+48UAtcnoJtva4BLipFGestgk AA7gbrK+H+KM30JFTtpE45vA4AWH+FxC0ZAlLCkDj/ozS9U12CHbDs7xpNU5T+0WZfg2 90i2HvdQZB2yGyp1wwcJY2+DZ5/JnhJOeTPv6+TMQ5J/8sqGUrOTV5nXm/1XWRs4CdSz f+nXvVTdjaWtCYkEyROF5lEdVMXKdsKE93+Xb/JMWZ0BJiKy0dwhVkSdgYVnvaNhsiDz mDcw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702294806; x=1702899606; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xhw9NKq2qVS4/A2mGSQy92O5vQCtdLIyInQJbjcfyAA=; b=JBLd4h8xWo/mPIc1iOUdMz/uf/XxWE9gesKW6fM1oHb5zwaph8ihaOrOExWhr84k/M /wepZxLq4Fb7fC61PxQ8E39kTeSybUO6RyyiQ5CnLzd/TEfj0RWlimCbVLTjGTVFxPWF Q3sSN65wevWwi3QL1rt6u/CNZfp1fWzauVowPTpv7x1NGSbfxCxOY38rAf/OXhjdQuDa 9kdKZEAfIHQIUB6A3ZLd9rscqHrOF5Y3RCWRZ1++2YjFQB88fkuXW1IRFVE7c6XR6vD3 wocZDFWWTjnisz8zkK1Wli33cHBJtadhkOJ8SpSF7RF2MfqNCeY3dTmi3Qv4YKiMYmg/ Z1HQ== X-Gm-Message-State: AOJu0YwRF4H6+ccsTqy7pp7u+xyAAy6VQWP/33uhHTbMonq/pJdBnHkv zriGWnUZin7z4bB/MJgYbVY= X-Google-Smtp-Source: AGHT+IHghORj70vbytC+Z44fvYqYP1ZcfjOCG69qvmNzGEmX+z+1bJKT6Uun+CdlnBzNCIbYK5NY1Q== X-Received: by 2002:a17:90a:c205:b0:286:6cc1:8674 with SMTP id e5-20020a17090ac20500b002866cc18674mr1567213pjt.89.1702294805787; Mon, 11 Dec 2023 03:40:05 -0800 (PST) Original-Received: from localhost ([49.205.83.111]) by smtp.gmail.com with ESMTPSA id pq18-20020a17090b3d9200b00286dfa09e7asm6763465pjb.24.2023.12.11.03.40.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 Dec 2023 03:40:05 -0800 (PST) In-Reply-To: <87msuhfdjr.fsf@pub.pink> (john muhl via's message of "Mon, 11 Dec 2023 00:26:41 -0600") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275976 Archived-At: --=-=-= Content-Type: text/plain [Monday December 11, 2023] john muhl via "Bug reports for GNU Emacs, the Swiss army knife of text editors" wrote: > In Emacs 29.1 the image opens as expected: > > emacs -Q > M-: (eww "https://www.gnu.org/software/emacs/images/emacs.png") > > On master it fails with "Wrong type argument: stringp, nil". > Bisect says 4254544 is the first bad commit. Recent changes in shr-put-image didn't account for the possible nil value for ALT. Attached patch fixes the issue on my end. --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Fix-shr-put-image-with-nil-value-for-ALT.patch >From f6d3fc0de572a1039e83df0389c1c7efce0ef0cf Mon Sep 17 00:00:00 2001 From: Visuwesh Date: Mon, 11 Dec 2023 17:09:03 +0530 Subject: [PATCH] ; Fix shr-put-image with nil value for ALT * lisp/net/shr.el (shr-put-image): Account for nil value for ALT. (Bug#6774) --- lisp/net/shr.el | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 9f030b4c743..19c52ac8802 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1137,7 +1137,7 @@ shr-put-image (when image ;; The trailing space can confuse shr-insert into not ;; putting any space after inline images. - (setq alt (string-trim alt)) + (setq alt (string-trim (or alt "*"))) ;; When inserting big-ish pictures, put them at the ;; beginning of the line. (let ((inline (shr--inline-image-p image))) -- 2.42.0 --=-=-=--