From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Manuel Giraud via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#67928: 30.0.50; [PATCH] Load GDB history in gud-gdb Date: Wed, 20 Dec 2023 15:00:49 +0100 Message-ID: <87sf3x7z3i.fsf@ledu-giraud.fr> References: <871qbh9h90.fsf@ledu-giraud.fr> <83le9pgg0p.fsf@gnu.org> Reply-To: Manuel Giraud Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28574"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 67928@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Dec 20 15:01:59 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rFx94-0007CJ-PL for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 20 Dec 2023 15:01:58 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rFx8u-0001Po-A9; Wed, 20 Dec 2023 09:01:48 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rFx8H-0001H8-0W for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2023 09:01:21 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rFx86-0002O3-QZ for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2023 09:01:05 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rFx8A-0006Mw-12 for bug-gnu-emacs@gnu.org; Wed, 20 Dec 2023 09:01:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Manuel Giraud Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 20 Dec 2023 14:01:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67928 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 67928-submit@debbugs.gnu.org id=B67928.170308085924176 (code B ref 67928); Wed, 20 Dec 2023 14:01:01 +0000 Original-Received: (at 67928) by debbugs.gnu.org; 20 Dec 2023 14:00:59 +0000 Original-Received: from localhost ([127.0.0.1]:38945 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFx86-0006Gm-P3 for submit@debbugs.gnu.org; Wed, 20 Dec 2023 09:00:59 -0500 Original-Received: from ledu-giraud.fr ([51.159.28.247]:33056) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rFx83-00069V-CS for 67928@debbugs.gnu.org; Wed, 20 Dec 2023 09:00:57 -0500 DKIM-Signature: v=1; a=ed25519-sha256; c=simple/simple; s=ed25519; bh=LvZ/2pxE uWf/cvhaKKIIZTQM4zkIMk6jMi91wTG0E7o=; h=date:references:in-reply-to: subject:cc:to:from; d=ledu-giraud.fr; b=J42IYOVh190bH/iT7Hfc5oAMiyfhE/ KBqHHZWI7s4QW0BuR/LBz0tspOLZiV8cMjx89zJhV5bJpBpKwXnOwuAw== DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; s=rsa; bh=LvZ/2pxEuWf/cvha KKIIZTQM4zkIMk6jMi91wTG0E7o=; h=date:references:in-reply-to:subject: cc:to:from; d=ledu-giraud.fr; b=GogBQEE+36xODaaajk+29Z7GRc43FshDdiiSHe VD+mjBmEIf8RDCHcghALhX8jAQE33pl7TD857K06b5061pS/3RG6DSDt6qJz6wHoB2lyK1 kZ2G6orWVuHD4pjpHb36VWqto3e+CfgbOPuNX2OpETqaIVxHmi1TisxWB6Ag4hUqKhrutx XEx69w4vfuJRVtGwBp8r5ClsqeIM8Z/cZ+82uuZpKyOBcEK075AubN5rTBpaQYX0TD8PUY vABsa0D+5XzH2dbCXB5QcZFTIiqf0NRgC+739HqhO506ysLhU0hSN3DUxZSIQ+f00ume7B tRTwbNJ3oDp96972/k28yVww== Original-Received: from computer (37-174-58-143.coucou-networks.fr [37.174.58.143]) by ledu-giraud.fr (OpenSMTPD) with ESMTPSA id 0db09eb8 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); Wed, 20 Dec 2023 15:00:51 +0100 (CET) In-Reply-To: <83le9pgg0p.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 20 Dec 2023 15:28:06 +0200") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:276569 Archived-At: Eli Zaretskii writes: >> Date: Wed, 20 Dec 2023 13:43:23 +0100 >> From: Manuel Giraud via "Bug reports for GNU Emacs, >> the Swiss army knife of text editors" >> >> 'M-x gud-gdb' does not load GDB history by default. This patch fixes >> this. > > Thanks, but why should we enhance gud-gdb? It is based on a > deprecated GDB feature (annotations), which the GDB developers may > remove some day without any advance warning. It is basically kept in > Emacs as a fallback, for those who for some reasons cannot use gdb-mi. > And gdb-mi already loads the history. > > Are there any reasons for you to use gud-gdb? I have set 'gdb-many-windows' to 't' but sometimes I like the simpler version provided by gud-gdb... But yes, this reason is not sufficient. Before closing this PR, could I modify this patch to, at least, isolate history loading into its own function? -- Manuel Giraud