From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: Permanently fix org versioning breakage during builds? Date: Sun, 24 Dec 2023 18:50:23 +0000 Message-ID: <87sf3r1llc.fsf@localhost> References: <25989.50971.995591.385250@google.com> <87a5q0dc9m.fsf@localhost> <87y1djc1c9.fsf@localhost> <87zfxzdbna.fsf@yahoo.com> <87plyv7oii.fsf@localhost> <8734vr4prv.fsf@localhost> <835y0nd4ut.fsf@gnu.org> <87zfxz35b4.fsf@localhost> <83v88nbgf3.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="13800"; mail-complaints-to="usenet@ciao.gmane.io" Cc: stefankangas@gmail.com, luangruo@yahoo.com, raman@google.com, joaotavora@gmail.com, emacs-devel@gnu.org To: Eli Zaretskii Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Dec 24 19:47:40 2023 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rHTVj-0003NW-LM for ged-emacs-devel@m.gmane-mx.org; Sun, 24 Dec 2023 19:47:39 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rHTVS-0003QW-Tn; Sun, 24 Dec 2023 13:47:22 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHTVR-0003QM-4j for emacs-devel@gnu.org; Sun, 24 Dec 2023 13:47:21 -0500 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rHTVO-0005jY-0b for emacs-devel@gnu.org; Sun, 24 Dec 2023 13:47:20 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id A22CF240103 for ; Sun, 24 Dec 2023 19:47:15 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1703443635; bh=ShVXuE3tEgtz3b9l3V2RrID6HmkXwBuUyaFUxYLL9o4=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version: Content-Transfer-Encoding:From; b=jnNiitzE98SxQdMnDYqwLg/mPacCKoTd4YcH90Tyz/gEL00xfXw/j4CAUZYZ0nb3P sJZDTyAjkayTBqN0BwJhMk5cu2p8aicwszvXyZ3wMzLPr+wmS2pk/2qP3LbmXD+Rya aDfj87FBRCB0RRVzR+AluVo+9SEvzXB9wZ3psnhUddfQxVbz4pfdG9EG92TsGkD/Ua Nm1oZ1zKIveivLQ9Ryv8Kjq6EA685Cglvk1UFX5PQvVR5zeJxZ0fXXFIV9rPLgGt5X m7I9MI0CUgY8xBnWaXDYMkvKFE9604cS75pGL5nSEQ78PQHULPZzSeK0/tuvjFlOsk Eeb1pGBJndjCQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4SyqlR0P7jz9rxD; Sun, 24 Dec 2023 19:47:14 +0100 (CET) In-Reply-To: <83v88nbgf3.fsf@gnu.org> Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -53 X-Spam_score: -5.4 X-Spam_bar: ----- X-Spam_report: (-5.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H5=-1, RCVD_IN_MSPIKE_WL=-0.01, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:314178 Archived-At: Eli Zaretskii writes: >> The main problem is that with org-assert-version, "from time to time" >> becomes more frequent as the breakage is guaranteed every time a new >> version of Org is installed into Emacs tree. > > If org-assert-version is the source of breakage, then that's not the > breakage I was talking about. I was talking about breakage due to > changes in macros that were the motivation for you to introduce > org-assert-version in the first place. > > IOW, instead of _inducing_ a breakage via org-assert-version, you > should let stuff break by itself, when an incompatible change is made > in one of the macros which org-assert-version protects. Yep. That's what I've done now. `org-assert-version' now throws a warning instead of error: https://git.savannah.gnu.org/cgit/emacs/org-mode.git/commit/?id=3Daf1821673 The remaining problem (maybe) is that even the warning may not be desired: (from Po Lu's messages) >>> Thanks, but ideally Emacs should not display warnings loading >>> built-in files And I am still interested to discuss further on the alternative ways to address the problem with macros _and also_ the problem with multiple Org versions being loaded. For macros, Jo=C3=A3o T=C3=A1vora suggested wrapping them into a function c= all and then use the function call + (lambda () ...) instead of macros. Although I am not sure how it will affect byte- and native-compilation. And it feels like very awkward workaround that should not be necessary. For mixed versions, no suggestions were surfaced yet in this discussion. (Although, I am still trying to make previous ideas with require-with-shadowcheck work in a local WIP feature branch). --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at