From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms8.migadu.com with LMTPS id qBk0I+p6y2WwSQEAe85BDQ:P1 (envelope-from ) for ; Tue, 13 Feb 2024 15:21:30 +0100 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id qBk0I+p6y2WwSQEAe85BDQ (envelope-from ) for ; Tue, 13 Feb 2024 15:21:30 +0100 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Js6fJsxL; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1707834090; a=rsa-sha256; cv=none; b=fA5B4cfvXAFWPHHh51UIBpJlHfWzzefjiO3l7J9ssb12Ro8teGFK9JRh2C8YiuuhqaW0zz YzZheEAt2vDBQiENUD5sOFaKdisHilWdAALObNM9otqWKavDb1ZtFJwsbk6YnWheKkuSQt 39J1Yp+A4oWwEHh4jHCn8U/gTChORSbBdxHmXixK8i0dVX/FjqxC5GugA/wZN/WjNO1LmW HnbusmHhuYFkhi78Jv6P/e1Yd/F0X6hOfzOsrP3hMWbp8O+XEfZI4nYjYe72hY+mTvRVuQ 5k6Uuo+OoTo7swZzuylnREpLHYQxtXceJlCh6/5/zS+L1vdJu7FWNfz/6cW4Mg== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=posteo.net header.s=2017 header.b=Js6fJsxL; dmarc=pass (policy=none) header.from=posteo.net; spf=pass (aspmx1.migadu.com: domain of "emacs-orgmode-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="emacs-orgmode-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1707834090; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=niPD97yQuHTR6vkOXBBYa8oFCDAUNPUP0rq57GeYNC4=; b=r0MDy7BTpVOKRSIRB5uPQRqM1DPMmyZ6wh/9K/EDkpbj8hyW3DMzEyoSSNmn7/0azrkKVw HC9hsxhOk92oNJwQH0elVdpl34vAprNloE3FC1KTi1H/j/ZaPxwXieZvImoTVY7JcLBM2s wMIGxg+XMH6EsT0mG2A0x+io1r3rXxCoTWSo7PoUV8xg0pvzKW40KsRuuTS9B6b9o3dBR3 yfHfb7dfO/3VyKS4lBahu6xIZkMMfN5++9pHDybe3R+NQ5HhWE/P6h/JK4vpNEeRgGP/tp U+zksYZ/xfzmfCm5wBA3RL1vhzHto8PMELHWFw9JeKCdp3H0cluD6xU8bFZlxw== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 2F02A6C2E8 for ; Tue, 13 Feb 2024 15:21:30 +0100 (CET) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rZteL-0001LG-S7; Tue, 13 Feb 2024 09:20:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZteK-0001L6-7H for emacs-orgmode@gnu.org; Tue, 13 Feb 2024 09:20:40 -0500 Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rZteH-0004WS-Ci for emacs-orgmode@gnu.org; Tue, 13 Feb 2024 09:20:39 -0500 Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 44EB9240105 for ; Tue, 13 Feb 2024 15:20:34 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1707834034; bh=ps64EdPxxY+wiZPI2svrGwX8LIixut+2nuW0yIaVpEA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=Js6fJsxLtyYbtmyqh0Aci5iOwDg4W3PFYvdThohJeKsG1fwiTep4+uPURPSD0CVVn YOF5IGYv/pW4OCBk4oOD+qZlyEV6XOZXl/u3dxQRpXxaT8ruG4dgqQ41UhkBpAz4xv buNAw4zF3x7JCoGMXSrPvEH79xug4fypECaSJroazfcXgOeK1SDNq7iR33gz2xK3Ef PSZyKrY1d36qS0BTUC8k/qKhkKVlTDVldui1weQ30QC/HZdwJ2sazvclUaaGvpszqf SphEctsa9+WSsmHDSgt5LDzX/GK4qq78HrIp+3P/2u3pM63iG/AvftvK2+51SRS7D4 wk+u9qXL8+RUQ== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4TZ3Q92bJgz6tyB; Tue, 13 Feb 2024 15:20:33 +0100 (CET) From: Ihor Radchenko To: Tim Ruffing Cc: emacs-orgmode@gnu.org Subject: Re: [PATCH] org-agenda: Make sure skipping warning/delay days never increases their number In-Reply-To: References: Date: Tue, 13 Feb 2024 14:24:07 +0000 Message-ID: <87sf1wl9x4.fsf@localhost> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=185.67.36.66; envelope-from=yantar92@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-orgmode@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "General discussions about Org-mode." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-orgmode-bounces+larch=yhetil.org@gnu.org Sender: emacs-orgmode-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Scanner: mx10.migadu.com X-Spam-Score: -7.51 X-Migadu-Queue-Id: 2F02A6C2E8 X-Migadu-Spam-Score: -7.51 X-TUID: VK7+UW3YXxgP Tim Ruffing writes: > The attached patch fixes the following bug: > > * Have a scheduled item that has also has a deadline with a cusom > prewarning cookie, e.g. <... -3d>. > * Set `org-agenda-skip-deadline-prewarning-if-scheduled' to 7 > > Then in the agenda, the item is shown already 7 days before the > deadline (instead of 3). Judging from their name and documentation, the > "skip" variables `org-agenda-skip-deadline-prewarning-if-scheduled' and > `org-agenda-skip-scheduled-delay-if-deadline` should only ever skip > items in the agenda. In other words, they should only shorten the > prewarning or delay period, but never extend it. Thanks! May you also add a test? > -(defun org-get-wdays (ts &optional delay zero-delay) > +(defun org-get-wdays (ts &optional delay) Please do not remove arguments from the public functions. This may break code outside Org mode. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at