Re: master 5bba1b95b80: Further adjustments for restoring killed buffer windows (Bug#68235)

Re: master 5bba1b95b80: Further adjustments for restoring killed buffer windows (Bug#68235)

[Michael Heerdegen]

Martin Rudalics via Mailing list for Emacs changes <emacs-diffs@gnu.org>
writes:

> +If the value of this variable is a function, that function should take
> +three arguments.  The first argument specifies the frame whose windows
> +have been restored.  The third argument is either the constant
> +@code{configuration} if the windows are restored by
> +@code{set-window-configuration} or the constant @code{state} if the
> +windows are restored by @code{window-state-put}.

Martin, can we maybe say "symbol" instead of "constant" here?  "Symbol"
is more precise, "constant" is, well, any passed value is constant,
and here the symbol's name is "configuration" which could even mean
"window configuration", so the interpretation of the text is ambiguous.


TIA,

Michael.

Re: master 5bba1b95b80: Further adjustments for restoring killed buffer windows (Bug#68235)

[martin rudalics]

> Martin, can we maybe say "symbol" instead of "constant" here?  "Symbol"
> is more precise, "constant" is, well, any passed value is constant,
> and here the symbol's name is "configuration" which could even mean
> "window configuration", so the interpretation of the text is ambiguous.

Should be fixed now.

Thanks for checking, martin

Re: master 5bba1b95b80: Further adjustments for restoring killed buffer windows (Bug#68235)

[Michael Heerdegen]

martin rudalics <rudalics@gmx.at> writes:

> Should be fixed now.

LGTM, thank you very much.

Michael.