From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Po Lu via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#62994: [PATCH v7] Add support for colored and styled underlines on tty frames Date: Mon, 22 Apr 2024 08:44:15 +0800 Message-ID: <87sezegra8.fsf@yahoo.com> References: <87pm7x5mxc.fsf@kisara.moe> <87sezeitkj.fsf@kisara.moe> Reply-To: Po Lu Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18759"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 62994@debbugs.gnu.org To: Mohsin Kaleem Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Apr 22 02:46:20 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ryhp5-0004gO-Ie for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 22 Apr 2024 02:46:19 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ryhom-0006aK-00; Sun, 21 Apr 2024 20:46:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ryhol-0006Zw-3P for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2024 20:45:59 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ryhok-0007oF-Ri for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2024 20:45:58 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ryhoz-0006Tv-Hu for bug-gnu-emacs@gnu.org; Sun, 21 Apr 2024 20:46:13 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Po Lu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Apr 2024 00:46:12 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 62994 X-GNU-PR-Package: emacs Original-Received: via spool by 62994-submit@debbugs.gnu.org id=B62994.171374671624513 (code B ref 62994); Mon, 22 Apr 2024 00:46:12 +0000 Original-Received: (at 62994) by debbugs.gnu.org; 22 Apr 2024 00:45:16 +0000 Original-Received: from localhost ([127.0.0.1]:45284 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryhnx-0006MP-Nc for submit@debbugs.gnu.org; Sun, 21 Apr 2024 20:45:14 -0400 Original-Received: from sonic304-22.consmr.mail.ne1.yahoo.com ([66.163.191.148]:43880) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ryhne-0006Is-4L for 62994@debbugs.gnu.org; Sun, 21 Apr 2024 20:45:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1713746667; bh=y0kL73LYvrTRbY97WUPAGORLS4kksGvhwuRZsYpBSuY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From:Subject:Reply-To; b=hVt19zO/PWaUOsipY1zNVe/hQ48+VYSA95UCvT9GYPSn1XW7n2+mzPh3ovFannm8XjAxxEZ0amG1H/uKhTW5lANpHR/4hyNvEwqeukP23NkeTpQFcQePTnRDHIoorrLuIsSlrezQ/mIM3NuueW39I9YIewDxrHzNpf02oMCyJXyg2gohXWTmqRq/wCS7xVgJRt13nBq6bpjZ9d4TFNEMrqXHzUubn/ic4xc9Kx2IvM/5fNVpcrwdXHZ50VvSxGxkpNPwlg2eh2e0QAU8+7C0lupIWq2y+udZ0cOuPm33+zm2L5OFelc/5P1jdgX2bAhqiadZSgi80fdSH89jqJYMGQ== X-SONIC-DKIM-SIGN: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1713746667; bh=DlJVyZi7tWIe8Iour/4G+0oJK1NdWnMUe9xZLHUevLz=; h=X-Sonic-MF:From:To:Subject:Date:From:Subject; b=Il+Xh1ZIN7U/CKJpMxVRzXWBlNB1sDT7YQD70GLfQpl02cOeAQkE9KY3qlMevthNEdRC3j8+g0uFLAT/KNGEychpWbu7/FSXzStwFXAS4e13PXDJuZm/ZMHtVC4ry/nDQDcySGFVhGOYFBNMh72Z0gZny0RyHeaQytYJij/wj5+IlKKpFjbI7iA56XeHexH/GnmWGP4UPd0OgsVYGFjBFKtSXQKenDZjOYKF6KvmSSQnJYtwKpHCmvT2wXztc11ZR/1mmlcNOoi/8DJz3BEALPVa/6tuU6QlNZEZrKLwYz9MRNYBcBa0NCrCYKy7l225DCiAWbaEEjqd5H+XWwG7BQ== X-YMail-OSG: jiucqlYVM1lzHt6SF_Ff.mc5CScoO43eYO6frJgVvNtpqAIFmcwVHkWhQJY7glo MQpNfR0A95qiLbaifFiR9QdixyNWQAsAk6zwPjjyA9ipjYwZ0mpU_yZa5NW1CqTIY90hqQ2J5M1U eY2RSze79MkTbcsSaUbH66W0Ky9_QLmPb5awWByb5WN93SB8QtJ_dk984DwCARMYsklSHbafxrvq j11BGzKPlrIpgt9wcCIR8G.K1RvtqJQaTMtkJXMNxbqG5ZLSzN4AbinMCc9fmnzCv6nit0zd8Fxs QhGIo4AqHPcSjyUmMi5aBTzfjt2SA.pV59zrAl2mzkq.SgfyADzZL_m21MPKDQNGwA9W9UoK.1Z9 vXj749ub0O4u5q7onKBxFZUPnAVYqJKGEodugWbNd41vMcjmgHDBkkxurCSXGeImlxY7ifqyA9NF kBHsPRsbO_K1b0cruKGh7CNas.WYyBG5s0wQ1BJe.VVvrrjP6G3mrMeCOpsawoxV2ahPxqyqsQW_ 2J7PImlHjRKdXjpXpTX.Huxiq5OZw.6h8KzRXk65cCXgEBxFCFROL6zXGyBPRNp47T8vMKp6qAPP 5cB.Xz9xE0R0uy19KYQeblAE7MwLtryA.CUolYh4Lb.jmzA9v8AJxVpf_Lm8v3sXobqUhP3M4FVy HE1_FVGCAqXVOWcNnKsIxoNHSkCBf5rUiXuyror5v9aRjikWiKB91GBesQzNbUh3YSKCHwJLUqzt S64THpqF7CS8aorzYPMFx1uDrFBWiFH9u1viHhHTsMBthZG1W.NNcJG9mo0MWPOJQuLj74fKB3qY DVhdp1FENBxY6UG6104gyAA4O58UgbZF4WO4wmjY2_ X-Sonic-MF: X-Sonic-ID: da05ce82-9f36-4767-8983-831cb996be14 Original-Received: from sonic.gate.mail.ne1.yahoo.com by sonic304.consmr.mail.ne1.yahoo.com with HTTP; Mon, 22 Apr 2024 00:44:27 +0000 Original-Received: by hermes--production-sg3-6f9f87bd85-np5nc (Yahoo Inc. Hermes SMTP Server) with ESMTPA ID f5152b0bafc65ccf587b76386b6c7081; Mon, 22 Apr 2024 00:44:21 +0000 (UTC) In-Reply-To: <87sezeitkj.fsf@kisara.moe> (Mohsin Kaleem's message of "Sun, 21 Apr 2024 17:11:56 +0100") X-Mailer: WebService/1.1.22256 mail.backend.jedi.jws.acl:role.jedi.acl.token.atz.jws.hermes.yahoo X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:283785 Archived-At: Mohsin Kaleem writes: > CLOSES bug#62994 This is not the proper manner of specifying bug numbers relating to a change. Place it immediately after the most relevant (in your judgment) item in the log entry, e.g.: * src/foo.c (pertinent_function): Adjust for something. (bug#62994) > * src/xterm.c (x_draw_glyph_string): Updated to use renamed > FACE_UNDERLINE_SINGLE and FACE_UNDERLINE_WAVE face_underline_type > enumerations. This change should be accompanied by like updates to *_draw_glyph_string and related functions in the remaining terminal backends. Last but not least, are there terminal emulators besides Kitty that support these underline styles?