From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eric Abrahamsen Newsgroups: gmane.emacs.devel Subject: Re: master 1601c5a518d: Gnus: Add back end for Atom feeds (nnatom) Date: Mon, 29 Apr 2024 13:12:55 -0700 Message-ID: <87sez49bco.fsf@ericabrahamsen.net> References: <171389641522.15334.4055859790974801392@vcs2.savannah.gnu.org> <20240423182018.97FA3C12C33@vcs2.savannah.gnu.org> <87a5ldn4fu.fsf@gmx.de> <871q6p2z5r.fsf@ericabrahamsen.net> <8734r5avt6.fsf@ericabrahamsen.net> <877cggjf2q.fsf@gmx.de> <70BFC2F4-E3F5-4515-9FEE-F293BDE1D3D3@gmail.com> <87a5lc57zn.fsf@dsemy.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="4681"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , Michael Albinus , emacs-devel@gnu.org To: Daniel Semyonov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Mon Apr 29 22:13:20 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s1XNI-00013P-An for ged-emacs-devel@m.gmane-mx.org; Mon, 29 Apr 2024 22:13:20 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s1XN6-0007CP-NM; Mon, 29 Apr 2024 16:13:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1XN5-0007Bx-Ph for emacs-devel@gnu.org; Mon, 29 Apr 2024 16:13:07 -0400 Original-Received: from mail.ericabrahamsen.net ([52.70.2.18]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s1XN4-0006vw-7u for emacs-devel@gnu.org; Mon, 29 Apr 2024 16:13:07 -0400 Original-Received: from localhost (71-212-21-65.tukw.qwest.net [71.212.21.65]) (Authenticated sender: eric@ericabrahamsen.net) by mail.ericabrahamsen.net (Postfix) with ESMTPSA id E738EFA12D; Mon, 29 Apr 2024 20:12:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericabrahamsen.net; s=mail; t=1714421577; bh=aPxlMkielQLaTV04ZHqMYRtkWNOL+2kS9fYYTNMoUSo=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=yi0sEnsuW9vI8ventoflpX7puvZyYF3/W8lOlE+ytQEdj4s+eduDc56Ewt8vm+FVc l6xUBk5m8O8VkZ0tATDnhggnuZoNIAQ40ZGarlU1QH4BoMNnuL2w9E1cH1BptRx4zd ZwQJrPkpskG0WhCtVM7eP1/23ZP1WUPOq4Ibfr9k= In-Reply-To: <87a5lc57zn.fsf@dsemy.com> (Daniel Semyonov's message of "Mon, 29 Apr 2024 21:39:08 +0300") Received-SPF: pass client-ip=52.70.2.18; envelope-from=eric@ericabrahamsen.net; helo=mail.ericabrahamsen.net X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:318385 Archived-At: On 04/29/24 21:39 PM, Daniel Semyonov wrote: >>>>>> Mattias Engdeg=C3=A5rd writes: > > > 29 apr. 2024 kl. 18.42 skrev Michael Albinus : > >> Eric Abrahamsen writes: > >>=20 > >>> This is still failing the tests, and I can't see why, I suspect t= he > >>> reason is in the "... ..." below: > > > No, you should ignore that and look at the text > > >> The following options might have problems: > >> variable: gnus-valid-select-methods > >> value: (...) > >> type: (...) > > > > that precedes the ERT error. In this case, it appears that the > > top-level list includes an element > > > ("nnatom" address) > > > which doesn't match the declared type which requires that the > > string be followed by one of {post, mail, none, post-mail}. > > > This should be changed to `("nnatom" none address)', and the docstring > should probably be changed to clarify this too. That's what I've changed it to, and it was still failing, that's why I was trying to dig more information out of the failure. HOWEVER. Moments ago I thought to look at nnatom.el itself, and this bit at the bottom: (gnus-declare-backend (symbol-name nnatom-backend) 'address) Also ends up setting gnus-valid-select-methods, and needs the equivalent change: (gnus-declare-backend (symbol-name nnatom-backend) 'none 'address) > Honestly though, I don't understand why this is a user option in the > first place, it only seems useful if you're implementing a new backend > (in which case, you're probably using `gnus-declare-backend', which > modifies `gnus-valid-select-methods' without checking the value anyway). And here you mention that exact fact :) I agree it doesn't make much sense, it doesn't do anything for the user. I wonder if `gnus-declare-backend' was originally just meant to be used by out-of-tree backend libraries. Anyway, it's redundant, but no great harm done, and the tests pass. Eric