From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: MPS: profiler Date: Fri, 21 Jun 2024 07:36:42 +0000 Message-ID: <87sex6ags5.fsf@localhost> References: <87v823xvq1.fsf@localhost> <86cyobmmhc.fsf@gnu.org> <87r0crxung.fsf@localhost> <87le2zxsqx.fsf@localhost> <8634p6n7jd.fsf@gnu.org> <87tthm3gq2.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="3990"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Gerd =?utf-8?Q?M=C3=B6llmann?= , Eli Zaretskii , emacs-devel@gnu.org To: Helmut Eller Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Jun 21 09:35:31 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sKYnz-0000nu-7x for ged-emacs-devel@m.gmane-mx.org; Fri, 21 Jun 2024 09:35:31 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sKYnZ-0000lu-3S; Fri, 21 Jun 2024 03:35:05 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKYnX-0000lR-FE for emacs-devel@gnu.org; Fri, 21 Jun 2024 03:35:03 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sKYnV-0002Cu-BZ for emacs-devel@gnu.org; Fri, 21 Jun 2024 03:35:03 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 36CAD240027 for ; Fri, 21 Jun 2024 09:34:59 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1718955299; bh=VC3TqfbcWB8wD32/5ROVFaDJkLOp0TrQ8b5iGD5BKVQ=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: From; b=bRgI7QsL6HF22Rm6Vl6A2DTKreBskSMox6uSvHsXXJGbto+LdKlt7qSs5oJT0dne4 fe566kKUON56IxgKOgF5VwFuvWmElm77ri7FInZSS/R2YEK1/HxmLQ68ulLW/egWVe VW9KLOV5VrTAmYi50NZdgWvrOKF2WAYObXTQZ3GRR394f9OdeBzl/nOTfrEjGrVD1N wXGEDSCd9Pgvg8Bn46yLfbhQUfee7CEc9FO737cfzKfyDJZUDYeedPZdKVAfInGt75 p8KwDZzIAAesxRbPblVNO7tzI5WHh6gmOFNiu6QBQLjpJS7V8eYlCiyiFSfG0ZC0me LqcrdzPlc6OpQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4W58Jf2Mynz6tlh; Fri, 21 Jun 2024 09:34:58 +0200 (CEST) In-Reply-To: <87tthm3gq2.fsf@gmail.com> Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320367 Archived-At: Helmut Eller writes: >> I'd guess that just "touching" Lisp objects in the SIGPROF handler can >> be problematic because these objects themselves can be behind a barrier, >> either the same that MPS is currently working on when it got interrupted >> or another one. > > Perhaps dflt_scan should block SIGPROF while it is running. Or perhaps > dflt_scan should set some global flag while it running so that the > profiler knows that it's too dangerous to touch anything. Any better > ideas? May you infer from the backtrace whether MPS "freezes" everything at the time when segfault triggers? If it does, such freezes should probably be recorded by the profiler and accumulated in "GC" entry in the profiler report, as we do it on master. Otherwise, profiler will be missing some data. -- Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at