Re: Start of Emacs 30 release cycle

[Robert Pluim <rpluim@gmail.com>]

>>>>> On Tue, 25 Jun 2024 12:41:02 +0200, Stephen Berman <stephen.berman@gmx.net> said:
    Stephen> Yes, indeed.  Is the attached complete patch ready to install in
    Stephen> emacs-30?

Minor comments below (although globally Iʼd say youʼre overriding the
.dir-locals.el setting for `indent-tabs-mode', which is why the diffs
look funny)

    Stephen> diff --git a/doc/misc/widget.texi b/doc/misc/widget.texi
    Stephen> index 2e378e86fc7..8769d9c6191 100644
    Stephen> --- a/doc/misc/widget.texi
    Stephen> +++ b/doc/misc/widget.texi
    Stephen> @@ -3287,6 +3287,16 @@ Customization
    Stephen>  Face used for inactive widgets.
    Stephen>  @end deffn

    Stephen> +@deffn Face widget-unselected
    Stephen> +Face used for unselected widgets.  This face is also used on the text
    Stephen> +labels of radio-button and checkbox widgets.
    Stephen> +
    Stephen> +The default value inherits @code{widget-inactive} face.  If you want to

'inherits from the'

    Stephen> +visually distinguish the labels of unselected active radio-button or
    Stephen> +checkbox widgets from the labels of unselected inactive widgets,
    Stephen> +customize this face to a non-default value.
    Stephen> +@end deffn
    Stephen> +
    Stephen>  @defopt widget-mouse-face
    Stephen>  Face used for highlighting a button when the mouse pointer moves
    Stephen>  across it.
    Stephen> diff --git a/etc/NEWS b/etc/NEWS
    Stephen> index d8fa92eb71e..841eb7c9c35 100644
    Stephen> --- a/etc/NEWS
    Stephen> +++ b/etc/NEWS
    Stephen> @@ -1906,6 +1906,12 @@ options of GNU 'ls'.
    Stephen>  ** Widget

    Stephen>  +++
    Stephen> +*** New face 'widget-unselected'.
    Stephen> +Customize this face to a non-default value to visually distinguish the
    Stephen> +labels of unselected active radio-button or checkbox widgets from the
    Stephen> +labels of unselected inactive widgets (the default value inherits

'inherits from the'

    Stephen> +'widget-inactive' face).
    Stephen> +
    Stephen>  *** New user option 'widget-skip-inactive'.
    Stephen>  If non-nil, moving point forward or backward between widgets by typing
    Stephen>  'TAB' or 'S-TAB' skips over inactive widgets.  The default value is nil.
    Stephen> diff --git a/lisp/wid-edit.el b/lisp/wid-edit.el
    Stephen> index 3b467434d29..c86e82f5852 100644
    Stephen> --- a/lisp/wid-edit.el
    Stephen> +++ b/lisp/wid-edit.el
    Stephen> @@ -568,6 +568,29 @@ widget-specify-active
    Stephen>        (delete-overlay inactive)
    Stephen>        (widget-put widget :inactive nil))))

    Stephen> +(defface widget-unselected
    Stephen> +  '((t :inherit widget-inactive))
    Stephen> +  "Face used for unselected widgets."
    Stephen> +  :group 'widget-faces
    Stephen> +  :version "30.1")
    Stephen> +
    Stephen> +(defun widget-specify-unselected (widget from to)
    Stephen> +  "Fontify WIDGET as unselected (not chosen)."

I think the "(not chosen)" bit is redundant.

    Stephen> +  (let ((overlay (make-overlay from to nil t nil)))
    Stephen> +    (overlay-put overlay 'face 'widget-unselected)
    Stephen> +    (overlay-put overlay 'evaporate t)
    Stephen> +    ;; The overlay priority here should be lower than the priority in
    Stephen> +    ;; `widget-specify-active' (bug#69942).
    Stephen> +    (overlay-put overlay 'priority 90)
    Stephen> +    (widget-put widget :unselected overlay)))
    Stephen> +
    Stephen> +(defun widget-specify-selected (widget)
    Stephen> +  "Remove fontification of WIDGET as unselected (not chosen)."

And here as well.

Robert
--