From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Ihor Radchenko Newsgroups: gmane.emacs.devel Subject: Re: MPS: dangling markers Date: Sat, 29 Jun 2024 14:34:51 +0000 Message-ID: <87sewvg6lw.fsf@localhost> References: <87v81u85hv.fsf@localhost> <87frsx81m2.fsf@localhost> <87cyo180y2.fsf@localhost> <874j9d7zqe.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="37049"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Stefan Monnier , emacs-devel@gnu.org, Eli Zaretskii , eller.helmut@gmail.com To: Gerd =?utf-8?Q?M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Jun 29 16:33:44 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1sNZ96-0009SA-1p for ged-emacs-devel@m.gmane-mx.org; Sat, 29 Jun 2024 16:33:44 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1sNZ8h-0000wV-NC; Sat, 29 Jun 2024 10:33:19 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNZ8g-0000w8-5E for emacs-devel@gnu.org; Sat, 29 Jun 2024 10:33:18 -0400 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1sNZ8e-0000Nj-8K for emacs-devel@gnu.org; Sat, 29 Jun 2024 10:33:17 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 78ABD240027 for ; Sat, 29 Jun 2024 16:33:13 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1719671593; bh=2yyHNDVxBPQVm5CkZUsQ/T/ptzdo5O25W43w4UCIj3M=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type: Content-Transfer-Encoding:From; b=SIcp42bZBW8uy4NfjerJQsacnApB72pTdKqbgW2bQr23//8lE/cm9CVT4xPAtUA5a b2doMtd6gbG5O8Rp3KqHZDXY6At6UpYHlBcqt8+QywMOG5YHiW/6fjmhBZkB+Yzy2H FyMZoZvOzv470eCFoHuD8Z2rXnNYh3GNdo4iNaP4zch5y2UjGGwY65tSLM9QmTTcZh AawKaNUOoT9QY4TLoEAS/RK+auMUm3YLsF58JV5NY0/6hh8x3pA3KuY2lHsNgTlOm7 eXMvCM6fboT6Vfxk6UKu6Jt5+KLYae3w1+KTN4i1C9aHbv4qRbsn0EvUiSr9T5LkJB PmP4bwOdjM3RQ== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4WBFCX13Yjz6tmv; Sat, 29 Jun 2024 16:33:12 +0200 (CEST) In-Reply-To: Received-SPF: pass client-ip=185.67.36.65; envelope-from=yantar92@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:320853 Archived-At: Gerd M=C3=B6llmann writes: > Ihor Radchenko writes: > >> Gerd M=C3=B6llmann writes: >> >>>> But when we have for (...) for (...) break;, the break will only stop >>>> the inner loop, no? >>> >>> Oh, that's right. Didn't think of that... Shit. Emacs should use C++ so >>> that one can write real iterators :-(. > > I've pushed something. Please give it a try. Thanks! The performance is much better now, although still a few times slower compared to master. I did a small perf benchmark generating large agendas multiple times, and got the following output: 36.34% emacs emacs [.= ] igc_remove_marker 35.77% emacs emacs [.= ] igc_add_marker 3.41% emacs emacs [.= ] buf_charpos_to_bytepos 2.12% emacs emacs [.= ] re_search_2 1.60% emacs emacs [.= ] re_match_2_internal 1.13% emacs emacs [.= ] exec_byte_code 0.95% emacs emacs [.= ] buf_bytepos_to_charpos I guess O(N) is not all the fast, after all :) (assoc-string "PVEC_MARKER" (igc-info)) gives ~200-600k markers with my set= up. --=20 Ihor Radchenko // yantar92, Org mode contributor, Learn more about Org mode at . Support Org development at , or support my work at