From: Joseph Turner via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org>
To: Juri Linkov <juri@linkov.net>
Cc: adam@alphapapa.net, 71883@debbugs.gnu.org,
Eli Zaretskii <eliz@gnu.org>,
shipmints@gmail.com
Subject: bug#71883: [PATCH] Fix tab-bar-auto-width with customized tab-bar-tab-face-function
Date: Tue, 20 Aug 2024 00:11:33 -0700 [thread overview]
Message-ID: <87seuzekii.fsf@breatheoutbreathe.in> (raw)
In-Reply-To: <86jzgb4ttl.fsf@mail.linkov.net> (Juri Linkov's message of "Tue, 20 Aug 2024 09:40:38 +0300")
Juri Linkov <juri@linkov.net> writes:
>>>>>> +(defun tab-bar-auto-width-predicate-default (item)
>>>>>> + "Accepts tab ITEM and returns non-nil for tabs and tab groups."
>>>>>> + (string-match-p
>>>>>> + ;; (rx bos (or "current-tab" "current-group" "tab-" "group-"))
>>>>>> + "\\`\\(?:current-\\(?:group\\|tab\\)\\|\\(?:group\\|tab\\)-\\)"
>>>>>> + (symbol-name (nth 0 item))))
>>>>>
>>>>> In this part please remove the current group from the default implementation,
>>>>> because it looks too ugly, and it was not resized before this change, since
>>>>> tab-bar-auto-width-faces didn't contain the tab-bar-tab-group-current face.
>>>>
>>>> If the simpler change offers feature parity, that sounds good to me.
>>>
>>> Thanks for the patch, I pushed it to master, then ameliorated it
>>> to keep backwards-compatibility for users customized these faces,
>>> but by default using your predicate on symbols.
>>
>> Thank you! How would users have customized tab-bar-auto-width-faces
>> since it was not a defcustom?
>
> I meant that customized it without using the Customization UI.
> Maybe a better word would be "configured", e.g. with 'setopt'
> ('setopt' supports non-customizable plain variables as
> 'setq' does, unlike 'set-variable' that refuses to change them).
I see. Thank you!
prev parent reply other threads:[~2024-08-20 7:11 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-01 20:42 bug#71883: [PATCH] Fix tab-bar-auto-width with customized tab-bar-tab-face-function Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-02 6:55 ` Juri Linkov
2024-07-02 13:42 ` Ship Mints
2024-07-02 16:25 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-02 17:34 ` Juri Linkov
2024-07-02 23:10 ` Adam Porter
2024-07-03 6:27 ` Juri Linkov
2024-07-03 19:50 ` Adam Porter
2024-07-04 17:57 ` Juri Linkov
2024-07-04 21:11 ` Ship Mints
2024-07-16 5:12 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-17 11:18 ` Eli Zaretskii
2024-07-19 6:42 ` Juri Linkov
2024-07-25 18:11 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-25 18:18 ` Juri Linkov
2024-07-25 18:52 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-07-25 19:09 ` Eli Zaretskii
2024-07-25 23:00 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-06 6:59 ` Juri Linkov
2024-08-09 12:15 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-09 12:25 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-19 16:57 ` Juri Linkov
2024-08-20 1:49 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-08-20 6:40 ` Juri Linkov
2024-08-20 7:11 ` Joseph Turner via Bug reports for GNU Emacs, the Swiss army knife of text editors [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87seuzekii.fsf@breatheoutbreathe.in \
--to=bug-gnu-emacs@gnu.org \
--cc=71883@debbugs.gnu.org \
--cc=adam@alphapapa.net \
--cc=eliz@gnu.org \
--cc=joseph@breatheoutbreathe.in \
--cc=juri@linkov.net \
--cc=shipmints@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.