From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel Subject: Re: Reconsider defaults for use-package-vc-prefer-newest Date: Sat, 21 Sep 2024 15:59:46 +0000 Message-ID: <87settknf1.fsf@posteo.net> References: <87wmj7dftf.fsf@posteo.net> <87setvxyt6.fsf@gmail.com> <87jzf7o13b.fsf@posteo.net> <87msk3jr0u.fsf@gmail.com> <87setum5do.fsf@posteo.net> <87msk1520e.fsf@gmail.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="5905"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Martin =?utf-8?Q?Edstr=C3=B6m?= , "emacs-devel" , Tony Zorman To: Suhail Singh Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Sep 21 18:00:41 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ss2XI-0001Ou-M4 for ged-emacs-devel@m.gmane-mx.org; Sat, 21 Sep 2024 18:00:40 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ss2Wa-0006kQ-9Z; Sat, 21 Sep 2024 11:59:56 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ss2WY-0006kE-MQ for emacs-devel@gnu.org; Sat, 21 Sep 2024 11:59:54 -0400 Original-Received: from mout02.posteo.de ([185.67.36.66]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ss2WW-0003Yh-Ox for emacs-devel@gnu.org; Sat, 21 Sep 2024 11:59:54 -0400 Original-Received: from submission (posteo.de [185.67.36.169]) by mout02.posteo.de (Postfix) with ESMTPS id 50FA0240101 for ; Sat, 21 Sep 2024 17:59:47 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1726934387; bh=BcwVAJ0jyHuoXEkh82DJ39vT2bpu/mv/qvl/7yeWB6A=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=O1M1SUI0Rc0d7F1E3EBG6l2T66N/+GIy3GP9Z6JoEcU0nLRvKAlz49YKMYi+wXmwO k79GJmhaw974jF2Mf4+Rf1Ph6K8w3P5Yl9QSjBlq7ZwoMY1mQAkDmBREB/qomEWvJF PXEAPUzQKB+XLYJvfRPRNhdjJ55Qv54k23brnZ3mbMpEAxOIUYyeR7yPMD3TCVGv8O HB3ciYx0OHAiVrMAIWmQAvkobxPZu2HZTUydmXqK9qTuR3SpCOqrpbM7ccxRhX0Jl1 +osGKtak5bbzo54fDhGmssuh6hxGjOOHUcpmfX8CnK+MGUwJMPv1O1AmHW0xEYnYPJ GLh9DAM/oNNcg== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4X9v8f6n2dz9rxB; Sat, 21 Sep 2024 17:59:46 +0200 (CEST) In-Reply-To: <87msk1520e.fsf@gmail.com> (Suhail Singh's message of "Fri, 20 Sep 2024 19:38:57 -0400") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.66; envelope-from=philipk@posteo.net; helo=mout02.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:323898 Archived-At: Suhail Singh writes: > Philip Kaludercic writes: > >> I wonder if indicating a "commit mismatch" for remote packages might >> be interesting (we explicitly don't want this for local packages, >> e.g. packages installed via package-vc). > > Depending on the logic of "commit mismatch" detection, that may be > sufficient. Could you describe what you had in mind? In your case/the case of julia-mode, something like Other versions: 1.2.3 (melpa-stable, COMMIT MISMATCH). with a help annotation. >> Could you perhaps elaborate on why you consider this to be a bug? > > To be clear I meant that it's a bug in the remote package. Perhaps I am being pedantic, but this sounds like a mistake, not a /bug/ in the code itself. > Specifically, in the case of julia-mode, it was a bug for it to have > introduced the 0.4 package header in a commit that was different from > the one that was tagged as 0.4. Do you know which of the two is correct? In cases like these, it sounds like one should contact the maintainers to remind them that they shouldn't repeat the same issue in the future. > I don't consider this to be a bug in package.el. However, if package.el > had made it obvious that the 0.4 version from melpa-stable isn't the > same as the 0.4 version from nongnu, it would have saved me some > headache. > > For my part, I know better than to take version numbers at face value > now, especially when they are from different archives. > >>>> IIRC the commit of a VC package should appear under the commit header. >>> >>> That necessitates additional clicks. If those clicks or button pushes >>> could be avoided it would improve user convenience. >> >> True, but there are many things that could be made more convenient that >> only interest few people. I am trying to understand why this is >> something that would interest everyone. > > I don't believe this would interest _everyone_. I also don't believe > that that's the necessary bar for a feature. One might argue that this > is too niche a feature. I don't believe so, but I also am not sure if > my opinion on the matter has any significance. You are right, I misphrased that. It should be "always". If two package versions are based on the same commit, then I'd argue this information is not interesting, as this is assumed to be the default. > The people to whom this would be of interest would be users who have > melpa-stable enabled and who use some packages that are available both > on melpa-stable and either nongnu or gnu. > >> What I had in mind was using `vc-git-symbolic-commit'. So in the case >> of Git: If the commit >> is following the "master" branch, then it would print "master" instead >> a commit hash, likewise if the package is checked out on some tag, it >> could display that. > > At least for the scenario I am considering, symbolic names would not be > very useful. Commits are useful because they are unique (more or less). -- Philip Kaludercic on siskin