From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Philip Kaludercic Newsgroups: gmane.emacs.devel,gmane.emacs.orgmode Subject: Re: [RFC] The best way to choose an "action" at point: context-menu-mode, transient, which-key or embark? Date: Sat, 14 Dec 2024 10:12:44 +0000 Message-ID: <87seqqshcz.fsf@posteo.net> References: <87h676fvdn.fsf@localhost> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36847"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Psionic K , charles.choi@yummymelon.com, Emacs developers , emacs-orgmode@gnu.org, emacs.transient@jonas.bernoulli.dev, juri@linkov.net, justin@burkett.cc, karthikchikmagalur@gmail.com, omar@matem.unam.mx, tclaesson@gmail.com, visuweshm@gmail.com To: Ihor Radchenko Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 14 11:13:21 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tMP9E-0009T5-2a for ged-emacs-devel@m.gmane-mx.org; Sat, 14 Dec 2024 11:13:20 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tMP8x-00011R-85; Sat, 14 Dec 2024 05:13:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMP8u-000118-IX for emacs-devel@gnu.org; Sat, 14 Dec 2024 05:13:01 -0500 Original-Received: from mout01.posteo.de ([185.67.36.65]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tMP8p-0002qX-NW for emacs-devel@gnu.org; Sat, 14 Dec 2024 05:13:00 -0500 Original-Received: from submission (posteo.de [185.67.36.169]) by mout01.posteo.de (Postfix) with ESMTPS id 68DD7240027 for ; Sat, 14 Dec 2024 11:12:46 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1734171166; bh=uv5WdDB/9A1t8V7Mi5R4CqMX5JRlQNvqzqH8TCCOnpk=; h=From:To:Cc:Subject:Autocrypt:OpenPGP:Date:Message-ID:MIME-Version: Content-Type:From; b=G2bBhLeKU/sTJMVKW5najtitZPrfqdNcGSjvMPB1kZsyizmNhWzqjPZbzGSn6++ki QK1Slmiljph1HJ7/m/FE2PYx11Yhlaj4AWwBrMwSWtCnc9mfjglDqmSEl+Cx0ZJmBq NKorOGU8zD9EscqhzpeVjy3/U+GpxUx5bFoXqLLlI6KGela6P2Y8zoJb2YCJbwDhDN KVmD++9Zwksar1jG2ImULhQeF4S6YID7U7h/zreQtXuaG8KXyGigQWYuQx47mNTOHc SIyYBdhbwW17QEvmM4sLun6umOLajwJ6qqhPr87+lEnpgHccFYcP8A+7KL6V8fJa43 UBNpgRoyGPClA== Original-Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4Y9MTT0wKYz9rxL; Sat, 14 Dec 2024 11:12:45 +0100 (CET) In-Reply-To: <87h676fvdn.fsf@localhost> (Ihor Radchenko's message of "Sat, 14 Dec 2024 09:48:20 +0000") Autocrypt: addr=philipk@posteo.net; keydata= mDMEZBBQQhYJKwYBBAHaRw8BAQdAHJuofBrfqFh12uQu0Yi7mrl525F28eTmwUDflFNmdui0QlBo aWxpcCBLYWx1ZGVyY2ljIChnZW5lcmF0ZWQgYnkgYXV0b2NyeXB0LmVsKSA8cGhpbGlwa0Bwb3N0 ZW8ubmV0PoiWBBMWCAA+FiEEDg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwMFCQHhM4AFCwkI BwIGFQoJCAsCBBYCAwECHgECF4AACgkQ8xYDWXahwulikAEA77hloUiSrXgFkUVJhlKBpLCHUjA0 mWZ9j9w5d08+jVwBAK6c4iGP7j+/PhbkxaEKa4V3MzIl7zJkcNNjHCXmvFcEuDgEZBBQQhIKKwYB BAGXVQEFAQEHQI5NLiLRjZy3OfSt1dhCmFyn+fN/QKELUYQetiaoe+MMAwEIB4h+BBgWCAAmFiEE Dg7HY17ghYlni8XN8xYDWXahwukFAmQQUEICGwwFCQHhM4AACgkQ8xYDWXahwukm+wEA8cml4JpK NeAu65rg+auKrPOP6TP/4YWRCTIvuYDm0joBALw98AMz7/qMHvSCeU/hw9PL6u6R2EScxtpKnWof z4oM OpenPGP: id=philipk@posteo.net; url="https://keys.openpgp.org/vks/v1/by-email/philipk@posteo.net"; preference=signencrypt Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@posteo.net; helo=mout01.posteo.de X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:326476 gmane.emacs.orgmode:164137 Archived-At: Can I please be removed from the CCs in this thread? Ihor Radchenko writes: > Psionic K writes: > >>> intercepts the main loop > >> This is optional, per transient menu (prefix) and the commands within it. >> A common technique, used by magit and others, is to have entry point >> commands in the regular keymap so that many commands can be started without >> traversing several menus. If you want normal un-shadowed bindings active >> at the same time, the prefix has a slot called `transient-non-suffix' that >> is similar to the `:suppress' option in keymaps or setting a `t' >> `undefined' binding in a keymap. However the results of mixing self-insert >> and modal or modal and another modal are generally bad. > > Thanks for the info! > So, we can have something like > > :transient-non-suffix 'leave > > and then pressing something that is not bound to a suffix or infix will > run the parent keymap command, automatically leaving transient state. > >> - Normalizing how to obtain arguments when being called independently as an >> interactive command versus being called as a Transient suffix > > I think it is addressed in the example patch I shared. There, we pass > around the original function arguments via macro expansion (!arg-name) > > ["Open" ("b" "bibliography entry" (org-cite-basic-goto !citation !prefix))] > >> In the short term, to punch the first two problems in the face, override >> the `:setup-children' method. If you know what keymap you are borrowing >> bindings from, you can synchronize it at display time. > > This is also partially solved. We do use :setup-children, although the > initial implementation simply reads user customization into menu layout. > > I believe that we can read a keymap in similar way and generate > transient layout automatically. > >> What I fear is a system like org-speed-keys which relies on an override of >> `org-self-insert' and is yet another orthogonal system. I much prefer the >> Lispy style of integration, which uses a keymap. Using keymaps, even if >> they are not active, to generate transient key bindings via :setup-children >> is the best way to have certain integration with other Emacs tools. > > May you please elaborate?