From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Pip Cet via "Emacs development discussions." Newsgroups: gmane.emacs.devel Subject: Re: igc, macOS avoiding signals Date: Sat, 28 Dec 2024 12:49:38 +0000 Message-ID: <87seq8m0r6.fsf@protonmail.com> References: Reply-To: Pip Cet Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="14152"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Emacs Devel To: =?utf-8?Q?Gerd_M=C3=B6llmann?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sat Dec 28 14:03:57 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1tRWU0-0003X2-Qd for ged-emacs-devel@m.gmane-mx.org; Sat, 28 Dec 2024 14:03:56 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tRWTR-0000na-R7; Sat, 28 Dec 2024 08:03:21 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRWGK-0006Bw-Qf for emacs-devel@gnu.org; Sat, 28 Dec 2024 07:49:49 -0500 Original-Received: from mail-10631.protonmail.ch ([79.135.106.31]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tRWGJ-0003rX-1k for emacs-devel@gnu.org; Sat, 28 Dec 2024 07:49:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1735390183; x=1735649383; bh=JSsp/ZjvtYVF57A1xQ4o/n4jTPSH3daafY7239enjRw=; h=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References: Feedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID: Message-ID:BIMI-Selector:List-Unsubscribe:List-Unsubscribe-Post; b=GxCwIiXcGS49sgMX+yCqD0Wlg9pU7dT1SpkPfywJPqjGxoYjUyzTt7SjTEKp2i9pj aDyofeh84XohiUH04Y9ParKhoCQIxJ4JelBBB8grYXFr1UPTlGxP/CviIQmhBdGHVd 5RYPYxlWeog6ivGFYRMGhagNBomfXW5jI37TFekQoWnBH7cXzJyec1gKnsQUyb7Jp7 fZkVT/bAbmF2y3AxnyA1M26OeLvZ4DTLxSgzO6b4Bj/BxGPNsd2C1R/uh74qi+wATM Pfsn8ltRej9P2C2GrnnZf4qlTKpx4wJjRJ4dK9uAZyfLsYrnD+2tp2hbL91kbhAtZr NOGDLiN3qlkuw== In-Reply-To: Feedback-ID: 112775352:user:proton X-Pm-Message-ID: 722584f4e479591bd196eb1017248d1bdf2ea4fe Received-SPF: pass client-ip=79.135.106.31; envelope-from=pipcet@protonmail.com; helo=mail-10631.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Mailman-Approved-At: Sat, 28 Dec 2024 08:03:19 -0500 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:327259 Archived-At: Gerd M=C3=B6llmann writes: > This is about commit > > ceec5ace134081b64dbf46c4fb5702ef5209c5fd > Avoid MPS being interrupted by signals > > I've been running with this for some days now, and must report that > Emacs feels a _bit_ different here in interactive use, maybe one could > say not as smooth. (macOS, --without-ns, in my fork of Emacs, which is > very recent master++). I think we should quantify that. Set a watchpoint on igc_global->signals_pending, check how often we even set that, and how often we call igc_maybe_quit, particularly if we were previously idle. Maybe it's sufficient to call it again from the idle handler. > After reverting the commit, it's feeling smoother again. Entirely possible. Let's measure it. > Maybe it's a point for making things conditional on OS, don't know. If we establish it's not necessary on macOS, sure. If it slows things down that's kind of a hint that it might be necessary, though. Pip